t by AC_C_BIGENDIAN in their builds.
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris Engineering - http://blogs.oracle.com/alanc
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-dev
e and always have, because there's enough differences in what
they #define for their platform:
http://cgit.freedesktop.org/xorg/xserver/tree/include/servermd.h
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris Engineering - http://blogs.oracle
status = GrabButton(client, dev, mod_dev, stuff->detail,
Reviewed-by: Alan Coopersmith
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris Engineering - http://blogs.oracle.com/alanc
___
xorg-devel@lists.x.or
Includes fallback asprintf() for pre-Unix08 platforms
Signed-off-by: Alan Coopersmith
---
configure.ac |7 +-
mkcomposecache.c | 66 +-
2 files changed, 61 insertions(+), 12 deletions(-)
diff --git a/configure.ac b/configure.ac
PCI ids to driver names? If so, cool, that's one less distro
patch I need to carry to update that table for them.
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris Engineering - http://blogs.oracle.com/
ist/
remote: I: patch #20003 updated using rev
a6dcf2201a05adbff54122df05a1e6325936abb6.
remote: I: 1 patch(es) updated to state Accepted.
To ssh://git.freedesktop.org/git/xorg/lib/libX11
b64bee2..a6dcf22 master -> master
--
-Alan Coopersmith- alan.coopersm...@oracle.c
bSAGroup(act));
TryCopyStr(buf, tbuf, sz);
if (act->type == XkbSA_LockGroup)
return True;
Oops, sorry about that - clearly I did too much copy & pasting.
Reviewed-by: Alan Coopersmith
--
-Alan Coopersmith- a
*port = "0";
XtransConnInfo inetdCI;
OldListenRec *old_listen;
int portnum;
Reviewed-by: Alan Coopersmith
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris Engineering - http://bl
_list args;
+va_start(args, f);
+VErrorF(f, args);
va_end(args);
}
Shouldn't that have been done with ErrorF instead of NoticeF, to keep
them with the error prefix & syslog level? Seems strange to have
VErrorF come through at a different level than ErrorF.
--
'port' variable in
GetInetdListenInfo when fetching the ReopenInfo. That's not strictly
necessary here, but will be useful when the Reopen API in libxtrans
changes to take a constant parameter.
Signed-off-by: Keith Packard
Reviewed-by: Alan Coopersmith
--
-A
#writing
http://people.freedesktop.org/~dbn/pkg-config-guide.html#faq
http://err.no/personal/blog/2008/Mar/25
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris Engineering - http://blogs.oracle.com/alanc
___
xorg
this build?
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris Engineering - http://blogs.oracle.com/alanc
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info
For some reason, Solaris libc sprintf() doesn't add "0x" to the %p output
as glibc does, causing the test to fail for not matching the exact output.
Since the 0x is desirable, we add it ourselves to the test string.
Signed-off-by: Alan Coopersmith
---
test/signal-logging.c |
ble
POSIX sigaction function to provide BSD/Linux semantics in a signal()
style API, so we switch to use that in this test case, allowing it to
pass on Solaris.
Signed-off-by: Alan Coopersmith
---
test/os.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/test/os.c b/test/o
Caused Solaris Studio cc to complain in every file which included it:
"../include/eventstr.h", line 179: warning: syntax error:
empty member declaration
Signed-off-by: Alan Coopersmith
---
include/eventstr.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
64 in indirect_dispatch_swap.c).
Hmm, I don't see that, probably because the bswap_64 macro it uses is
platform specific.
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris Engineering - http://blogs.oracle
during the build refers to the string type.
We could wrap it in #ifdef __sun I guess, if that helps. (Apple seems to
already have #define for it in dix/Xserver.d, not sure if BSD needs it or
not.)
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris
red fully modernized?
|
I already moved -Wlogical-op out of that list and back into the set we use:
http://cgit.freedesktop.org/xorg/util/macros/commit/?id=72b211419977a211c871232d66e1a668e3cf702f
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solari
On 02/ 4/14 01:33 PM, Peter Hutterer wrote:
include: make the various button array lengths more obious
obvious?
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris Engineering - http://blogs.oracle.com/alanc
void ":" pointer to function(void) returning void
Signed-off-by: Alan Coopersmith
---
glx/glxext.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/glx/glxext.c b/glx/glxext.c
index 6a34ac2..c9b8cc5 100644
--- a/glx/glxext.c
+++ b/glx/glxext.c
@@ -554,9 +
submit it on http://bugs.freedesktop.org/.
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris Engineering - http://blogs.oracle.com/alanc
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.or
Needed for Xorg to define/export xf86GTFMode(), introduced in
xorg-server release 1.6.0 / commit ca5625b911e65fdfd4.
Signed-off-by: Alan Coopersmith
---
configure.ac |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 6ac2333..79532ab 100644
to make it work.
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris Engineering - http://blogs.oracle.com/alanc
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://list
On 01/29/14 09:47 PM, Peter Hutterer wrote:
so it's less that the driver needs to get switched to vuid, the _kernel_
needs to provide evdev functionality.
Is there actually a spec for the required functionality, or is this basically
just "the kernel needs to be Linux"?
-
, we still have one under Solaris - "VUID", which is what the
xf86-input-mouse & -kbd drivers talk to. In theory I could rearchitect
xf86-input-evdev to talk to VUID too, but have never had enough of a need
to invest that kind of time as long as -mouse & -kbd keep working.
The first three were originally mailed on 12/26, the last one on 1/18.
I've gone ahead and pushed the Xlib side of the RANDR 1.4 request/error/event
names patch to the libX11 git repo already.
Alan Coopersmith (4):
Link libvgahw with $(PCIACCESS_LIBS) as well
On realloc failure,
Checked against randrproto.txt & randr.h
Signed-off-by: Alan Coopersmith
---
dix/protocol.txt | 11 +++
1 file changed, 11 insertions(+)
diff --git a/dix/protocol.txt b/dix/protocol.txt
index 8e152ed..f83f38c 100644
--- a/dix/protocol.txt
+++ b/dix/protocol.txt
@@ -311,11 +31
Flagged by cppcheck 1.62:
[hw/xfree86/common/xf86Helper.c:220] -> [hw/xfree86/common/xf86Helper.c:231]:
(warning) Possible null pointer dereference: pScrn - otherwise it is
redundant to check it against null.
Signed-off-by: Alan Coopersmith
---
hw/xfree86/common/xf86Helper.c |7 ---
Signed-off-by: Alan Coopersmith
---
hw/xfree86/vgahw/Makefile.am |1 +
1 file changed, 1 insertion(+)
diff --git a/hw/xfree86/vgahw/Makefile.am b/hw/xfree86/vgahw/Makefile.am
index f0b6574..4b718b4 100644
--- a/hw/xfree86/vgahw/Makefile.am
+++ b/hw/xfree86/vgahw/Makefile.am
@@ -1,5 +1,6
Flagged by cppcheck 1.62:
[dix/dixfonts.c:1792]: (error) Common realloc mistake:
'font_path_string' nulled but not freed upon failure
Signed-off-by: Alan Coopersmith
---
dix/dixfonts.c |9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/dix/dixfon
On 01/25/14 12:30 PM, Julien Cristau wrote:
On Sat, Jan 25, 2014 at 10:46:03 -0800, Alan Coopersmith wrote:
On 01/25/14 07:09 AM, Claus Assmann wrote:
On Sat, Jan 25, 2014, Julien Cristau wrote:
gpg: BAD signature from "Alex Deucher "
Same here.
If this isn't just me, an
for the recipient), please contact the sender by reply email and delete
all copies of this message.
For corporate legal information go to:
http://www.cisco.com/web/about/doing_business/legal/cri/index.html
--
-Alan Coopersmith- alan.coop
open
bug in bugzilla still.)
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris Engineering - http://blogs.oracle.com/alanc
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/x
On 01/25/14 01:32 AM, walter harms wrote:
Am 25.01.2014 08:42, schrieb Alan Coopersmith:
Reported-by: Ilja Van Sprundel
Signed-off-by: Alan Coopersmith
---
Xi/xichangehierarchy.c |4
1 file changed, 4 insertions(+)
diff --git a/Xi/xichangehierarchy.c b/Xi/xichangehierarchy.c
Reported-by: Ilja Van Sprundel
Signed-off-by: Alan Coopersmith
---
Xi/xichangehierarchy.c |4
1 file changed, 4 insertions(+)
diff --git a/Xi/xichangehierarchy.c b/Xi/xichangehierarchy.c
index e2f4b8a..9e36354 100644
--- a/Xi/xichangehierarchy.c
+++ b/Xi/xichangehierarchy.c
@@ -143,6
Now shows:
--with-xkb-bin-directory=DIR
Directory containing xkbcomp program (default:
${bindir})
Signed-off-by: Alan Coopersmith
---
configure.ac |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b
On 01/24/14 12:05 AM, Peter Hutterer wrote:
The request is followed by mask_len 4-byte units, then followed by the actual
modifiers.
Also fix up the swapping test, which had the same issue.
Reported-by: Alan Coopersmith
Signed-off-by: Peter Hutterer
---
Changes to v1:
- turns out the
On 01/23/14 10:53 PM, Peter Hutterer wrote:
The request is followed by mask_len 4-byte units, then followed by the actual
modifiers.
Reported-by: Alan Coopersmith
Signed-off-by: Peter Hutterer
---
Xi/xipassivegrab.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Xi
Now that Xlib requires xcb to build, would it make sense to generate Xlib's
src/XErrorDB from the xcb proto xml files at build time? It would save
having to remember to update when extensions change (I just happened to notice
RANDR 1.4 was missing over a year after it shipped, and it doesn't loo
Checked against randrproto.txt & randr.h
Signed-off-by: Alan Coopersmith
---
src/XErrorDB | 12
1 file changed, 12 insertions(+)
diff --git a/src/XErrorDB b/src/XErrorDB
index 8048907..7b6d465 100644
--- a/src/XErrorDB
+++ b/src/XErrorDB
@@ -898,12 +898,24 @@ XRequest.RAND
Checked against randrproto.txt & randr.h
Signed-off-by: Alan Coopersmith
---
dix/protocol.txt | 11 +++
1 file changed, 11 insertions(+)
diff --git a/dix/protocol.txt b/dix/protocol.txt
index 8e152ed..f83f38c 100644
--- a/dix/protocol.txt
+++ b/dix/protocol.txt
@@ -311,11 +31
-by: Alan Coopersmith
---
README |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/README b/README
index 931821b..65f1aa4 100644
--- a/README
+++ b/README
@@ -43,7 +43,8 @@ configure script takes various options to enable or disable
them:
snf bitmap fonts - standard
Signed-off-by: Alan Coopersmith
---
README | 58 ++
1 file changed, 58 insertions(+)
diff --git a/README b/README
index 97a9e8a..931821b 100644
--- a/README
+++ b/README
@@ -5,6 +5,64 @@ X Font Server (xfs), and some font utilities
Bitstream Speedo support was removed in commit d50de26430c1a114a.
All scalable font support now goes through FreeType, which can
also handle some bitmap font formats as well.
Signed-off-by: Alan Coopersmith
---
configure.ac |5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff
On 01/13/14 05:30 PM, Keith Packard wrote:
Alan Coopersmith writes:
Does this need to be #ifdef'ed to avoid breaking people building
1.15.x & earlier releases?
No. 'pointer' was just a typedef for 'void *'.
Right, and replacing it doesn't seem to ca
ople building
1.15.x & earlier releases?
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris Engineering - http://blogs.oracle.com/alanc
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x
Some of the bits I forget and have to dig out of the protocol spec
every few years when I need to know again.
Signed-off-by: Alan Coopersmith
---
Xproto.h | 17 +++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git a/Xproto.h b/Xproto.h
index 76e2c99..6cdea89 100644
ease contact the sender by reply email and delete
all copies of this message.
Please don't mail public mailing lists with questions you intend to keep
confidential. It is impossible to delete all the copies of this message
you have caused to be distributed to many peop
Quiets cppcheck warning:
[fc/fserve.c:2972]: (error) Uninitialized variable: lcreq
Signed-off-by: Alan Coopersmith
---
src/fc/fserve.c |1 +
1 file changed, 1 insertion(+)
diff --git a/src/fc/fserve.c b/src/fc/fserve.c
index a445144..fc44d19 100644
--- a/src/fc/fserve.c
+++ b/src/fc
ration
of 'FontFileStartListFonts' was here
Signed-off-by: Alan Coopersmith
---
src/fontfile/catalogue.c |5 -
1 file changed, 5 deletions(-)
diff --git a/src/fontfile/catalogue.c b/src/fontfile/catalogue.c
index 6b6fc09..6230930 100644
--- a/src/fontfile/catalogue.c
+++ b/src/
Found by cppcheck 1.63:
[FreeType/xttcap.c:621] -> [FreeType/xttcap.c:624]: (performance)
Variable 'len' is reassigned a value before the old one has been used.
Signed-off-by: Alan Coopersmith
---
src/FreeType/xttcap.c |1 -
1 file changed, 1 deletion(-)
diff --git a/src/Free
sed-but-set-variable]
fpe.c: In function 'BuiltinResetFPE':
fpe.c:57:22: warning: variable 'dir' set but not used
[-Wunused-but-set-variable]
Signed-off-by: Alan Coopersmith
---
src/builtins/fpe.c |3 ---
src/fontfile/catalogue.c |4
2 files changed, 7 deleti
FSmalloc(size) malloc((size))
#endif
(plus similar for FScalloc & FSrealloc).
The +1 for the string-ending \0 byte ensures that the size will always be >0,
thus the difference doesn't matter.
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solari
ify events will be sent when properties change on
Reviewed-by: Alan Coopersmith
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris Engineering - http://blogs.oracle.com/alanc
___
xorg-devel@lists.x.org: X.Org d
Signed-off-by: Alan Coopersmith
---
src/FSOpenServ.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/FSOpenServ.c b/src/FSOpenServ.c
index b8ccb2f..faebe13 100644
--- a/src/FSOpenServ.c
+++ b/src/FSOpenServ.c
@@ -127,10 +127,9 @@ FSOpenServer(const char *server
Signed-off-by: Alan Coopersmith
---
configure.ac |3 +++
src/FSErrDis.c |5 +
src/FSlibInt.c |4
3 files changed, 12 insertions(+)
diff --git a/configure.ac b/configure.ac
index bcc4187..26fffb1 100644
--- a/configure.ac
+++ b/configure.ac
@@ -51,6 +51,9
S
outside the Xtrans code calls a gethostname() function.
Flagged by cppcheck 1.62:
[FSlibInt.c:1060]: (style) The function '_FSGetHostname' is never used.
Signed-off-by: Alan Coopersmith
---
src/FSlibInt.c | 51 ---
src/FSlibint.h
ed
with "unused" placeholders to maintain struct layout/size.
Flagged by cppcheck 1.62:
[FSlibInt.c:973]: (style) The function '_FSAllocScratch' is never used.
Signed-off-by: Alan Coopersmith
---
include/X11/fonts/FSlib.h |4 ++--
src/FSlibInt.c| 19
of calls Solaris Studio cc
generates to the __errno() function to get the thread-specific errno value.
Signed-off-by: Alan Coopersmith
---
src/FSlibInt.c |5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/FSlibInt.c b/src/FSlibInt.c
index 0fabc96..cb53e44 100644
--- a/
#x27;_FSEventsQueued' is never used.
Signed-off-by: Alan Coopersmith
---
src/FSlibInt.c | 36
src/FSlibint.h |1 -
2 files changed, 37 deletions(-)
diff --git a/src/FSlibInt.c b/src/FSlibInt.c
index 48091cf..eeab20c 100644
--- a/src/FSlibInt.c
+++ b/
7;_FSWireToEvent' is never used.
Signed-off-by: Alan Coopersmith
---
src/FSlibInt.c | 29 -
src/FSlibint.h |1 -
2 files changed, 30 deletions(-)
diff --git a/src/FSlibInt.c b/src/FSlibInt.c
index eeab20c..71f6ac1 100644
--- a/src/FSlibInt.c
+++ b/src/FSl
On 01/ 7/14 01:14 PM, Trevor Woerner wrote:
On 01/07/14 15:46, Alan Coopersmith wrote:
On 01/ 7/14 12:41 PM, Trevor Woerner wrote:
On 01/07/14 11:35, Alan Coopersmith wrote:
This release includes the fix for CVE-2013-6462, as well as other
security
hardening and code cleanups, and makes
On 01/ 7/14 12:41 PM, Trevor Woerner wrote:
On 01/07/14 11:35, Alan Coopersmith wrote:
This release includes the fix for CVE-2013-6462, as well as other security
hardening and code cleanups, and makes libXfont compatible with libXtrans 1.3
on Solaris.
Should the libXfont_la_LDFLAGS be bumped
this request executes if the output configuration has changed since the
+ client connected, to avoid race conditions.
If 'enable' contains RROutputPropertyNotifyMask,
RROutputPropertyNotify events will be sent when properties change on
Reviewed-by: Alan Coopersm
GrabDevice() calls AllocGrab() which can fail and return NULL.
This return value is not checked, and can cause NULL pointer dereferences.
Reported-by: Ilja Van Sprundel
Signed-off-by: Alan Coopersmith
---
dix/events.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a
CheckPassiveGrabsOnWindow() calls AllocGrab() which can fail and return NULL.
This return value is not checked, and can cause NULL pointer dereferences.
Signed-off-by: Alan Coopersmith
---
dix/events.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/dix/events.c b/dix/events.c
index
If either the initial calloc or the xi2mask_new fails, grab is NULL,
but if a src grab is passed in, it was always being written to by
CopyGrab (and if that failed, dereferenced again in teardown).
Signed-off-by: Alan Coopersmith
---
dix/grabs.c | 11 +--
1 file changed, 5 insertions
lly part of the main mesa repo but
got split out later and we never added them to build.sh - whether that was
accidental or intentional, I'm not sure.
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris Engineering -
On 01/ 5/14 01:26 PM, Trevor Woerner wrote:
On 01/05/14 13:10, Alan Coopersmith wrote:
On 01/ 4/14 11:35 AM, Patrik Jakobsson wrote:
asprintf needs _GNU_SOURCE to be defined or you'll get an implicit
declaration
and build failure. I fixed it with:
Only on Linux, and you should be using
On 01/ 5/14 10:32 AM, Patrik Jakobsson wrote:
On Sun, Jan 5, 2014 at 7:10 PM, Alan Coopersmith
wrote:
On 01/ 4/14 11:35 AM, Patrik Jakobsson wrote:
asprintf needs _GNU_SOURCE to be defined or you'll get an implicit
declaration
and build failure. I fixed it with:
Only on Linux, an
/git/xorg/driver/xf86-input-mouse
8c75f6e..ea504b2 master -> master
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris Engineering - http://blogs.oracle.com/alanc
___
xorg-devel@lists.x.org: X.Org developm
On 01/ 4/14 11:35 AM, Patrik Jakobsson wrote:
asprintf needs _GNU_SOURCE to be defined or you'll get an implicit declaration
and build failure. I fixed it with:
Only on Linux, and you should be using xf86-input-evdev there, not -mouse.
--
-Alan Coopersmith- alan.coo
rver/os/io.c:941]: (style) Same expression on both
sides of '||'.
This quiets it, and reduces the number of calls Solaris Studio cc
generates to the __errno() function to get the thread-specific errno value.
Signed-off-by: Alan Coopersmith
---
os/io.c | 11 ---
1 file c
Left behind when 15e5eaf62897 removed support for building without XCB.
Signed-off-by: Alan Coopersmith
---
src/XlibInt.c | 33 -
1 file changed, 33 deletions(-)
diff --git a/src/XlibInt.c b/src/XlibInt.c
index 7521f12..a5350e9 100644
--- a/src/XlibInt.c
+++ b
+ ─ ───
GUID yes not mandatory
❧❧❧
Reviewed-by: Alan Coopersmith
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris Engineering - http://blogs.oracle.com/alanc
ation,
but we've not been effective at getting transitioned to it. (We keep
talking about using XCB to generate server-side protocol handling & byte
swapping, but never have, and haven't made it possible for all the clients
to move to XCB, since there's still a couple miss
function prototypes near where pointer -> void * changes were
made. There are plenty more of these to fix.
Signed-off-by: Keith Packard
Reviewed-by: Alan Coopersmith
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris Engineering - http://blogs.oracle.
xhost.c: In function ‘get_hostname’:
xhost.c:665:23: error: ‘NI_MAXHOST’ undeclared (first use in this function)
Signed-off-by: Alan Coopersmith
---
configure.ac |5 +
1 file changed, 5 insertions(+)
diff --git a/configure.ac b/configure.ac
index 0d6f506..4ec4de0 100644
--- a/configure.ac
‘ListenToAllClients’:
os/connection.c:801:2: error: ‘fd_mask’ undeclared (first use in this function)
Signed-off-by: Alan Coopersmith
---
configure.ac |5 +
1 file changed, 5 insertions(+)
diff --git a/configure.ac b/configure.ac
index f65a752..55ca68d 100644
--- a/configure.ac
+++ b
’
[-Werror=implicit-function-declaration]
gethost.c:196:9: warning: nested extern declaration of ‘strlcpy’
[-Wnested-externs]
Signed-off-by: Alan Coopersmith
---
configure.ac |5 +
1 file changed, 5 insertions(+)
diff --git a/configure.ac b/configure.ac
index 3b135a9..51f363e 100644
--- a
: 'fd_mask' undeclared (first use in this
function)
../../src/FSConnServ.c:166:6: note: each undeclared identifier is reported only
once for each function it appears in
Signed-off-by: Alan Coopersmith
---
configure.ac |5 +
1 file changed, 5 insertions(+)
diff --git a/configu
: 'fd_mask' undeclared (first use in this
function)
../../src/FSConnServ.c:166:6: note: each undeclared identifier is reported only
once for each function it appears in
Signed-off-by: Alan Coopersmith
---
configure.ac |5 +
1 file changed, 5 insertions(+)
diff --git a/configu
Signed-off-by: Alan Coopersmith
---
hw/xfree86/vgahw/Makefile.am |1 +
1 file changed, 1 insertion(+)
diff --git a/hw/xfree86/vgahw/Makefile.am b/hw/xfree86/vgahw/Makefile.am
index f0b6574..4b718b4 100644
--- a/hw/xfree86/vgahw/Makefile.am
+++ b/hw/xfree86/vgahw/Makefile.am
@@ -1,5 +1,6
Flagged by cppcheck 1.62:
[dix/dixfonts.c:1792]: (error) Common realloc mistake:
'font_path_string' nulled but not freed upon failure
Signed-off-by: Alan Coopersmith
---
dix/dixfonts.c |9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/dix/dixfon
Flagged by cppcheck 1.62:
[hw/xfree86/common/xf86Helper.c:220] -> [hw/xfree86/common/xf86Helper.c:231]:
(warning) Possible null pointer dereference: pScrn - otherwise it is
redundant to check it against null.
Signed-off-by: Alan Coopersmith
---
hw/xfree86/common/xf86Helper.c |7 ---
Flagged by cppcheck 1.62:
[src/encparse.c:303] -> [src/encparse.c:303]: (performance, inconclusive)
Variable 'value1' is reassigned a value before the old one has been used
if variable is no semaphore variable.
Signed-off-by: Alan Coopersmith
---
src/encparse.c |2 +-
1 fi
clear & selectAll are set to 0 already a few lines earlier,
affectWhich is set to XkbMapNotifyMask a few lines later.
None are used between the other assignments and the removed ones.
Signed-off-by: Alan Coopersmith
---
src/xkb/XKB.c |3 ---
1 file changed, 3 deletions(-)
diff --git a
Flagged by cppcheck 1.62:
[lib/libX11/src/xkb/XKBGeom.c:479] -> [lib/libX11/src/xkb/XKBGeom.c:480]:
(warning) Possible null pointer dereference: row - otherwise it is
redundant to check it against null.
Signed-off-by: Alan Coopersmith
---
src/xkb/XKBGeom.c |2 +-
1 file changed
Found by cppcheck 1.62:
[src/register.c:84]: (style) Variable 'name' is assigned a value
that is never used.
[src/register.c:182]: (style) Variable 'name' is assigned a value
that is never used.
Signed-off-by: Alan Coopersmith
---
src/register.c |8 ++--
1 file c
Found by cppcheck 1.62:
[src/accept.c:113]: (error) Memory leak: iceConn.connection_string
Signed-off-by: Alan Coopersmith
---
src/accept.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/src/accept.c b/src/accept.c
index 6f23338..610e01b 100644
--- a/src/accept.c
+++ b/src/accept.c
insertions(+), 20 deletions(-)
For the series:
Reviewed-by: Alan Coopersmith
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris Engineering - http://blogs.oracle.com/alanc
___
xorg-devel@lists.x.org: X.Org
On 12/17/13 08:33 AM, Gaetan Nadon wrote:
Now that Imake SIGNALRETURNSINT has been removed, the signal handler
function return type can only be void.
Signed-off-by: Gaetan Nadon
Reviewed-by: Alan Coopersmith
--
-Alan Coopersmith- alan.coopersm...@oracle.com
On 12/17/13 08:33 AM, Gaetan Nadon wrote:
Assume signal handlers return void, as C89 requires
Signed-off-by: Gaetan Nadon
---
signals.c | 16 ++--
1 file changed, 2 insertions(+), 14 deletions(-)
Reviewed-by: Alan Coopersmith
--
-Alan Coopersmith
changed, 2 insertions(+), 51 deletions(-)
Reviewed-by: Alan Coopersmith
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris Engineering - http://blogs.oracle.com/alanc
___
xorg-devel@lists.x.org: X.Org development
On 12/16/13 08:46 AM, Keith Packard wrote:
Alan Coopersmith writes:
Though I wonder if these typedefs should get moved from x11proto to
the xserver headers someday.
Well, the BlockHandleProcPtr typedef is used by both the X server and
the font server, which is why it's in Xdefs.h; the
xtrans.m4: replace deprecated AC_HAVE_LIBRARY with AC_CHECK_LIB
xtrans.m4: remove AC_TYPE_SIGNAL and Imake SIGNALRETURNSINT
Xtransutil.c | 14 +-
xtrans.m4| 13 ++---
2 files changed, 7 insertions(+), 20 deletions(-)
For all 3:
Reviewed-by: Alan Coopersmith
,
+typedef void (* BlockHandlerProcPtr)(void * /* blockData */,
OSTimePtr /* pTimeout */,
-pointer /* pReadmask */);
+void * /* pReadmask */);
#endif
Reviewed-by: Alan Coopersmith
Though I
e's patches. The current set of maintainers is listed on
http://patchwork.freedesktop.org/project/Xorg/
and I believe any existing maintainer can add new ones if more developers would
like to help us clear the backlog or update patches as time goes on, so that we
c
LIBEXT@
libXaw.7.@LIBEXT@)
else
$(AM_V_at)rm -f $(DESTDIR)$(libdir)/libXaw.@LIBEXT@.7
- $(AM_V_GEN)(cd $(DESTDIR)$(libdir) && ln -s libXaw7.@LIBEXT@.7
libXaw.@LIBEXT@.7)
+ $(AM_V_GEN)(cd $(DESTDIR)$(libdir) && $(LN_S) libXaw7.@LIBEXT@.7
libXaw
ng "err" name with a
variable declared in the function calling the macro.
Signed-off-by: Alan Coopersmith
---
wrapper/XvMCWrapper.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/wrapper/XvMCWrapper.c b/wrapper/XvMCWrapper.c
index bff5a8b..9bdf033 1006
801 - 900 of 4095 matches
Mail list logo
