[PATCH] render: Improve glyph double hashing

2011-08-01 Thread Andrea Canciani
Instead of artificially introducing collisions in the step value by replacing 0 with 1 (which causes the value 1 to have twice the frequency of any other value), the step value can simply be computed as an uniformly distributed value in the range [1, rehash], extremes included. This is safe

Document gradients and PDF blend modes

2011-07-28 Thread Andrea Canciani
The RENDER specification is currently lacking documentation if the expected behavior of PDF blend modes and gradient pictures. This is an attempt to fix this issue. I tracked the documentation available in pixman comments and in the PDF specification and tried to integrate it in the protocol

[PATCH 1/2] Document PDF blend operators

2011-07-28 Thread Andrea Canciani
PDF blend operators were added in RENDER 0.11, but no documentation is available in the specification. --- renderproto.txt | 126 +++--- 1 files changed, 119 insertions(+), 7 deletions(-) diff --git a/renderproto.txt b/renderproto.txt index

[PATCH 2/2] Document gradients

2011-07-28 Thread Andrea Canciani
0.10 introduced gradient picture sources, but did not provide the documentation which describes their behavior. --- renderproto.txt | 63 +- 1 files changed, 61 insertions(+), 2 deletions(-) diff --git a/renderproto.txt b/renderproto.txt

[PATCH 0/2] Improve renderproto gradients documentation

2011-07-27 Thread Andrea Canciani
Currently RENDER does not specify conditions on the number of stops required for a valid gradients, but the X server returns an error whenever the stops are less than 2. In addition to this, some clients are currently misusing radial gradients by requesting the rendering of invalid radial

[PATCH 1/2] Document invalid nstops value

2011-07-27 Thread Andrea Canciani
Gradients must have at least one stop. Signed-off-by: Andrea Canciani ranm...@gmail.com --- renderproto.txt |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/renderproto.txt b/renderproto.txt index 9f1f231..4cf5dfc 100644 --- a/renderproto.txt +++ b/renderproto.txt

[PATCH 2/2] Allow arbitrary radial gradients

2011-07-27 Thread Andrea Canciani
Radial gradients whose inner circle is not contained in the outer circle are in use even if the protocol explicitly forbids them. Allowing them in the protocol makes it reasonable for programs to assume that they can be used. Signed-off-by: Andrea Canciani ranm...@gmail.com --- renderproto.txt

[PATCH] render: Allow single-stop gradients

2011-07-27 Thread Andrea Canciani
The Render specification allows single-stop gradients and pixman 0.22 (which the X server depends on) can rasterize them correctly. Signed-off-by: Andrea Canciani ranm...@gmail.com --- render/picture.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/render/picture.c

Re: [PATCH 2/2] render: Fix byteswapping of gradient stops

2010-12-02 Thread Andrea Canciani
On Thu, Dec 2, 2010 at 1:35 AM, Keith Packard kei...@keithp.com wrote: On Tue,  2 Nov 2010 20:10:32 +0100, Andrea Canciani ranm...@gmail.com wrote: The function swapStops repeatedly swaps the color components as CARD16, but incorrectly steps over them as if they were CARD32. This causes half

Re: [PATCH] Document invalid nStop value

2010-11-04 Thread Andrea Canciani
On Thu, Nov 4, 2010 at 2:50 AM, Soeren Sandmann sandm...@daimi.au.dk wrote: Andrea Canciani ranm...@gmail.com writes: Gradients must have at least one stop. ---  renderproto.txt |    6 ++  1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/renderproto.txt b/renderproto.txt

Re: [PATCH] Document invalid nStop value

2010-11-04 Thread Andrea Canciani
On Thu, Nov 4, 2010 at 9:20 AM, Andrea Canciani ranm...@gmail.com wrote: On Thu, Nov 4, 2010 at 2:50 AM, Soeren Sandmann sandm...@daimi.au.dk wrote: Andrea Canciani ranm...@gmail.com writes: Gradients must have at least one stop. ---  renderproto.txt |    6 ++  1 files changed, 6

[PATCH] Document invalid nStop value

2010-11-02 Thread Andrea Canciani
Gradients must have at least one stop. --- renderproto.txt |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/renderproto.txt b/renderproto.txt index 9f1f231..f6a9884 100644 --- a/renderproto.txt +++ b/renderproto.txt @@ -1089,6 +1089,8 @@ CreateLinearGradient

[PATCH 1/2] render: Allow single-stop gradients

2010-11-02 Thread Andrea Canciani
The Render specification allows single-stop gradients and pixman can correctly rasterize them. --- render/picture.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/render/picture.c b/render/picture.c index 7fda6b9..c8ea486 100644 --- a/render/picture.c +++

[PATCH 2/2] render: Fix byteswapping of gradient stops

2010-11-02 Thread Andrea Canciani
The function swapStops repeatedly swaps the color components as CARD16, but incorrectly steps over them as if they were CARD32. This causes half of the stops not to be swapped at all and some unrelated data be swapped instead. --- render/render.c |4 ++-- 1 files changed, 2 insertions(+), 2

Re: [Pixman] Gradients patches

2010-10-23 Thread Andrea Canciani
the range of valid values should be pretty safe. Andrea Canciani ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Single stop gradients

2010-10-23 Thread Andrea Canciani
as well. Andrea Canciani ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel