Re: [qxl] xspice: Adjust to X.org 1.19 changes

2016-12-15 Thread Christophe Fergeau
On Wed, Dec 14, 2016 at 12:07:55PM +0100, Hans de Goede wrote: > Hi, > > On 14-12-16 11:51, Christophe Fergeau wrote: > > In newer X.org versions, it's no longer supported to modify the set of > > FDs passed to a BlockHandler method to get notified when the FD ha

Re: [Spice-devel] [qxl] xspice: Adjust to X.org 1.19 changes

2016-12-15 Thread Christophe Fergeau
On Thu, Dec 15, 2016 at 02:01:03PM +0200, Uri Lublin wrote: > Hi Christophe, > > Please see some comments below > > On 12/14/2016 12:51 PM, Christophe Fergeau wrote: > > +static int watch_update_mask2(SpiceWatch *watch, int event_mask) > > +{ > > +SetNotify

[qxl] Xspice: Replace malloc/strdup use with xnfalloc/xnfstrdup

2016-12-15 Thread Christophe Fergeau
spiceqxl_*.c files are Xspice-only code. They contain a few uses of malloc/strdup, and none of these are checked for failure. It's better to replace these with xfnalloc/xnfstrdup which are provided by the X server and cannot fail (aborts on failure). Signed-off-by: Christophe Fergeau <cf

[qxl] xspice: Adjust to X.org 1.19 changes

2016-12-14 Thread Christophe Fergeau
In newer X.org versions, it's no longer supported to modify the set of FDs passed to a BlockHandler method to get notified when the FD has data to be read. This was limited anyway as we could only get read events this way, and had to do our own polling to get notified about socket writeability.

Re: [Spice-devel] [PATCH xf86-video-qxl] Fix crash caused by attempting to access the screen pixmap before it is created

2016-10-04 Thread Christophe Fergeau
> Yes, this was changed in the xserver by 69b782aa75bc06f11b8f9b532d5213f252c4c6c4 "xfree86: Set pScrn->pScreen before driver ScreenInit is called" Acked-by: Christophe Fergeau <cferg...@redhat.com> Christophe signature.asc Description: PGP signature ___

Re: [Spice-devel] [PATCH xf86-video-qxl] Adjust xspice_wakeup_handler() prototype for building xspice with server 1.19

2016-10-03 Thread Christophe Fergeau
JOR(ABI_VIDEODRV_VERSION) < 6 I'd use this here too to stay consistent (I assume they are equivalent here). Acked-by: Christophe Fergeau <cferg...@redhat.com> Christophe signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org

Re: [Spice-devel] xf86-video-qxl 0.1.5?

2016-04-12 Thread Christophe Fergeau
Hey, On Mon, Apr 11, 2016 at 12:34:20PM +0200, poma wrote: > > https://cgit.freedesktop.org/xorg/driver/xf86-video-qxl > > 0001-Remove-unused-variables.patch > ... > 0036-spiceqxl_audio-Stop-the-playback-channel-if-there-is.patch > > 36 patches queueing from the last xf86-video-qxl release -

Re: [Spice-devel] [PATCH] Update drm properties correctly

2014-11-13 Thread Christophe Fergeau
On Thu, Nov 06, 2014 at 03:47:44PM -0600, Jonathon Jongsma wrote: When connector properties got changed, those changes were not being propagated to user-space. This pushes those chagnes up so that e.g. new 'chagnes' typo here. Christophe pgpTPsEpy0Cob.pgp Description: PGP signature

[randrproto] spec: Fix RRCrtcGetModes typo

2014-10-28 Thread Christophe Fergeau
The correct name is RRCrtcGetInfo. Signed-off-by: Christophe Fergeau cferg...@redhat.com --- randrproto.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/randrproto.txt b/randrproto.txt index 864268e..5371eaa 100644 --- a/randrproto.txt +++ b/randrproto.txt @@ -929,7