Re: Merged repo for protocol headers? Why are they split?

Am 07.12.2017 17:18 schrieb "Emil Velikov" <emil.l.veli...@gmail.com>: On 6 December 2017 at 12:37, Daniel Martin <consume.no...@gmail.com> wrote: > Hi all, > > if anyone would like to have a look, I've pushed my current work on > the merged proto repo here: >

Re: Merged repo for protocol headers? Why are they split?

On 6 December 2017 at 16:23, Gioele Barabucci <gio...@svario.it> wrote: > Hi, > > 06.12.2017 13:37 Daniel Martin: >> >> PS: Just talked to Peter, he's okay with filter-branch as it gives us >> git-log without a struggle and references to other commits can

Re: Merged repo for protocol headers? Why are they split?

Hi all, if anyone would like to have a look, I've pushed my current work on the merged proto repo here: https://github.com/bartsch/xorg-proto2k/ It's generated as is with: https://github.com/bartsch/proto2k-generator/ I used git-filter-branch to: - move files to specific directories and

Re: Merged repo for protocol headers? Why are they split?

On 30 November 2017 at 14:28, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 29 November 2017 at 13:40, Daniel Martin <consume.no...@gmail.com> wrote: >> On 28 November 2017 at 16:51, Emil Velikov <emil.l.veli...@gmail.com> wrote: >>> One reasonably easy

Re: Merged repo for protocol headers? Why are they split?

On 29 November 2017 at 15:52, Pekka Paalanen <ppaala...@gmail.com> wrote: > On Wed, 29 Nov 2017 15:44:53 +0100 > Daniel Martin <consume.no...@gmail.com> wrote: > >> On 29 November 2017 at 15:01, Daniel Stone <dan...@fooishbar.org> wrote: >> > Hi, >

Re: Merged repo for protocol headers? Why are they split?

On 29 November 2017 at 15:01, Daniel Stone <dan...@fooishbar.org> wrote: > Hi, > > On 28 November 2017 at 12:38, Daniel Martin <consume.no...@gmail.com> wrote: >> On 27 November 2017 at 23:18, Peter Hutterer <peter.hutte...@who-t.net> >> wrote: >&

Re: Merged repo for protocol headers? Why are they split?

On 28 November 2017 at 16:51, Emil Velikov wrote: > One reasonably easy way to fold the repositories [while preserving all > the history] is via git filter-branch. Yes, but, filter-branch rewrites the history too. As Peter stated earlier, this breaks commit messages

Re: Merged repo for protocol headers? Why are they split?

On 27 November 2017 at 23:18, Peter Hutterer <peter.hutte...@who-t.net> wrote: > On Mon, Nov 27, 2017 at 09:07:12PM +0100, Daniel Martin wrote: >> On 22 November 2017 at 07:45, Adam Jackson <a...@nwnk.net> wrote: >> > On Wed, 2017-11-22 at 10:25 +1000, Peter Hutter

Re: Merged repo for protocol headers? Why are they split?

On 22 November 2017 at 07:45, Adam Jackson wrote: > On Wed, 2017-11-22 at 10:25 +1000, Peter Hutterer wrote: >> On Tue, Nov 21, 2017 at 03:28:20PM -0800, Dylan Baker wrote: >> > Your script splits each proto into a subdirectory, does it really make >> > sense to >> > do that, or

Merged repo for protocol headers? Why are they split?

Hi, I've ever wondered why are the proto headers split up into distinct repos? (It takes "ages" to just copy (install) a few files with autotools.) Dylan started to add meson support, but doing this for all protos sounds like a lot of copy'n'paste to do, lots of patches . Wouldn't it make more

[PATCH xserver 1/7] modesetting: Check for uevents on EnterVT

We have to re-evaluate the outputs (their ids) before drmmode_set_desired_modes() as it triggers drmmode_set_mode_major(). drmmode_set_mode_major() working with old ids is likely to fail and will tear down the server. Signed-off-by: Daniel Martin <consume.no...@gmail.com> --- hw/xfree86/d

[PATCH xserver 6/7] modesetting: Check for vanished outputs after updating output ids

Doing this before updating the output_ids is not a good idea as we compare the output id in the loop and the output id is unreliable. Signed-off-by: Daniel Martin <consume.no...@gmail.com> --- hw/xfree86/drivers/modesetting/drmmode_display.c | 51 ++-- 1 file chang

[PATCH xserver 4/7] modesetting: Check mode in drmmode_set_mode_major() first

We don't do anything in drmmode_set_mode_major() without a mode. Check it at the beginning and may bail out. With that, we can remove one indention level. No functional changes. Signed-off-by: Daniel Martin <consume.no...@gmail.com> --- hw/xfree86/drivers/modesetting/drmmode_display.c

[PATCH xserver 5/7] modesetting: Fix server crash on failing modeset

fail too. Additionally, log the crtc id if drmModeSetCrtc() fails anyway. That id plus KMS debug logs may help to solve potential other problems. Signed-off-by: Daniel Martin <consume.no...@gmail.com> --- hw/xfree86/drivers/modesetting/drmmode_display.c | 21 + 1 file c

[PATCH xserver 7/7] modesetting: Squash link-status check into output re-evaluation loop

By using a helper function it looks more streamlined and we don't do to drmModeGetConnectorCurrent() in drmmode_handle_uevents() twice. Signed-off-by: Daniel Martin <consume.no...@gmail.com> --- hw/xfree86/drivers/modesetting/drmmode_display.c | 99 +++- 1 file chang

[PATCH xserver 3/7] modesetting: Compare connector info to identify outputs

connectors is their PATH. Non-MST connectors can be identified using their type and type id. Signed-off-by: Daniel Martin <consume.no...@gmail.com> --- hw/xfree86/drivers/modesetting/drmmode_display.c | 52 +--- 1 file changed, 46 insertions(+), 6 deletions(-) diff --gi

[PATCH xserver 2/7] modesetting: Store info to identify a connector

That is the connector_type, connector_type_id and path_blob. We'll identify a connector using this information later, as the output_id is unreliable. Signed-off-by: Daniel Martin <consume.no...@gmail.com> --- hw/xfree86/drivers/modesetting/drmmode_display.c | 10 +++--- hw/xfree86/d

[PATCH xserver 0/7] modesetting - more stable MST hotpluging

the server down. - We have to compare the PATH if available, as the output_id is unreliable. - We have to make sure, we don't throw zero outputs to configure into drmModeSetCrtc() as this will fail and tear down the server. Thanks, Daniel Daniel Martin (7): modesetting: Check for uevents

[PATCH xserver 4/6] modesetting: Retrieve drm connector in drmmode_output_detect()

So, we don't rely on the mode_output member. Signed-off-by: Daniel Martin <consume.no...@gmail.com> --- hw/xfree86/drivers/modesetting/drmmode_display.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/xfree86/drivers/modesetting/drmmode_display.c b/hw/x

[PATCH xserver 3/6] modesetting: Retrieve drm connector in drmmode_output_create_resources()

So, we don't rely on the mode_output member. Signed-off-by: Daniel Martin <consume.no...@gmail.com> --- hw/xfree86/drivers/modesetting/drmmode_display.c | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/hw/xfree86/drivers/modesetting/drmmode_displa

[PATCH xserver 6/6] modesetting: Get current connector infos in drmmode_output_init()

No need for modes and connector status probing here. Signed-off-by: Daniel Martin <consume.no...@gmail.com> --- hw/xfree86/drivers/modesetting/drmmode_display.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/hw/xfree86/drivers/modesetting/drmmode_display.c

[PATCH xserver 5/6] modesetting: Remove mode_output member from drmmode_output

We failed to handle the mode_output member properly a few times. We can retrieve it at any time, which we do at various places anyway. Remove it. Signed-off-by: Daniel Martin <consume.no...@gmail.com> --- hw/xfree86/drivers/modesetting/drmmode_display.c | 21 - hw/x

[PATCH xserver 1/6] modesetting: Save number of encoders in drmmode_output

So, we don't rely on the mode_output member. Signed-off-by: Daniel Martin <consume.no...@gmail.com> --- hw/xfree86/drivers/modesetting/drmmode_display.c | 13 +++-- hw/xfree86/drivers/modesetting/drmmode_display.h | 1 + 2 files changed, 8 insertions(+), 6 deletions(-) diff --gi

[PATCH xserver 0/6] modesetting - remove mode_output member

This patchset removes the mode_output member. We failed to handle it correctly in the past and most people won't notice if the do as it requires MST hotpluging. Thanks, Daniel Daniel Martin (6): modesetting: Save number of encoders in drmmode_output modesetting: Retrieve drm connector

[PATCH xserver 0/6] xdmcp, xfree86, modesetting - fixes and cleanups

- "Failed" without a new-line is not a good log message modesetting: Reset output_id if drmModeGetConnector failed - mode_output strikes again modesetting: Remove unused define DRV_ERROR modesetting: Remove #if 0 CMAP_LOAD_EVEN_IF_OFFSCREEN Thanks, Daniel Daniel Martin

[PATCH xserver 3/6] modesetting: Fix log msg if pixmap creation failed

Add a missing new-line character and make the message more verbose than "Failed". Signed-off-by: Daniel Martin <consume.no...@gmail.com> --- hw/xfree86/drivers/modesetting/drmmode_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/xfree86/dri

[PATCH xserver 1/6] os/xdmcp: Honour -once when session is dead

Terminate a dead session when -once was passed. Don't restart it. Signed-off-by: Daniel Martin <consume.no...@gmail.com> Reviewed-by: Walter Harms <wha...@bfs.de> --- os/xdmcp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/os/xdmcp.c b/os/xdmcp.c index 906c9594

[PATCH xserver 2/6] xfree86: Fix set but not used warnings in lnx_platform

appear. Suggested by Emil Velikov Reviewed-by: Emil Velikov <emil.veli...@collabora.com> Signed-off-by: Daniel Martin <consume.no...@gmail.com> --- hw/xfree86/os-support/linux/lnx_platform.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/hw/xfree86/os-s

[PATCH xserver 5/6] modesetting: Remove unused define DRV_ERROR

Signed-off-by: Daniel Martin <consume.no...@gmail.com> --- hw/xfree86/drivers/modesetting/driver.h | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/xfree86/drivers/modesetting/driver.h b/hw/xfree86/drivers/modesetting/driver.h index 7ea500f5c..08dc3b58a 100644 --- a/hw/xfree86/d

[PATCH xserver 4/6] modesetting: Reset output_id if drmModeGetConnector failed

If drmModeGetConnector() fails in drmmode_output_detect(), we have to reset the output_id to -1 too. Yet another spot leading to a potential NULL dereference when handling the mode_output member as output_id was != -1. Though, this case should be very hard to hit. Signed-off-by: Daniel Martin

[PATCH xserver 6/6] modesetting: Remove #if 0 CMAP_LOAD_EVEN_IF_OFFSCREEN

CMAP_LOAD_EVEN_IF_OFFSCREEN has been encapsulated since the import of xf86-video-modesetting into the tree. Signed-off-by: Daniel Martin <consume.no...@gmail.com> --- hw/xfree86/drivers/modesetting/drmmode_display.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --gi

Re: [PATCH xserver 00/11] modesetting: Fixes, cleanups and mode_output removal

(Sorry, for not reporting back earlier, had to do internal stuff.) Please ignore this pathset. It's superseded by distinct patchsets I'm going to send. Cheers, Daniel ___ xorg-devel@lists.x.org: X.Org development Archives:

Re: [PATCH xserver 03/11] modesetting: Simplify mst path blob parsing

On 7 November 2017 at 14:06, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 7 November 2017 at 09:38, Daniel Martin <consume.no...@gmail.com> wrote: >> The kernel guarantees that the MST path property blob of a connector >> has a certain format and this pr

Re: [PATCH xserver 01/11] xfree86: Fix set but not used warnings in lnx_platform

On 7 November 2017 at 13:57, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 7 November 2017 at 09:38, Daniel Martin <consume.no...@gmail.com> wrote: >> ../hw/xfree86/os-support/linux/lnx_platform.c: In function ‘get_drm_info’: >> ../hw/xfree86/os-support/linux/ln

[PATCH xserver 10/11] modesetting: Remove mode_output member from drmmode_output

We failed to handle the mode_output member properly a few times. We can retrieve it at any time, which we do at various places anyway. Remove it. Signed-off-by: Daniel Martin <consume.no...@gmail.com> --- hw/xfree86/drivers/modesetting/drmmode_display.c | 21 - hw/x

[PATCH xserver 11/11] modesetting: Get current connector infos in drmmode_output_init()

No need for modes and connector status probing here. Signed-off-by: Daniel Martin <consume.no...@gmail.com> --- hw/xfree86/drivers/modesetting/drmmode_display.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/hw/xfree86/drivers/modesetting/drmmode_display.c

[PATCH xserver 08/11] modesetting: Retrieve drm connector in drmmode_output_create_resources()

So, we don't rely on the mode_output member. Signed-off-by: Daniel Martin <consume.no...@gmail.com> --- hw/xfree86/drivers/modesetting/drmmode_display.c | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/hw/xfree86/drivers/modesetting/drmmode_displa

[PATCH xserver 07/11] modesetting: Retrieve drm connector in drmmode_output_get_modes()

So, we don't rely on the mode_output member. Signed-off-by: Daniel Martin <consume.no...@gmail.com> --- hw/xfree86/drivers/modesetting/drmmode_display.c | 28 +++- 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/hw/xfree86/drivers/modesetting/drmmode_dis

[PATCH xserver 00/11] modesetting: Fixes, cleanups and mode_output removal

, Daniel Martin ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel

[PATCH xserver 09/11] modesetting: Retrieve drm connector in drmmode_output_detect()

So, we don't rely on the mode_output member. Signed-off-by: Daniel Martin <consume.no...@gmail.com> --- hw/xfree86/drivers/modesetting/drmmode_display.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/xfree86/drivers/modesetting/drmmode_display.c b/hw/x

[PATCH xserver 03/11] modesetting: Simplify mst path blob parsing

creation function.) Signed-off-by: Daniel Martin <consume.no...@gmail.com> --- hw/xfree86/drivers/modesetting/drmmode_display.c | 41 +--- 1 file changed, 15 insertions(+), 26 deletions(-) diff --git a/hw/xfree86/drivers/modesetting/drmmode_display.c b/hw/xfree86/d

[PATCH xserver 01/11] xfree86: Fix set but not used warnings in lnx_platform

:9: warning: variable ‘major’ set but not used [-Wunused-but-set-variable] int major, minor, fd; ^ Signed-off-by: Daniel Martin <consume.no...@gmail.com> --- hw/xfree86/os-support/linux/lnx_platform.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --gi

[PATCH xserver 02/11] modesetting: Fix log msg if pixmap creation failed

Add a missing new-line character and make the message more verbose than "Failed". Signed-off-by: Daniel Martin <consume.no...@gmail.com> --- hw/xfree86/drivers/modesetting/drmmode_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/xfree86/dri

[PATCH xserver 05/11] modesetting: Reset output_id if drmModeGetConnector failed

If drmModeGetConnector() fails in drmmode_output_detect(), we have to reset the output_id to -1 too. Yet another spot leading to a potential NULL dereference when handling the mode_output member as output_id was != -1. Though, this case should be very hard to hit. Signed-off-by: Daniel Martin

[PATCH xserver 04/11] modesetting: Simplify output name creation

Looks much better without gotos. Signed-off-by: Daniel Martin <consume.no...@gmail.com> --- hw/xfree86/drivers/modesetting/drmmode_display.c | 75 +++- 1 file changed, 34 insertions(+), 41 deletions(-) diff --git a/hw/xfree86/drivers/modesetting/drmmode_display.c

[PATCH xserver 06/11] modesetting: Save number of encoders in drmmode_output

So, we don't rely on the mode_output member. Signed-off-by: Daniel Martin <consume.no...@gmail.com> --- hw/xfree86/drivers/modesetting/drmmode_display.c | 13 +++-- hw/xfree86/drivers/modesetting/drmmode_display.h | 1 + 2 files changed, 8 insertions(+), 6 deletions(-) diff --gi

Re: [PATCH libXau 0/3] remove redundant null check on calling free()

Am 28.10.2017 19:16 schrieb "walter harms" <wha...@bfs.de>: After the last patch for libXau i checked the code with smatch and started to remove remove redundant One redundant "remove" here. ;-) All 3 patches are Reviewed-by: Daniel Marti

[PATCH xserver 1/4] modesetting: Fix potential buffer overflow

If one misconfigures a ZaphodHeads value (more than 20 characters without a delimiter), we get an overflow of our buffer. Use xstrtokenize() instead of writing/fixing our own tokenizer. Signed-off-by: Daniel Martin <consume.no...@gmail.com> --- hw/xfree86/drivers/modesetting/drmmode_dis

[PATCH xserver 4/4] Use ARRAY_SIZE all over the tree

Roundhouse kick replacing the various (sizeof(foo)/sizeof(foo[0])) with the ARRAY_SIZE macro from dix.h when possible. A semantic patch for coccinelle has been used first. Additionally, few macros have been inlined as they had only one or two users. Signed-off-by: Daniel Martin <consume

[PATCH xserver 3/4] test: signal-logging: Fix looping signed number tests

unsigned_tests[] was used to compute the amount of signed numbers to test. Signed-off-by: Daniel Martin <consume.no...@gmail.com> --- test/signal-logging.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/signal-logging.c b/test/signal-logging.c index 9bf39e58d..ca3

[PATCH xserver 2/4] test: input: Fix used uninitialized warning in dix_event_to_core

^~ Signed-off-by: Daniel Martin <consume.no...@gmail.com> --- test/input.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/input.c b/test/input.c index 4cd39bb48..8638f1443 100644 --- a/test/input.c +++ b/test/input.c @@ -230,7 +230,7 @@ dix_check_grab_val

[PATCH xserver 2/2] modesetting: Use helper to fetch drmModeProperty(Blob)s

Replace the various loops to lookup drmModeProperty(Blob)s by introducing helper functions. Signed-off-by: Daniel Martin <consume.no...@gmail.com> --- hw/xfree86/drivers/modesetting/drmmode_display.c | 163 +++ 1 file changed, 77 insertions(+), 86 deletions(-) diff

[PATCH xserver 1/2] modesetting: Fix leak of tile_blob in drmmode_output_destroy

And drmModeFreePropertyBlob() can handle NULL pointers, no need to check edid_blob. Signed-off-by: Daniel Martin <consume.no...@gmail.com> --- hw/xfree86/drivers/modesetting/drmmode_display.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/xfree86/drivers/modes

Re: [RFC xserver v4 07/14] modesetting: Use atomic modesetting to configure output/CRTCs

On 16 October 2017 at 07:02, Louis-Francis Ratté-Boulianne wrote: > To make sure we also use the same primary plane and to avoid > mixing uses of two APIs, it is better to always use the atomic > modesetting API when possible. > > Signed-off-by: Louis-Francis Ratté-Boulianne

[PATCH xserver 1/3] modesetting: Fix warning of unused variable if not GLAMOR_HAS_GBM

, where it is used. Signed-off-by: Daniel Martin <consume.no...@gmail.com> --- hw/xfree86/drivers/modesetting/driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/xfree86/drivers/modesetting/driver.c b/hw/xfree86/drivers/modesetting/driver.c index 9afb344c8..91d850427

[PATCH xserver 3/3] modesetting: Check crtc before searching link-status property

No need to lookup the link-status property if we don't have a crtc. Signed-off-by: Daniel Martin <consume.no...@gmail.com> --- hw/xfree86/drivers/modesetting/drmmode_display.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/hw/xfree86/drivers/modes

[PATCH xserver 2/3] modesetting: Remove #ifdefs XF86_PDEV_SERVER_FD

r from the external xf86-video-modesetting. Signed-off-by: Daniel Martin <consume.no...@gmail.com> --- hw/xfree86/drivers/modesetting/driver.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/hw/xfree86/drivers/modesetting/driver.c b/hw/xfree86/drivers/modesetting/driver.c ind

Re: [PATCH] modesetting: handle NULL cursor in drmmode_set_cursor.

reliable and can confirm that this patch fixes the issue. Reviewed-and-Tested-by: Daniel Martin <consume.no...@gmail.com> > Signed-off-by: Dave Airlie <airl...@redhat.com> > --- > hw/xfree86/drivers/modesetting/drmmode_display.c | 3 +++ > 1 file changed, 3 insertions(+)

Re: (timeout in ms vs. XSyncValueSubtract) Frozen client, found cause, need advise for fix

Am 22.02.2017 11:24 schrieb "Daniel Martin" <consume.no...@gmail.com>: On 21 February 2017 at 17:48, walter harms <wha...@bfs.de> wrote: > Am 20.02.2017 10:55, schrieb Daniel Martin: >> What happens is: >> - ServertimeBlockHandler() forwards a _big_ unsi

Re: (timeout in ms vs. XSyncValueSubtract) Frozen client, found cause, need advise for fix

On 21 February 2017 at 17:48, walter harms <wha...@bfs.de> wrote: > Am 20.02.2017 10:55, schrieb Daniel Martin: >> What happens is: >> - ServertimeBlockHandler() forwards a _big_ unsigned timeout to >> AdjustWaitForDelay() >> - AdjustWaitForDelay() takes this _bi

(timeout in ms vs. XSyncValueSubtract) Frozen client, found cause, need advise for fix

for negatives in ospoll_wait() as the input thread calls it with -1. Other thoughts: Why does the cursor move, but neither the movement or clicks, nor pressing a modifier unlock the client? Cheers, Daniel Martin ___ xorg-devel@lists.x.org: X.Or

Re: how does X11 get EDID?

On 3 February 2017 at 01:17, Sanford Rockowitz wrote: > Can someone point me to where in the X11 code base the the monitor is > queried for the EDID? For the modesetting driver case, it happens in: hw/xfree86/drivers/modesetting/drmmode_display.c

Re: [PATCH xserver] os/xdmcp: Honour -once when session is dead

Imho this could be picked for 1.19. Anyone willing to give his Rb? On 30 September 2016 at 14:05, Daniel Martin <consume.no...@gmail.com> wrote: > Terminate a dead session when -once was passed. Don't restart it. > > Signed-off-by: Daniel Martin <consume.no...@gmail.com> &g

[PATCH xserver] os/xdmcp: Honour -once when session is dead

Terminate a dead session when -once was passed. Don't restart it. Signed-off-by: Daniel Martin <consume.no...@gmail.com> --- os/xdmcp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/os/xdmcp.c b/os/xdmcp.c index 906c959..7aeb393 100644 --- a/os/xdmcp.c +++ b/os/x

Re: [PATCH v5 xserver 3/7] xf86Cursor: Add xf86CheckHWCursor() helper function

On 6 September 2016 at 14:48, Hans de Goede <hdego...@redhat.com> wrote: > HI, > > > On 06-09-16 14:35, Daniel Martin wrote: >> >> Sorry for jumping in that late ... >> >> On 6 September 2016 at 13:31, Hans de Goede <hdego...@redhat.com> wrot

Re: [PATCH v5 xserver 3/7] xf86Cursor: Add xf86CheckHWCursor() helper function

>MaxWidth && cursor->bits->height <= infoPtr->MaxHeight) { if (infoPtr->UseHWCursor) return infoPtr->UseHWCursor(pScreen, cursor) else return TRUE; } As my comment came late and is beautifying only, feel free to ignore it. Cheers, Daniel Martin ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH v3 xserver 4/4] modesetting: add DRI2 page flip support

s.x1 = region.extents.y1 = 0; > +region.extents.x2 = front_priv->pixmap->drawable.width; > +region.extents.y2 = front_priv->pixmap->drawable.width; this looks like a copy'n'paste mistake. > +region.data = NULL; > +DamageRegionAppend(_priv->

Re: [PATCH] modesetting: Add common widescreen resolutions

On 21 February 2016 at 12:08, Adel Gadllah wrote: > Stolen from the intel ddx driver, see: > https://cgit.freedesktop.org/xorg/driver/xf86-video-intel/commit/?id=26fd6bec > https://bugs.freedesktop.org/show_bug.cgi?id=37858 > > it makes those common modes selectable when

[PATCH xserver] modesetting: Consume all available udev events at once

From: Daniel Martin <consume.no...@gmail.com> We get multiple udev events for actions like docking a laptop into its station or plugging a monitor to the station. By consuming as much events as we can, we reduce the number of output re-evalutions. I.e. having a Lenovo X250 in a ThinkPad

Re: [PATCH xserver] xf86/cursor: Fix potential use of FreeCursor()ed cursor

On 21 September 2015 at 11:14, Daniel Martin <daniel.mar...@secunet.com> wrote: > We save CurrentCursor if we're going to remove it from the screen in > xf86CursorEnableDisableFBAccess(). But, we call xf86CursorSetCursor() > in between, which calls FreeCursor() on Curre

Re: [PATCH xserver] modesetting: Just inherit output states during PreInit

On 4 November 2015 at 11:26, Daniel Martin <daniel.mar...@secunet.com> wrote: > From: Daniel Martin <consume.no...@gmail.com> > > During PreInit, we just want to inherit the output states from the > kernel. If there's a connected output without an encoder assigned,

Re: [PATCH xserver] XDMCP: Fix format in XDMCP fatal error printing

On 10 November 2015 at 11:19, Egbert Eich wrote: > From: Egbert Eich > > XdmcpFatal() calls FatalError() with '%*.*s' in the format string. > FatalError() uses the async safe versions of printf() which only > support a subset of the POSIX printf formats - they

[PATCH xserver] modesetting: Just inherit output states during PreInit

From: Daniel Martin <consume.no...@gmail.com> During PreInit, we just want to inherit the output states from the kernel. If there's a connected output without an encoder assigned, there must be a reason for this. Don't try to activate it, treat it as disconnected for the moment. Because,

[PATCH xserver 1/4] modesetting: Handle failures in setting a CRTC to a DRM mode properly

From: Daniel Martin <consume.no...@gmail.com> This fixes a bug where running the card out of PPLL's when hotplugging another monitor would result in all of the displays going blank and failing to work properly until X was restarted or the user switched to another VT. [Michel Dänzer: Pass

[RFC xserver 4/4] modesetting: Treat inactive outputs as disconnected during PreInit

From: Daniel Martin <consume.no...@gmail.com> If we fail to activate an output while we're in PreInit, the server won't startup. This might happen if we run out of lanes. Don't try to activate any output during PreInit, which the kernel didn't set up yet by treating them as disconnected.

[PATCH xserver 2/4] modesetting: Free output_ids in drmmode_set_mode_major()

From: Daniel Martin <consume.no...@gmail.com> We calloc() output_ids. Let's free() it, too. Signed-off-by: Daniel Martin <consume.no...@gmail.com> --- hw/xfree86/drivers/modesetting/drmmode_display.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/xfr

[PATCH xserver 3/4] modesetting: Remove XF86_CRTC_VERSION checks

From: Daniel Martin <consume.no...@gmail.com> The ifdef checks for XF86_CRTC_VERSION >= 3/5 are remnants from the out-of-tree driver. Within the tree, we can rely on: xf86Crtc.h:#define XF86_CRTC_VERSION 6 Signed-off-by: Daniel Martin <consume.no...@gmail.com> --- hw/

Re: [PATCH v2] Handle failures in setting a CRTC to a DRM mode properly

On 26 October 2015 at 10:39, Michel Dänzer wrote: >> diff --git a/src/drmmode_display.c b/src/drmmode_display.c >> index 64e79d4..f0f121e 100644 >> --- a/src/drmmode_display.c >> +++ b/src/drmmode_display.c >> @@ -760,12 +760,15 @@ drmmode_set_mode_major(xf86CrtcPtr crtc, >>

Re: [PATCH xserver 15/24] kdrive/ephyr: Use NotifyFd for XCB connection input

On 21 September 2015 at 08:16, Keith Packard wrote: > Eliminates polling every 20ms for device input. > > Signed-off-by: Keith Packard > --- > hw/kdrive/ephyr/ephyr.c | 10 +- > hw/kdrive/ephyr/ephyr.h | 3 --- > hw/kdrive/ephyr/hostx.c | 6 ++

Re: [PATCH xserver 10/24] dix: Switch to the libXfont2 API (v2)

On 21 September 2015 at 08:16, Keith Packard wrote: > This new libXfont API eliminates exposing internal X server symbols to > the font library, replacing those with a struct full of the entire API > needed to use that library. > > v2: Use libXfont2 instead of libXfont_2 > >

Re: [PATCH xserver 04/24] Remove non-smart scheduler. Don't require setitimer.

On 21 September 2015 at 08:16, Keith Packard wrote: > This allows the server to call GetTimeInMillis() after each request is > processed to avoid needing setitimer. -dumbSched now turns off the > setitimer. > > Signed-off-by: Keith Packard > --- >

[PATCH xserver] xf86/cursor: Fix potential use of FreeCursor()ed cursor

ScreenPriv->CurrentCursor = NullCursor; return } } Signed-off-by: Daniel Martin <consume.no...@gmail.com> --- hw/xfree86/ramdac/xf86Cursor.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/xfree86/ramdac/xf86Cursor.c b/hw/xfree86/ramdac/xf8

Re: [PATCH] ephyr: Avoid a segfault with 'DISPLAY= Xephy -glamor'

On 9 February 2015 at 15:09, Jon TURNEY jon.tur...@dronecode.org.uk wrote: On 09/02/2015 14:03, Daniel Martin wrote: On 9 February 2015 at 14:45, Jon TURNEY jon.tur...@dronecode.org.uk wrote: ephyr_glamor_connect() returns NULL if we failed, but applying xcb_connection_has_error() to NULL

Re: [PATCH] ephyr: Avoid a segfault with 'DISPLAY= Xephy -glamor'

On 9 February 2015 at 14:45, Jon TURNEY jon.tur...@dronecode.org.uk wrote: ephyr_glamor_connect() returns NULL if we failed, but applying xcb_connection_has_error() to NULL is not permitted. Signed-off-by: Jon TURNEY jon.tur...@dronecode.org.uk --- hw/kdrive/ephyr/hostx.c | 2 +- 1 file

Re: [PATCH 2/2] modesetting: add dynamic connector hotplug support (MST)

On 28 January 2015 at 09:32, Daniel Martin consume.no...@gmail.com wrote: On 28 January 2015 at 08:40, Dave Airlie airl...@gmail.com wrote: From: Dave Airlie airl...@redhat.com This is ported from the same code in the ati and intel drivers, It uses the same option name as nvidia

Re: [PATCH 2/2] modesetting: add dynamic connector hotplug support (MST)

On 28 January 2015 at 08:40, Dave Airlie airl...@gmail.com wrote: From: Dave Airlie airl...@redhat.com This is ported from the same code in the ati and intel drivers, It uses the same option name as nvidia and the other DDXes to disable tearing down outputs as it is hard to avoid racing with

Re: [PATCH] Fix a crash with XDMCP error handler

On 25 January 2015 at 20:22, Colin Harrison colin.harri...@virgin.net wrote: Hi, I much prefer Jon Turney's more universal fix to this problem. http://lists.x.org/archives/xorg-devel/2014-November/044568.html and having tested Jon's fix it can have Reviewed-by: Colin Harrison

Re: [PATCH 8/8] modesetting: Add output hotplug support

On 9 December 2014 at 08:14, Aaron Plattner aplatt...@nvidia.com wrote: On 12/08/2014 01:01 AM, Daniel Martin wrote: On 5 December 2014 at 17:45, Keith Packard kei...@keithp.com wrote: Daniel Martin daniel.mar...@secunet.com writes: From: Daniel Martin consume.no...@gmail.com When

Re: [PATCH 8/8] modesetting: Add output hotplug support

On 5 December 2014 at 17:45, Keith Packard kei...@keithp.com wrote: Daniel Martin daniel.mar...@secunet.com writes: From: Daniel Martin consume.no...@gmail.com When receiving a hotplug uevent, check if we have to add or remove outputs and act accordingly. Signed-off-by: Daniel Martin

[PATCH 2/9] modesetting: Move Bool glamor into drmmode struct

From: Daniel Martin consume.no...@gmail.com Move the boolean glamor from struct modesetting into struct drmmode for later re-use in drmmode_display. Signed-off-by: Daniel Martin consume.no...@gmail.com Reviewed-by: Eric Anholt e...@anholt.net Reviewed-and-tested-by: Kenneth Graunke kenn

[PATCH v2 8/9] modesetting: Add output hotplug support

From: Daniel Martin consume.no...@gmail.com When receiving a hotplug uevent, check if we have to add or remove outputs. v2: Move log message in drmmode_output_add() below 'if (!output)' to prevent possible NULL dereference. Signed-off-by: Daniel Martin consume.no...@gmail.com Reviewed

[PATCH v2 6/9] modesetting: Only handle hotplug uevent when vtSema

From: Daniel Martin consume.no...@gmail.com If the uevent isn't a hotplug event, ignore it, and if !vtSema postpone the reprobing until EnterVT(). v2: Replace 'flags' member and enum with Bool 'need_reprobe'. Signed-off-by: Daniel Martin consume.no...@gmail.com --- hw/xfree86/drivers

[v2] Modesetting - crash, boom, bang

: [PATCH 9/9] modesetting: XXX - Only track connected outputs A small patch to be able to test the functionality on HW that doesn't hotplug outputs. Tested with an old ThinkPad T400. Cheers, Daniel Martin ___ xorg-devel@lists.x.org: X.Org

[PATCH 3/9] modesetting: Create new EGL screen in drmmode_xf86crtc_resize

From: Daniel Martin consume.no...@gmail.com If we don't glamor_egl_create_textured_screen_ext() in drmmode_xf86crtc_resize() we end up with a black screen and no client windows visible. Signed-off-by: Daniel Martin consume.no...@gmail.com Reviewed-by: Eric Anholt e...@anholt.net Reviewed

[PATCH 1/9] config/udev: Prefix and shift removing GPU message

From: Daniel Martin consume.no...@gmail.com The message removing GPU device ... appeared even if the removal was skipped (when path == NULL). Move it below the path check and make it a LogMessage with config/udev prefix. Signed-off-by: Daniel Martin consume.no...@gmail.com Reviewed-by: Eric

[PATCH 4/9] modesetting: Fix ifdefs s/HAVE_UDEV/CONFIG_UDEV_KMS/

From: Daniel Martin consume.no...@gmail.com We don't define HAVE_UDEV, that's a remnant from xf86-video-modesetting. But, we have CONFIG_UDEV_KMS. Signed-off-by: Daniel Martin consume.no...@gmail.com Reviewed-by: Eric Anholt e...@anholt.net Reviewed-and-tested-by: Kenneth Graunke kenn

[PATCH 5/9] modesetting: Remove unused params from drmmode_output_init()

From: Daniel Martin consume.no...@gmail.com drmmode_output_init() doesn't touch (the int*) num_dvi and num_hdmi. Remove both parameters. Signed-off-by: Daniel Martin consume.no...@gmail.com Reviewed-by: Eric Anholt e...@anholt.net Reviewed-and-tested-by: Kenneth Graunke kenn...@whitecape.org

[PATCH 9/9] modesetting: XXX - Only track connected outputs

This patch is not meant to be merged. Its purpose is to be able to test the output hotplug handling on maschines that don't hotplug outputs. With this patch an output will be added or removed depending on its connector state (connected? - add, otherwise - remove or ignore). ---

[PATCH 7/9] modesetting: Return the output created in drmmode_output_init()

From: Daniel Martin consume.no...@gmail.com So, we can re-use the function for output hotplugging later. Signed-off-by: Daniel Martin consume.no...@gmail.com Reviewed-by: Keith Packard kei...@keithp.com --- hw/xfree86/drivers/modesetting/drmmode_display.c | 9 + 1 file changed, 5

Re: Modesetting - crash, boom, bang

On Sun, Nov 30, 2014 at 12:52:24PM -0800, Eric Anholt wrote: Daniel Martin daniel.mar...@secunet.com writes: I've tested the modesetting driver in 1.16.99.901 and found 2 bugs that leave you with a black screen or even crash the server. The attached patches fix both problems, but due to my

  1   2   >