[PATCH app/sessreg] Use off_t instead of long to make largefile support work

2016-05-29 Thread Egbert Eich
From: Egbert Eich <e...@suse.de> We already use the AC_SYS_LARGEFILE in configure.ac. This macro will only work properly if the correct tyles are used: relace long by off_t when calculating file offsets. Signed-off-by: Egbert Eich <e...@suse.de> Found-by: Herbert Kütz --- s

[PATCH xserver] Panning: Set panning state in xf86RandR12ScreenSetSize()

2016-01-15 Thread Egbert Eich
-by: Egbert Eich <e...@freedesktop.org> --- hw/xfree86/modes/xf86RandR12.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/xfree86/modes/xf86RandR12.c b/hw/xfree86/modes/xf86RandR12.c index eae7016..0c807bc 100644 --- a/hw/xfree86/modes/xf86RandR12.c +++ b/hw/xfree86/modes/xf86Ran

[PATCH xserver] busfault_sigaction: Only initialize pointer when matched

2016-01-11 Thread Egbert Eich
When looping over the registered map ranges, don't use the variable holding the final result as loop variable - It would always be initialized, on an empty list or when we run past the end of the list when no entry was found. Signed-off-by: Egbert Eich <e...@freedesktop.org> --- os/busf

[PATCH xserver] kdrive/UnregisterFd: Fix off by one

2015-11-24 Thread Egbert Eich
From: Egbert Eich <e...@suse.de> The number of FDs has been decremented already, therefore the number contained the index of the top one that is to me moved down. This problem was introduced by: commit 1110b71e360195aab040d835b54540ab558638c5 Author: Chris Clayton <chris2...@googl

[PATCH xserver] XDMCP: Fix format in XDMCP fatal error printing

2015-11-10 Thread Egbert Eich
From: Egbert Eich <e...@suse.de> XdmcpFatal() calls FatalError() with '%*.*s' in the format string. FatalError() uses the async safe versions of printf() which only support a subset of the POSIX printf formats - they don't contain the '*' width and precision specifiers. Bugzilla:

[PATCH app/xdm] dm: Don't crash if argc == 0

2015-05-27 Thread Egbert Eich
From: Egbert Eich e...@suse.de It is not guaranteed that argc 0. So make sure we don't crash if no valid command line arguments are given. Signed-off-by: Egbert Eich e...@suse.de --- xdm/dm.c | 47 +++ 1 file changed, 27 insertions(+), 20 deletions

[PATCH app/xdm] Fix notorious execution scenario for xdm

2015-05-27 Thread Egbert Eich
I ran across a notorious scenario where xdm was executed with argc was 0. This caused xdm to segfault. While this scenario was most likely invalid, it unveiled a rather minor issue in xdm's arument handling. So here is a fix. Egbert Eich (1): dm: Don't crash if argc == 0 xdm/dm.c | 47

[PATCH] RandR: Remove sensless checks for xf86RandR12Key

2015-03-31 Thread Egbert Eich
When xf86RandR12Key is not set we will not get to the places where these tests are done as the functions in question are not called. In most cases we would have crashed before these checks anyway. Signed-off-by: Egbert Eich e...@freedesktop.org --- hw/xfree86/modes/xf86RandR12.c | 13

[PATCH 4/5] Xephyr: Fix screen image draw for the non-Glamor non-XHSM case

2015-03-31 Thread Egbert Eich
xcb_image_put() prints the entire image, therefore don't use an offset. Signed-off-by: Egbert Eich e...@freedesktop.org --- hw/kdrive/ephyr/hostx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/kdrive/ephyr/hostx.c b/hw/kdrive/ephyr/hostx.c index bdffba9..99b7716 100644

[PATCH 3/5] Xephyr: Fix compile when debugging is enabled

2015-03-31 Thread Egbert Eich
Signed-off-by: Egbert Eich e...@freedesktop.org --- hw/kdrive/ephyr/hostx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/kdrive/ephyr/hostx.c b/hw/kdrive/ephyr/hostx.c index a516c20..bdffba9 100644 --- a/hw/kdrive/ephyr/hostx.c +++ b/hw/kdrive/ephyr/hostx.c @@ -798,7

[PATCH 0/5] Xephyr: Numerous issues

2015-03-31 Thread Egbert Eich
These are fixes for issues I ran into when looking into an issue with Xephyr on IBM z-Series. Actually only the last one is related to be-le. The others however were unveiled by this special use case. Egbert Eich (5): Xephyr: Don't crash when no command line argument is specified Xephyr

[PATCH 5/5] Xephyr: Fix broken image when endianess of client machine and host-Xserver differ

2015-03-31 Thread Egbert Eich
this is already taken care of by the depth conversion routine. It is a terrible wase to always convert and transmit the entire image no matter of the size of the damaged area. One should probably use sub-images here. For now we leave this as an exercise. Signed-off-by: Egbert Eich e...@freedesktop.org --- hw

[PATCH 2/5] Xephyr: Print default server display number if none is specified

2015-03-31 Thread Egbert Eich
Signed-off-by: Egbert Eich e...@freedesktop.org --- hw/kdrive/ephyr/hostx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/kdrive/ephyr/hostx.c b/hw/kdrive/ephyr/hostx.c index c67ff60..a516c20 100644 --- a/hw/kdrive/ephyr/hostx.c +++ b/hw/kdrive/ephyr/hostx.c @@ -177,7

[PATCH 1/5] Xephyr: Don't crash when no command line argument is specified

2015-03-31 Thread Egbert Eich
From: Egbert Eich e...@suse.de The DDX specific command line parsing function only gets called if command line arguments are present. Therefore this function is not suitable to initialize mandatory global variables. Replace main() instead. Signed-off-by: Egbert Eich e...@freedesktop.org

Re: [PATCH] sdksyms.sh: Make sdksyms.sh work with gcc5.

2015-03-03 Thread Egbert Eich
Hans asked for other suggestions to fix the gcc5 breakage of sdksyms.sh. So here is my take on it. Egbert Eich (1): symbols: Fix sdksyms.sh to cope with gcc5 hw/xfree86/sdksyms.sh | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) -- 1.8.4.5

[PATCH] symbols: Fix sdksyms.sh to cope with gcc5

2015-03-03 Thread Egbert Eich
Gcc5 adds additional lines stating line numbers before and after __attribute__() which need to be skipped. Signed-off-by: Egbert Eich e...@freedesktop.org --- hw/xfree86/sdksyms.sh | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/hw/xfree86/sdksyms.sh b/hw

Nomination Period for the X.Org Foundation BoD Election ENDS

2015-02-12 Thread Egbert Eich
Just as a reminder, the nomination period for the X.Org Foundation Board of Directors election ends on Monday, Feb 16 2015, 23:59 UTC (12:59 PM UTC). If you would like to nominate yourself, please send email to electi...@x.org. Please note that to be a candidate in this election your have to

2015 Elections to the X.Org Board of Directors and Approval to Changes of the X.Org By Laws

2015-01-26 Thread Egbert Eich
The X.Org Foundation is holding elections for - The Board of Directors - Adoption of changes to the By Laws. Election Schedule = QA Session for the By Law changes start:Jan 26 Nomination period Start: Jan 26 00:00 UTC Nomination period End: Feb 15 23:59 UTC

Re: [PATCH driver/intel] Allow copy_front() to fail and clean up gracefully if it does

2014-09-26 Thread Egbert Eich
or this Pixmap. Reported-by: Egbert Eich e...@suse.com Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk catches all the cases where we need to check the alignment on the pitch before changing the cache level. If not, it now explicitly converts the bo before making

Re: [PATCH driver/intel] Allow copy_front() to fail and clean up gracefully if it does

2014-09-25 Thread Egbert Eich
Chris Wilson writes: On Wed, Sep 24, 2014 at 01:23:26PM +0200, Egbert Eich wrote: Chris Wilson writes: On Wed, Sep 24, 2014 at 12:34:29PM +0200, Egbert Eich wrote: For panning one needs to be able to draw into the screen pixmap outside of the area exposed

[PATCH driver/intel] Allow copy_front() to fail and clean up gracefully if it does

2014-09-24 Thread Egbert Eich
From: Egbert Eich e...@suse.de copy_front() calls sna_pixmap_force_to_gpu() which may fail. If we pretend to have been successful and continue the caller sna_mode_resize() may finish successfully pretending a mode change has succeeded which might leave a mode behind which is unusable. This patch

[PATCH driver/intel] In sna_pixmap_alloc_gpu() process user selected tiling thru kgem_choose_tiling()

2014-09-24 Thread Egbert Eich
From: Egbert Eich e...@suse.de In sna_pixmap_alloc_gpu() a different than the default tiling may be picked by a usage hint. Before passing the tiling to kgem_create_2d() fix it up by calling kgem_choose_tiling(). This avoids kgem_surface_size() not being able to find a surface size for the tiling

Re: [PATCH driver/intel] Allow copy_front() to fail and clean up gracefully if it does

2014-09-24 Thread Egbert Eich
Chris Wilson writes: On Wed, Sep 24, 2014 at 08:17:59AM +0200, Egbert Eich wrote: From: Egbert Eich e...@suse.de copy_front() calls sna_pixmap_force_to_gpu() which may fail. If we pretend to have been successful and continue the caller sna_mode_resize() may finish

Re: [PATCH driver/intel] Allow copy_front() to fail and clean up gracefully if it does

2014-09-24 Thread Egbert Eich
Chris Wilson writes: On Wed, Sep 24, 2014 at 12:34:29PM +0200, Egbert Eich wrote: For panning one needs to be able to draw into the screen pixmap outside of the area exposed by the crtc. Note that the screen pixmap still exists and is drawn into by the clients. What should

Re: [PATCH driver/intel] Allow copy_front() to fail and clean up gracefully if it does

2014-09-24 Thread Egbert Eich
Chris Wilson writes: On Wed, Sep 24, 2014 at 01:23:26PM +0200, Egbert Eich wrote: Chris Wilson writes: On Wed, Sep 24, 2014 at 12:34:29PM +0200, Egbert Eich wrote: For panning one needs to be able to draw into the screen pixmap outside of the area exposed

[PATCH] BellProc: Send bell event on core protocol bell when requested

2014-08-04 Thread Egbert Eich
. This patch ensures that an XKB bell event is sent also when the core protocol bell is rung end thus an appropriate action can be taken by a client. Signed-off-by: Egbert Eich e...@freedesktop.org --- dix/devices.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dix/devices.c

Re: Xorg copyright infrigement

2014-04-28 Thread Egbert Eich
On Sun, Apr 27, 2014 at 12:28:46PM +0200, Mateusz Jończyk wrote: The xls however, felt as if it was meant as a reference implementation, aimed at improving the proliferation of CVT. If graham does get contacted, i think he would agree. I don't have any doubts that the Authors of the

[PATCH driver/ast 00/15] Set of cleanup patches

2014-04-24 Thread Egbert Eich
conflicts with symbols from the Xserver or other drivers or modules. - fixed ABI compatibility issues with older Xservers - moved the firmware for the DP501 from ast_vgatool.c to a separate file. This made ast_vgatool.c much easier to handle. Egbert Eich (15): Fix compiler warnings: get rid

[PATCH driver/ast 05/15] Clean up namespace in ast_vgatools.c

2014-04-24 Thread Egbert Eich
From: Egbert Eich e...@suse.de - Make local functions static This sometimes helps the compiler to optimize. - Make sure exported functions have 'AST' in their name. This avoids name space conflicts with the server or other drivers. - Place declaration of exported functions in a header file

[PATCH driver/ast 00/15] Set of cleanup patches

2014-04-24 Thread Egbert Eich
easier to handle. Egbert Eich (15): Fix compiler warnings: get rid if xf86PciInfo.h Fix compiler warnings: get rid of deprecated IOADDRESS Fix compiler warnings: add DrawablePtr argument to ASTPutImage Remove upused functions

[PATCH driver/ast 09/15] Clean up namespace in ast_accel.c

2014-04-24 Thread Egbert Eich
From: Egbert Eich e...@suse.de - Made sure exported functions have 'AST' in their name. This avoids name space conflicts with the server or other drivers. - Placed declaration of exported functions in a header file. This ensures that changes to the function type or arguments are followed

[PATCH driver/ast 08/15] Clean up namespace in ast_mode.c

2014-04-24 Thread Egbert Eich
From: Egbert Eich e...@suse.de - Make local functions static This sometimes helps the compiler to optimize. - Made sure exported functions have 'AST' in their name. This avoids name space conflicts with the server or other drivers. - Placed declaration of exported functions in a header file

[PATCH driver/ast 12/15] Fix typo

2014-04-24 Thread Egbert Eich
From: Egbert Eich e...@suse.de Chontel - Chrontel Signed-off-by: Egbert Eich e...@suse.de --- src/ast_mode.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/ast_mode.c b/src/ast_mode.c index 59488c4..a52ee71 100644 --- a/src/ast_mode.c +++ b/src/ast_mode.c

[PATCH driver/ast 06/15] Clean up namespace in ast_2dtool.c

2014-04-24 Thread Egbert Eich
From: Egbert Eich e...@suse.de - Make local functions static This sometimes helps the compiler to optimize. - Make sure exported functions have 'AST' in their name. This avoids name space conflicts with the server or other drivers. - Place declaration of exported functions in a header file

[PATCH driver/ast 07/15] Clean up namespace in ast_cursor.c

2014-04-24 Thread Egbert Eich
From: Egbert Eich e...@suse.de - Make sure exported functions have 'AST' in their name. This avoids name space conflicts with the server or other drivers. - Place declaration of exported functions in a header file. This ensures that changes to the function type or arguments are followed

[PATCH driver/ast 11/15] Include local headers only when needed

2014-04-24 Thread Egbert Eich
From: Egbert Eich e...@suse.de Move inclusion of local headers from ast.h to the individual files. Include only those headers which are needed. Signed-off-by: Egbert Eich e...@suse.de --- src/ast.h | 5 - src/ast_2dtool.c | 2 ++ src/ast_accel.c | 1 + src/ast_cursor.c | 2

[PATCH driver/ast 01/15] Fix compiler warnings: get rid if xf86PciInfo.h

2014-04-24 Thread Egbert Eich
From: Egbert Eich e...@suse.de xf86PciInfo.h is not needed in the ASpeed driver at all. Signed-off-by: Egbert Eich e...@suse.de --- src/ast_2dtool.c | 1 - src/ast_accel.c | 1 - src/ast_cursor.c | 1 - src/ast_driver.c | 1 - src/ast_mode.c| 1 - src/ast_tool.c| 1 - src

[PATCH driver/ast 02/15] Fix compiler warnings: get rid of deprecated IOADDRESS

2014-04-24 Thread Egbert Eich
From: Egbert Eich e...@suse.de For newer ABI versions IOADDRESS can be replaced by int which is big enough to hold an PIO offset. Signed-off-by: Egbert Eich e...@suse.de --- src/ast.h| 6 -- src/ast_driver.c | 18 -- 2 files changed, 12 insertions(+), 12 deletions

[PATCH driver/ast 13/15] Fix ABI version conflict in xf86UnclaimPciSlot()

2014-04-24 Thread Egbert Eich
From: Egbert Eich e...@suse.de xf86UnclaimPciSlot() received a GDevPtr as 2nd argument with ABI_VIDEODRV_VERSION 13. Signed-off-by: Egbert Eich e...@suse.de --- src/ast_driver.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/ast_driver.c b/src/ast_driver.c index

Re: [PATCH] arch: Fix image and bitmap byte order for ppc64le

2014-02-25 Thread Egbert Eich
On Mon, Feb 24, 2014 at 11:18:27AM +0100, Mark Kettenis wrote: X-Original-To: xorg-devel@lists.x.org From: Egbert Eich e...@freedesktop.org Date: Mon, 24 Feb 2014 10:57:23 +0100 From: Dinar Valeev dval...@suse.com So far PPC was big endian for sure. For ppc64le this is no longer

[PATCH] arch: Fix image and bitmap byte order for ppc64le

2014-02-24 Thread Egbert Eich
From: Dinar Valeev dval...@suse.com So far PPC was big endian for sure. For ppc64le this is no longer true. Signed-off-by: Egbert Eich e...@freedesktop.org --- include/servermd.h | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/include/servermd.h b/include/servermd.h

[PATCH v2] arch: Fix image and bitmap byte order for ppc64le

2014-02-24 Thread Egbert Eich
From: Dinar Valeev dval...@suse.com So far PPC was big endian for sure. For ppc64le this is no longer true. Signed-off-by: Egbert Eich e...@freedesktop.org --- include/servermd.h | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/include/servermd.h b/include/servermd.h

[PATCH app/xev v2] Add event filter for button events

2014-02-12 Thread Egbert Eich
Signed-off-by: Egbert Eich e...@freedesktop.org --- man/xev.man | 2 +- xev.c | 5 - 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/man/xev.man b/man/xev.man index 4edec10..ba70463 100644 --- a/man/xev.man +++ b/man/xev.man @@ -62,7 +62,7 @@ The option can be specified

[PATCH app/xev] Add event filter for motion and button events

2014-02-11 Thread Egbert Eich
Signed-off-by: Egbert Eich e...@freedesktop.org --- man/xev.man | 2 +- xev.c | 10 +- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/man/xev.man b/man/xev.man index 4edec10..b6cb476 100644 --- a/man/xev.man +++ b/man/xev.man @@ -62,7 +62,7 @@ The option can

Re: [PATCH] DIX/ConfineTo: Improve algorithm to jump to the nearest point inside

2014-02-09 Thread Egbert Eich
Hi Keith, sorry for delaying this. I was occupied with other things and therefore wanted to wait for a bigger time window. On Fri, Oct 04, 2013 at 04:07:28PM -0700, Keith Packard wrote: Egbert Eich e...@freedesktop.org writes: ConfineToShape does not work well: The cursor often times

Re: [PATCH] XDMCP: For IPv6 add IPv6 link local addresses to the end of the list

2014-02-08 Thread Egbert Eich
On Sat, Feb 08, 2014 at 08:58:34PM +0600, Alexander E. Patrakov wrote: I have looked, and I have some remarks. Thanks for doing so! First, there is an almost identical copy-paste between the two places where entries are added to linklocal_list. Maybe it's worth making that a function?

Re: [PATCH] XDMCP: For IPv6 add IPv6 link local addresses to the end of the list

2014-02-08 Thread Egbert Eich
On Sat, Feb 08, 2014 at 07:45:54PM +0100, Egbert Eich wrote: ... OK, actually I have tested IPv6 UDP communication using link-local addresses using netcat6. It doesn't work (-EINVAL on bind() that is used to set the source address and port), so I will be very much surprised if XDMCP works

Re: [PATCH] XDMCP: For IPv6 add IPv6 link local addresses to the end of the list

2014-02-08 Thread Egbert Eich
to determine the interface, which it has no way to guess. Signed-off-by: Egbert Eich e...@freedesktop.org --- os/access.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/os/access.c b/os/access.c index e8c0781..1a2df34 100644 --- a/os/access.c +++ b/os/access.c @@ -600,7 +600,8

Re: [PATCH] DIX/ConfineTo: Improve algorithm to jump to the nearest point inside

2014-02-07 Thread Egbert Eich
Hi Keith, sorry for delaying this. I was occupied with other things and therefore wanted to wait for a bigger time window. On Fri, Oct 04, 2013 at 04:07:28PM -0700, Keith Packard wrote: Egbert Eich e...@freedesktop.org writes: ConfineToShape does not work well: The cursor often times

[PATCH] [DIX/ConfineTo] Don't bother about the bounding box when grabbing a shaped window

2014-02-07 Thread Egbert Eich
behavior. Signed-off-by: Egbert Eich e...@freedesktop.org --- dix/events.c | 78 +--- 1 file changed, 43 insertions(+), 35 deletions(-) diff --git a/dix/events.c b/dix/events.c index 8d7d12b..d3b4609 100644 --- a/dix/events.c +++ b/dix/events.c

[PATCH app/scripts] Add ssh support to 'xon'

2014-02-07 Thread Egbert Eich
login tool of chioce which also allows to tunnel the X protocol over a secure channel. This patch adds ssh support to xon to make it useful again. Signed-off-by: Egbert Eich e...@freedesktop.org --- I could be talked into nuking the rsh, rcmd support completely which would greatly simlify things

Re: [PATCH] XDMCP: For IPv6 add IPv6 link local addresses to the end of the list

2014-02-07 Thread Egbert Eich
It would be nice if someone took a look at this issue. So far noone has commented on this patch. Cheers, Egbert. On Wed, Aug 14, 2013 at 06:17:59PM +0200, Egbert Eich wrote: From: Reinhard Max m...@suse.de For IPv6 add a link local addresses to the end of the list passed

[PATCH 2/2] libxf86config: libxf86config_internal - libxf86config

2014-02-07 Thread Egbert Eich
Now since the installable libxf86config is gone, rename libxf86config_internal to libxf86config. Signed-off-by: Egbert Eich e...@freedesktop.org --- hw/xfree86/Makefile.am| 2 +- hw/xfree86/parser/Makefile.am | 4 ++-- test/Makefile.am | 2 +- 3 files changed, 4 insertions

[PATCH 1/2] libxf86config: Remove

2014-02-07 Thread Egbert Eich
in the sense that it was calling functions provided by the Xserver which were not implemented for the external library. Since this library is useless as it is anyway when built let's drop support for it. Signed-off-by: Egbert Eich e...@freedesktop.org --- configure.ac| 8 hw

Re: [PATCH] DIX/ConfineTo: Improve algorithm to jump to the nearest point inside

2014-02-07 Thread Egbert Eich
On Fri, Feb 07, 2014 at 11:38:25AM +0100, Egbert Eich wrote: commit d8a52a3a3b5bc4a1ff0a986e87dd6c36366e531b Author: Keith Packard kei...@keithp.com Date: Fri Oct 4 16:00:49 2013 -0700 Improved ConfineToShape Find the box within the region which is closest

Re: [PATCH v2] OS/ACPI: Make socket to acpid is non-blocking

2013-11-15 Thread Egbert Eich
On Thu, Nov 14, 2013 at 01:20:44PM +0900, Keith Packard wrote: Egbert Eich e...@freedesktop.org writes: static CARD32 lnxACPICheckTimer(OsTimerPtr timer, CARD32 now, pointer arg) { +struct timeval timeval = { 0, 0 }; DebugF(ACPI: trying to reopen\n

Re: [PATCH v2] OS/ACPI: Make socket to acpid is non-blocking

2013-11-15 Thread Egbert Eich
On Fri, Nov 15, 2013 at 11:25:49AM +0100, Egbert Eich wrote: On Thu, Nov 14, 2013 at 01:20:44PM +0900, Keith Packard wrote: Egbert Eich e...@freedesktop.org writes: static CARD32 lnxACPICheckTimer(OsTimerPtr timer, CARD32 now, pointer arg) { +struct timeval timeval = { 0

[PATCH v3] OS/ACPI: Make socket to acpid is non-blocking

2013-11-15 Thread Egbert Eich
for the first time or reconnect. Signed-off-by: Egbert Eich e...@freedesktop.org --- v3: Increase select() timeout when retrying as suggested by Keith Packard kei...@keithp.com. Fix some errno confusion. hw/xfree86/os-support/linux/lnx_acpi.c | 39 +++--- 1 file

[PATCH v2] DDX/modes: Add a sanity check when using screen sizes from EDID

2013-10-05 Thread Egbert Eich
suggesting to add a quirk table entry. Signed-off-by: Egbert Eich e...@freedesktop.org --- v2: Avoid division in ratio calculation. Pointed out by Keith Packard kei...@keithp.com hw/xfree86/modes/xf86Crtc.c | 20 1

[PATCH v2] DDX/fbdevhw: Disable FBIOBLANK ioctl if not supported

2013-10-05 Thread Egbert Eich
disable the call to this ioctl on the module level when detecting such a case. Signed-off-by: Egbert Eich e...@freedesktop.org --- v2: Retry on EINTR and ERESTART. Suggested by Keith Packard kei...@keithp.com hw/xfree86/fbdevhw/fbdevhw.c | 49 +++- 1 file

[PATCH v3] xnest: Ignore GetImage() error in xnestGetImage()

2013-10-05 Thread Egbert Eich
error handlers as suggested by Daniel Stone dan...@fooishbar.org. v3: Don't call Xsync before restoring error handler as any errors generated by XGetImage() should be processed when this call returns as suggested by Jamey Sharp ja...@minilop.net Signed-off-by: Egbert Eich e

Re: [PATCH replace] DDX/fbdevhw: Disable FBIOBLANK ioctl if not supported

2013-10-05 Thread Egbert Eich
On Fri, Oct 04, 2013 at 02:32:30PM -0700, Keith Packard wrote: Egbert Eich e...@freedesktop.org writes: Some ioctls may not be supported by the kernel however their failure is non-fatal to the driver. Unfortunately we only know once we try to execute the ioctl however the sematics

Re: [PATCH] OS/ACPI: Make socket to acpid is non-blocking

2013-10-05 Thread Egbert Eich
On Fri, Oct 04, 2013 at 04:14:29PM -0700, Keith Packard wrote: Egbert Eich e...@freedesktop.org writes: If a connect to the acpid socket is delayed connect will hang stalling the Xserver. To avoid this this create a non-blocking socket. Do you have cases which actually cause a delay

[PATCH v2] xnest: Ignore GetImage() error in xnestGetImage()

2013-10-04 Thread Egbert Eich
error handlers as suggested by Daniel Stone dan...@fooishbar.org. Signed-off-by: Egbert Eich e...@freedesktop.org --- hw/xnest/GCOps.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/hw/xnest/GCOps.c b/hw/xnest/GCOps.c index e26a136..7b1956d 100644 --- a/hw/xnest/GCOps.c

Re: [REPOST PATCH xauth] Look for FamilyLocal if inet or inet6 address is loopback

2013-10-01 Thread Egbert Eich
Jeremy, On Sun, Sep 29, 2013 at 08:29:48AM -0700, Jeremy Huddleston Sequoia wrote: You had incorrect casting in the IN6_IS_ADDR_* macros. Does Linux (or whatever platform you tested on) cast the arguments to those macros for you (thus correcting / undoing the casting that you provided)?

Re: [PATCH 2/2] DIX/Xi: Don't grab device buttons if no grab is registered

2013-10-01 Thread Egbert Eich
On Fri, Aug 30, 2013 at 02:00:55PM +1000, Peter Hutterer wrote: On Fri, Aug 16, 2013 at 01:56:07PM +0200, Egbert Eich wrote: On Fri, Aug 16, 2013 at 03:37:42PM +1000, Peter Hutterer wrote: On Thu, Aug 15, 2013 at 03:49:21PM +0200, Egbert Eich wrote: it is specified, see XIproto.txt

[PATCH xauth] Handle v4-mapped inet6 addresses correctly

2013-09-30 Thread Egbert Eich
in libxcb. Signed-off-by: Egbert Eich e...@freedesktop.org --- gethost.c | 26 -- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/gethost.c b/gethost.c index 48977bb..0a5aff5 100644 --- a/gethost.c +++ b/gethost.c @@ -245,17 +245,23 @@ struct addrlist

Re: [PATCH V2 xauth] Make matching algorithm mimic XauGet*AuthByAddr

2013-09-19 Thread Egbert Eich
at 10:11:06PM +0200, Egbert Eich wrote: Xlib (xcb) uses XauGetBestAuthByAddr() when looking for an authorization. 'xauth [n]list $DISPLAY' used a slightly stricter algorithm which doesn't find a possible authorization for cases where either the family is set to FamilyWild or address the address

Re: [REPOST PATCH xauth] Don't crash when running past the end of the chain

2013-09-18 Thread Egbert Eich
Hi! On August 14 I've reposted three patches for xauth to this mailing list. I did so, because I had discovered that a 'Dr. Tilmann Bubeck' has added himself as maintainer of the xauth package to the xorg/doc/xorg-docs/MAINTAINERS file on Jan. 22 2013 - considering the change frequency of this

Re: [REPOST PATCH xauth] Don't crash when running past the end of the chain

2013-09-18 Thread Egbert Eich
have them any more. Good night! Cheers, Egbert. Feel free to contact me for further questions. Kind regards, Tilmann Am 18.09.2013 19:44, schrieb Egbert Eich: Hi! On August 14 I've reposted three patches for xauth to this mailing list. I did so, because I had discovered

Re: [PATCH] OS/ACPI: Reconnect to acpid when it gets restarted

2013-09-17 Thread Egbert Eich
Hi Keith! Back from Vienna :) On Mon, Sep 09, 2013 at 04:23:20PM -0700, Keith Packard wrote: Egbert Eich e...@freedesktop.org writes: +PMClose +lnxACPIPoll(void) +{ +TimerSet(NULL, 0, 1, lnxACPICheckTimer, NULL); I'm betting this is supposed to be: acpiTimer

[PATCH v2] OS/ACPI: Make socket to acpid is non-blocking

2013-09-16 Thread Egbert Eich
for the first time or reconnect. Signed-off-by: Egbert Eich e...@freedesktop.org --- v2: Fixed log message. hw/xfree86/os-support/linux/lnx_acpi.c | 34 +- 1 file changed, 29 insertions(+), 5 deletions(-) diff --git a/hw/xfree86/os-support/linux/lnx_acpi.c b/hw

[PATCH v2] OS/ACPI: Retry (re)connecting to acpid until successful

2013-09-16 Thread Egbert Eich
On Linux the Xserver connects to the ACPI daemon to receive power management events. If this daemon isn't running when the Xserver starts or restarts while the Xserver is active the connection is lost. This adds a timer which periodically tries to (re)connect. Signed-off-by: Egbert Eich e

Re: [PATCH driver/nv 2/2] VGA/PowerPC: Implement MMIO access function to ST01 for PowerPC only

2013-08-16 Thread Egbert Eich
On Thu, Aug 15, 2013 at 04:29:00PM +0200, Mark Kettenis wrote: From: Egbert Eich e...@freedesktop.org Date: Tue, 13 Aug 2013 21:38:20 +0200 Access to most VGA registers is done thru MMIO. For the ST01 register PIO access is used to maintain timing for DACDelay(), a delay function

Re: [PATCH 2/2] DIX/Xi: Don't grab device buttons if no grab is registered

2013-08-16 Thread Egbert Eich
On Fri, Aug 16, 2013 at 03:37:42PM +1000, Peter Hutterer wrote: On Thu, Aug 15, 2013 at 03:49:21PM +0200, Egbert Eich wrote: Core events implicietely grab buttons on button press events, for typo Xi (ie. device) button press events this is not specified. it is specified, see

Re: [PATCH] DDX/PCI: Check harder for primary PCI device

2013-08-16 Thread Egbert Eich
On Thu, Aug 15, 2013 at 04:19:17PM +0200, Mark Kettenis wrote: I think dropping this non-libpciaccess fallback codepath should be the goal. Currently of all the systems supported by libpciaccess, only FreeBSD and OpenBSD don't implement the oot_vga callback function. And I've got the OpenBSD

[PATCH v2] DIX/Xi: Pass correct client to CheckDeviceGrabAndHintWindow()

2013-08-16 Thread Egbert Eich
If we have a client which has registered for a DeviceButton grab be sure to pass this to CheckDeviceGrabAndHintWindow(). Since the order of clients is arbitrary there is no guarantee that the last client in the list is the one that belongs to this class. Signed-off-by: Egbert Eich e

[PATCH] ARM64: Add support for aarch64

2013-08-15 Thread Egbert Eich
From: Andreas Schwab sch...@suse.de Signed-off-by: Andreas Schwab sch...@suse.de --- hw/xfree86/common/compiler.h| 2 +- hw/xfree86/os-support/linux/lnx_video.c | 3 ++- include/servermd.h | 14 ++ 3 files changed, 17 insertions(+), 2 deletions(-)

[PATCH] DDX/libxf86config: Fix missing server internal symbols

2013-08-15 Thread Egbert Eich
(), ErrorF and xstrtokenize() c.) by replacing xf86CheckBoolOption() with xf86findOptionValue() which requires a sligtly more complicated sematics. Signed-off-by: Egbert Eich e...@freedesktop.org --- Please note: This fix has been taken from an enterprise product at SUSE. It has been

[PATCH 0/2] Patches for Xi

2013-08-15 Thread Egbert Eich
. Egbert Eich (2): DIX/Xi: Pass correct client to CheckDeviceGrabAndHintWindow() DIX/Xi: Don't grab device buttons if no grab is registered dix/events.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) -- 1.8.1.4 ___ xorg

[PATCH 2/2] DIX/Xi: Don't grab device buttons if no grab is registered

2013-08-15 Thread Egbert Eich
. In other words this patch removes the 'implicite dragging' from Xi extension button events. Signed-off-by: Egbert Eich e...@freedesktop.org --- dix/events.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/dix/events.c b/dix/events.c index 36708bf..11dafa9 100644 --- a/dix/events.c +++ b/dix

[PATCH 1/2] DIX/Xi: Pass correct client to CheckDeviceGrabAndHintWindow()

2013-08-15 Thread Egbert Eich
If we have a client which has registered for a DeviceButton grab be sure to pass this to CheckDeviceGrabAndHintWindow(). Since the order of clients is arbitrary there is no guarantee that the last client in the list is the one that belongs to this class. Signed-off-by: Egbert Eich e

[PATCH V2] DDX/DPMS: Call dixSaveScreens() also when screen is turned on

2013-08-14 Thread Egbert Eich
screenIsSaved to make sure the state needs to be changed before calling dixSaveScreens(). Signed-off-by: Egbert Eich e...@freedesktop.org --- v2: Add check if the screen saving states requires changing before calling dixSaveScreens(). hw/xfree86/common/xf86DPMS.c | 9 - 1 file changed, 8

Re: [PATCH] loader: Use RTLD_DEEPBIND if available to prefer local symbols

2013-08-14 Thread Egbert Eich
On Wed, Aug 14, 2013 at 10:51:27AM +0200, Michel Dänzer wrote: On Mon, 2013-08-12 at 18:25 +0200, Egbert Eich wrote: If there are namespace clashes among different drivers it would be preferrable if each driver used its local symbols. Use the RTLD_DEEPBIND if available to achive

[PATCH V2 driver/vesa] Use default refresh by default

2013-08-14 Thread Egbert Eich
This seems to be a feature that isn't tested well. Too many VBE 3.0 BIOSes are incorrectly implemented. Signed-off-by: Egbert Eich e...@freedesktop.org --- v2: Fixed spelling. src/vesa.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/vesa.c b/src/vesa.c index

[PATCH driver/vesa] Make bool option parsing clearer and more consistent

2013-08-14 Thread Egbert Eich
When there's no need to know whether the user has set the value of a configurable option (for logging for instance) the return of xf86ReturnOptValBool() can be assigned directly. Signed-off-by: Egbert Eich e...@freedesktop.org --- src/vesa.c | 11 +-- 1 file changed, 5 insertions(+), 6

[REPOST PATCH xauth] Make matching algorithm mimic XauGet*AuthByAddr

2013-08-14 Thread Egbert Eich
Xlib (xcb) uses XauGetBestAuthByAddr() when looking for an authorization. 'xauth [n]list $DISPLAY' used a slightly stricter algorithm which doesn't find a possible authorization for cases where either the family is set to FamilyWild or address the address length is 0. Signed-off-by: Egbert Eich e

Re: [PATCH] loader: Use RTLD_DEEPBIND if available to prefer local symbols

2013-08-14 Thread Egbert Eich
On Wed, Aug 14, 2013 at 04:08:06PM +0200, Mark Kettenis wrote: That's indeed a concern I have. I think RTLD_DEEPBIND is only available with glibc. So basically, this would sweep some fundamental design problems in Mesa under the carpet on the dominant platform, leaving everybody else out

[PATCH] DDX/PCI: Check harder for primary PCI device

2013-08-14 Thread Egbert Eich
result also check for the presence of a BIOS rom. Signed-off-by: Egbert Eich e...@freedesktop.org --- hw/xfree86/common/xf86pciBus.c | 47 +++--- 1 file changed, 44 insertions(+), 3 deletions(-) diff --git a/hw/xfree86/common/xf86pciBus.c b/hw/xfree86/common

[PATCH] DIX/ConfineTo: Improve algorithm to jump to the nearest point inside

2013-08-14 Thread Egbert Eich
ConfineToShape does not work well: The cursor often times doesn't jump to the point closest to the current cursor position outside the shape. This patch fixes this. Signed-off-by: Egbert Eich e...@freedesktop.org --- dix/events.c | 84

[PATCH] XDMCP: For IPv6 add IPv6 link local addresses to the end of the list

2013-08-14 Thread Egbert Eich
will fail in which case the XDMCP server could still try the other addresses passed - however some only try the first address and then give up. Even if this seems to be the wrong place to fix this it seems to be easier than fixing all display servers. Signed-off-by: Egbert Eich e...@freedesktop.org

[PATCH] config/APM: Add option to disable building of APM support on Linux

2013-08-14 Thread Egbert Eich
a mode restoration anyhow. Therefore it should be possible to disable this feature. Signed-off-by: Egbert Eich e...@freedesktop.org --- configure.ac | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/configure.ac b/configure.ac index 715840d..2ad1af5 100644

[PATCH] OS/ACPI: Make socket to acpid is non-blocking

2013-08-14 Thread Egbert Eich
for the first time or reconnect. Signed-off-by: Egbert Eich e...@freedesktop.org --- hw/xfree86/os-support/linux/lnx_acpi.c | 34 +- 1 file changed, 29 insertions(+), 5 deletions(-) diff --git a/hw/xfree86/os-support/linux/lnx_acpi.c b/hw/xfree86/os-support/linux

Re: [PATCH] DDX/PCI: Check harder for primary PCI device

2013-08-14 Thread Egbert Eich
On Wed, Aug 14, 2013 at 07:50:50PM +0200, Mark Kettenis wrote: From: Egbert Eich e...@freedesktop.org Date: Wed, 14 Aug 2013 18:17:02 +0200 Primary PCI devices are identified by checking for an 'PCIINFOCLASSES' device which is VGA and has access to the memory bars enabled

[PATCH V2 xauth] Make matching algorithm mimic XauGet*AuthByAddr

2013-08-14 Thread Egbert Eich
Xlib (xcb) uses XauGetBestAuthByAddr() when looking for an authorization. 'xauth [n]list $DISPLAY' used a slightly stricter algorithm which doesn't find a possible authorization for cases where either the family is set to FamilyWild or address the address length is 0. Signed-off-by: Egbert Eich e

[PATCH V2] xnest: Ignore GetImage() error in xnestGetImage()

2013-08-13 Thread Egbert Eich
error handlers as suggested by Daniel Stone dan...@fooishbar.org. Signed-off-by: Egbert Eich e...@freedesktop.org --- hw/xnest/GCOps.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/hw/xnest/GCOps.c b/hw/xnest/GCOps.c index e26a136..7b1956d 100644 --- a/hw/xnest/GCOps.c

Re: [PATCH] DDX/fbdevhw: Make error message on failed FBIOBLANK less noisy and scarey

2013-08-13 Thread Egbert Eich
On Tue, Aug 13, 2013 at 09:14:25AM +0200, walter harms wrote: I do not get the point, do you expect ioctl to modify the errno ? Right, darn. After thinking about it I believe I found a better idea how to deal with the issue. Cheers, Egbert.

[PATCH replace] DDX/fbdevhw: Disable FBIOBLANK ioctl if not supported

2013-08-13 Thread Egbert Eich
disable the call to this ioctl on the module level when detecting such a case. Signed-off-by: Egbert Eich e...@freedesktop.org --- hw/xfree86/fbdevhw/fbdevhw.c | 45 +++- 1 file changed, 40 insertions(+), 5 deletions(-) diff --git a/hw/xfree86/fbdevhw

Re: [PATCH] vgahw: Resurrect disabling of legacy VGA support

2013-08-13 Thread Egbert Eich
On Tue, Aug 13, 2013 at 01:30:00PM +0200, Mark Kettenis wrote: There defenitely is an issue with the driver here. For one thing, the following bit: #if defined(__powerpc__) vgaHWSetMmioFuncs(VGAHWPTR(pScrn), (CARD8 *)pNv-IOAddress, 0); #endif Mark, what version of the driver are you

Re: [PATCH] vgahw: Resurrect disabling of legacy VGA support

2013-08-13 Thread Egbert Eich
On Tue, Aug 13, 2013 at 04:57:55PM +0200, Mark Kettenis wrote: Currently (at least on 49ee1c26ea982e) the idea seems to be that readST01 is routed thru the PIO access path possibly for timing reasons. This will however not work for PowerPC. At least not without further fixes to

  1   2   3   >