Re: [PATCH xf86-video-vmware 2/2] Add support for server managed fds

2014-05-14 Thread Jakob Bornecrantz
deletions(-) This patch has, if one thing is fixed as detailed below, my Reviewed-by: Jakob Bornecrantz ja...@vmware.com diff --git a/src/vmware_bootstrap.c b/src/vmware_bootstrap.c index b30cf2b..1635876 100644 --- a/src/vmware_bootstrap.c +++ b/src/vmware_bootstrap.c @@ -30,6 +30,7

Re: [PATCH xf86-video-vmware 1/2] Add support for XSERVER_PLATFORM_BUS

2014-05-14 Thread Jakob Bornecrantz
+++--- vmwgfx/vmwgfx_driver.c | 4 ++-- 3 files changed, 53 insertions(+), 8 deletions(-) Reviewed-by: Jakob Bornecrantz ja...@vmware.com diff --git a/src/vmware.c b/src/vmware.c index 6b74e14..17434ab 100644 --- a/src/vmware.c +++ b/src/vmware.c @@ -310,9 +310,6

Re: [PATCH xf86-video-vmware 2/2] Add support for server managed fds

2014-05-14 Thread Jakob Bornecrantz
On Wed, May 14, 2014 at 11:18 AM, Hans de Goede hdego...@redhat.com wrote: Hi, Thanks for the reviews! On 05/14/2014 11:07 AM, Jakob Bornecrantz wrote: On Wed, May 7, 2014 at 3:23 PM, Hans de Goede hdego...@redhat.com wrote: Signed-off-by: Hans de Goede hdego...@redhat.com --- src

Re: [PATCH RESEND video-vmware] vmwgfx: handle changes of DamageUnregister API in 1.14.99.2

2013-11-18 Thread Jakob Bornecrantz
Thanks, sorry for missing this, pushed to master. Cheers, Jakob. On Mon, Oct 28, 2013 at 11:21 PM, Gaetan Nadon mems...@videotron.ca wrote: Fix is inspired from the intel driver. Signed-off-by: Gaetan Nadon mems...@videotron.ca --- vmwgfx/vmwgfx_saa.c |6 ++ 1 file changed, 6

Re: [PATCH video-vmware] Do not use per-target compilation flags

2013-10-21 Thread Jakob Bornecrantz
On Mon, Sep 30, 2013 at 11:45 PM, Jakob Bornecrantz wallbra...@gmail.com wrote: Looks good, thanks. Ops sorry, internal review protocol, that patch is: Reviewed-By: Jakob Bornecrantz ja...@vmware.com ___ xorg-devel@lists.x.org: X.Org development

Re: [PATCH input-vmmouse] tools: make install fails when user has no write permission in /lib

2013-09-30 Thread Jakob Bornecrantz
Looks good! On Mon, Sep 30, 2013 at 7:56 PM, Gaetan Nadon mems...@videotron.ca wrote: The location of the udevdir is obtained from pkg-config. This is generally /lib/udev. Most people run their build scripts as non-root and do not want to overwrite or add files on their workstation system.

Re: [PATCH video-vmware] Do not use per-target compilation flags

2013-09-30 Thread Jakob Bornecrantz
Looks good, thanks. On Mon, Sep 30, 2013 at 8:51 PM, Gaetan Nadon mems...@videotron.ca wrote: Using vmware_drv_la_CFLAGS triggers the per-target compilation flag feature which requires AM_PROG_CC_C_O automake macro. The implementation of this feature is changing in automake 1.14 such that

Re: [PATCH][vmware] build: add explicit option to enable/disable VMWGFX

2013-09-13 Thread Jakob Bornecrantz
On Fri, Sep 13, 2013 at 10:08 AM, Burton, Ross ross.bur...@intel.comwrote: On 13 September 2013 06:01, Jakob Bornecrantz wallbra...@gmail.com wrote: If I'm reading this correctly this will cause the build to fail if you don't give it the disable flag if xatracker is missing? I'm

Re: [PATCH][vmware] build: add explicit option to enable/disable VMWGFX

2013-09-12 Thread Jakob Bornecrantz
On Thu, Sep 12, 2013 at 1:21 PM, Ross Burton ross.bur...@intel.com wrote: Signed-off-by: Ross Burton ross.bur...@intel.com If I'm reading this correctly this will cause the build to fail if you don't give it the disable flag if xatracker is missing? I'm on the fence if we want this, is this a

Re: [PATCH input-vmmouse] config: replace obsolete AM_CONFIG_HEADER with AC_CONFIG_HEADERS

2012-08-06 Thread Jakob Bornecrantz
Commited and Reviewed-by: ja...@vmware.com. On Tue, May 1, 2012 at 10:20 PM, Gaetan Nadon mems...@videotron.ca wrote: Moved up in the autoconf init section. It has been removed from Automake 1.12. Signed-off-by: Gaetan Nadon mems...@videotron.ca --- Thomas, yours to push

Re: [PATCH input-vmmouse] config: replace obsolete AM_CONFIG_HEADER with AC_CONFIG_HEADERS

2012-08-06 Thread Jakob Bornecrantz
Bah, I'm blind allready applied, sorry for the noise, teach me to apply first then send out a email :-/ Cheers, Jakob. ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info:

Re: [PATCH] vmware: Fix up some warnings after new compat API change.

2012-06-15 Thread Jakob Bornecrantz
On Fri, Jun 15, 2012 at 5:56 PM, Robert Hooker sarv...@ubuntu.com wrote: Fixes multiple instances of these warnings on x86_64: ../../src/vmware.h:180:5: warning: implicit declaration of function 'xf86ScreenToScrn' [-Wimplicit-function-declaration] ../../src/vmware.h:180:5: warning: nested

Re: [PATCH video-vmware] config: include saa and vmwgfx subdirs in the tarball

2012-03-12 Thread Jakob Bornecrantz
- Original Message - Use AM_CONDITIONAL. Automake knows what to distribute. It needs to be able to navigate down the subdirs to find what needs to be included in the tarball. To test reliably, create a tarball and expand it into a separate directory and build with xatracker.

Re: [PATCH vmmouse] Deal with opaque InputOption types in ABI 14

2012-01-12 Thread Jakob Bornecrantz
On Mon, Dec 19, 2011 at 3:49 AM, Peter Hutterer peter.hutte...@who-t.net wrote: On Sat, Nov 12, 2011 at 02:08:13PM +1000, Peter Hutterer wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- I admit I didn't test this other than compile-test but this should be the right fix.

Re: [PATCH xserver] dri2: Invalidate DRI2 buffers for all windows with the same pixmap on swap.

2011-03-25 Thread Jakob Bornecrantz
On Mar 25, 2011, at 13:47, Ville Syrjälä wrote: On Fri, Mar 25, 2011 at 12:35:37PM +0100, ext Michel Dänzer wrote: From: Michel Dänzer daen...@vmware.com Without this, when a compositing manager unredirects a fullscreen window which uses DRI2 and page flipping, the DRI2 buffer information

Re: mesa compile, talloc

2010-08-26 Thread Jakob Bornecrantz
On 26 aug 2010, at 15.10, Trevor Woerner wrote: Hi, I was trying to compile Xorg and had a bit of a stumble in the mesa directory. The configure.ac looks for the talloc package and assumes your distribution has supplied a talloc.pc to work with the pkg-config system. Unfortunately mine

[PATCH] RFC: Only match against event[0-9] in udev rules for vmmouse

2010-04-19 Thread Jakob Bornecrantz
It looks like the udev rule was matched against two devices which caused the driver to be loaded twice. We shouldn't match against the other device because it will very seldom send bogus events. Some of the bug this caused was buttons getting stuck. --- tools/69-xorg-vmmouse.rules.in |2 +- 1