Re: Can we rely on #pragma once ?

2024-02-19 Thread Mark Kettenis
> Date: Mon, 19 Feb 2024 12:13:34 +0100 > From: "Enrico Weigelt, metux IT consult" > > Hello folks, Hi Enrico, > we've got a lot of include files, therefore lots of guards. > > Modern C compilers should understand #pragma once, but this isn't > without problems (possibly problematic with

Re: tarball types (was: [ANNOUNCE] xf86-input-libinput 1.2.1)

2022-01-25 Thread Mark Kettenis
> Date: Mon, 24 Jan 2022 15:53:23 -0800 > From: Alan Coopersmith > > On 1/23/22 21:18, Peter Hutterer wrote: > > xf86-input-libinput 1.2.1 is now available. Primarily a few typos and misc > > minor fixes, the most visible change to distributions is that we now ship an > > xz tarball instead of

Re: XChangeProperty accesses 32 bit values as 64 bit

2019-01-02 Thread Mark Kettenis
> Date: Wed, 2 Jan 2019 16:31:39 +0100 > From: Hanno Böck > > Hi, > > Trying to debug a crash (in gajim) I discovered that it was due to a > stack buffer overread in gtk+/libX11. > > Digging down I am not entirely sure how to interpret it and whether > it's libX11's or GTK's fault. Here's

Re: [PATCH xserver] glamor: Work around GEM usage

2018-05-23 Thread Mark Kettenis
> From: Thomas Hellstrom > Date: Wed, 23 May 2018 22:58:05 +0200 > > On 05/23/2018 08:00 PM, Adam Jackson wrote: > > On Wed, 2018-05-23 at 11:14 +0200, Thomas Hellstrom wrote: > >> KMS drivers are not required to support GEM. In particular, vmwgfx > >> doesn't support

Re: [PATCH xserver 3/4] os: Make CLOCK_REALTIME the CLOCK_MONOTONIC fallback

2017-12-27 Thread Mark Kettenis
> From: Jeff Smith > Date: Tue, 26 Dec 2017 22:10:54 -0600 > > When clock_gettime(CLOCK_MONOTONIC) fails, xserver falls back on > gettimeofday(). However, gettimeofday() is deprecated in favor of > clock_gettime(CLOCK_REALTIME). > > Fall back on CLOCK_REALTIME if

Re: Severe performance regression was observed on X Server 1.18 with older graphics cards

2017-07-31 Thread Mark Kettenis
> From: "Kevin Brace" > Date: Mon, 31 Jul 2017 08:47:37 +0200 > > Hi, > > I am hoping someone can track down a bad commit that led to severe > performance regression likely caused by X Server 1.18. > The other day, I was trying to figure out why a computer with > Xubuntu

Re: [PATCH libpciaccess] linux: support 32 bit PCI domains

2017-07-12 Thread Mark Kettenis
> Date: Tue, 11 Jul 2017 10:32:19 -0700 > From: Stephen Hemminger > > On Tue, 11 Jul 2017 10:33:56 +0100 > Emil Velikov wrote: > > > On 11 July 2017 at 05:39, Alan Coopersmith > > wrote: > > > On 07/10/17

Re: [xproto] _X_NONNULL and C++ 11

2017-05-27 Thread Mark Kettenis
> Date: Sat, 27 May 2017 13:33:25 +0200 > From: walter harms > > Am 27.05.2017 11:02, schrieb Matthieu Herrb: > > Hi, > > > > Marc Espie recently found out that the X_NONNULL macro in Xfuncproto.h > > is generating spurious warnings when included in C++ code build with > >

Re: [PATCH xserver] Makefile.am: add the meson files to the tarball

2017-04-28 Thread Mark Kettenis
> Date: Fri, 28 Apr 2017 16:09:55 +1000 > From: Peter Hutterer > > While we're providing both build systems, we'll likely have 'make dist' > generated tarballs - those tarballs should be buildable with meson to > have more exposure. > > Signed-off-by: Peter Hutterer

Re: [PATCH libXdmcp v2] Use getentropy() if arc4random_buf() is not available

2017-04-05 Thread Mark Kettenis
oires <benjamin.tissoi...@gmail.com> Same comment as the other diff. Reviewed-by: Mark Kettenis <kette...@openbsd.org> > --- > > changes in v2: > - use the getentropy() from glibc, not the plain syscall > - make it clear that arc4random_buf() should be preferred and

Re: [PATCH libICE v2] Use getentropy() if arc4random_buf() is not available

2017-04-05 Thread Mark Kettenis
in Tissoires <benjamin.tissoi...@gmail.com> The emulate_getrandom_buf() name sounds a bit weird. Perhaps call it bad_getrandom_buf() or dangerous_getrandom_buf() or insecure_getrandom_buf() to make it obvious that the fallback code really isn't sufficient? Reviewed-by: Mark Kettenis <kette

Re: [PATCH libXdmcp] Use getrandom() syscall if available

2017-04-04 Thread Mark Kettenis
> From: Benjamin Tissoires <benjamin.tissoi...@gmail.com> > Date: Tue, 4 Apr 2017 11:05:47 +0200 > > On Mon, Apr 3, 2017 at 9:17 PM, Mark Kettenis <mark.kette...@xs4all.nl> wrote: > > OpenBSD does not have a getrandom(3) function in libc. The OpenBSD > > post

Re: [PATCH libXdmcp] Use getrandom() syscall if available

2017-04-03 Thread Mark Kettenis
> From: Benjamin Tissoires > Date: Mon, 3 Apr 2017 17:52:32 +0200 > > On Mon, Apr 3, 2017 at 4:02 PM, Alan Coopersmith > wrote: > > On 04/ 3/17 05:52 AM, Benjamin Tissoires wrote: > >> > >> This allows to fix CVE-2017-2625 on Linux

Re: [PATCH rendercheck 0/5] Convert to meson.

2017-03-24 Thread Mark Kettenis
> From: Eric Anholt > Date: Fri, 24 Mar 2017 13:17:45 -0700 > > Having bitten off a bit more than I can chew in 3 days with the X > Server (hw/xfree86/sdksyms.c is the worst), I decided to take a quick > pass at converting a project that's my own fault. Seems I missed some

Re: [PATCH 1/4] xfree86: Don't bother probing -nv on Linux

2017-03-16 Thread Mark Kettenis
OpenBSD indeed. Diff makes sense to me. Reviewed-by: Mark Kettenis <kette...@openbsd.org> > Signed-off-by: Timo Aaltonen <tjaal...@ubuntu.com> > --- > hw/xfree86/common/xf86pciBus.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/hw/xfree

Re: [PATCH libdrm v2 2/4] xf86drm: Add USB support

2017-01-13 Thread Mark Kettenis
> From: Thierry Reding > Date: Thu, 12 Jan 2017 23:04:27 +0100 > > Allow DRM/KMS devices hosted on USB to be detected by the drmDevice > infrastructure. > > v2: > - make sysfs_uevent_get() more flexible using a format string > > Signed-off-by: Thierry Reding

Re: [PATCH xserver 0/5] Remove (most) 24bpp support

2016-12-08 Thread Mark Kettenis
> From: Keith Packard <kei...@keithp.com> > Date: Thu, 08 Dec 2016 12:25:46 -0800 > > Mark Kettenis <mark.kette...@xs4all.nl> writes: > > > It is also unfortunate that this means you won't be able to run X > > directly on the framebuffer set up by UEFI fir

Re: [PATCH xserver 0/5] Remove (most) 24bpp support

2016-12-08 Thread Mark Kettenis
> From: Adam Jackson > Date: Thu, 08 Dec 2016 13:34:11 -0500 > > On Thu, 2016-12-08 at 09:19 -0800, Keith Packard wrote: > > > Adam Jackson writes: > > > Assuming those bugs are gone, the only configurations that would break > > > are the two drivers mentioned

Re: [PATCH libpciaccess] Support for 32-bit domains

2016-08-12 Thread Mark Kettenis
> From: Eric Anholt > Date: Thu, 11 Aug 2016 23:32:04 -0700 > > Keith Busch writes: > > > On Thu, Aug 11, 2016 at 12:03:30PM -0700, Eric Anholt wrote: > >> Given that libpciaccess allocates the struct, and the struct isn't > >> embedded in any other

Re: [PATCH libpciaccess] Support for 32-bit domains

2016-08-11 Thread Mark Kettenis
> Date: Wed, 10 Aug 2016 22:58:34 + > From: Keith Busch <keith.bu...@intel.com> > > On Thu, Aug 11, 2016 at 12:17:48AM +0200, Mark Kettenis wrote: > > > From: Keith Busch <keith.bu...@intel.com> > > > Date: Tue, 9 Aug 2016 15:39:35 -0600 > &

Re: [PATCH libpciaccess] Support for 32-bit domains

2016-08-10 Thread Mark Kettenis
> From: Keith Busch > Date: Tue, 9 Aug 2016 15:39:35 -0600 > > A pci "domain" is a purely software construct, and need not be limited > to the 16-bit ACPI defined segment. The Linux kernel currently supports > 32-bit domains, so this patch matches up with those

Re: [PATCH] modesetting: fix build with glamor disabled.

2016-05-05 Thread Mark Kettenis
> From: Dave Airlie <airl...@gmail.com> > Date: Fri, 6 May 2016 05:41:58 +1000 > > From: Dave Airlie <airl...@redhat.com> > > Fix build without --enable-glamor. > > Caught by the arm tinderbox. > > Signed-off-by: Dave Airlie <airl...@r

Re: [PATCH xserver 3/4] dix: Convert ResourceClientBits to a variable

2016-05-03 Thread Mark Kettenis
> From: Adam Jackson > Date: Tue, 3 May 2016 11:24:36 -0400 > > This turns out to be a remarkably hot function in XID lookup. Consider > the expansion of CLIENT_ID. We start with: > > #define RESOURCE_CLIENT_BITS ResourceClientBits() > #define RESOURCE_AND_CLIENT_COUNT 29 >

Re: [PATCH xserver] ad hoc fix for mmap's truncated offset parameter on 32bit

2016-04-29 Thread Mark Kettenis
> Date: Fri, 29 Apr 2016 09:34:08 +0200 > From: Julien Cristau <jcris...@debian.org> > > On Thu, Apr 28, 2016 at 16:10:01 +0200, Mark Kettenis wrote: > > > > From: Stefan Dirsch <sndir...@suse.de> > > > Date: Thu, 28 Apr 2016 14:35:00 +0200 > &

Re: [PATCH xserver] ad hoc fix for mmap's truncated offset parameter on 32bit

2016-04-28 Thread Mark Kettenis
> From: Stefan Dirsch > Date: Thu, 28 Apr 2016 14:35:00 +0200 > > Builtin modesetting driver didn't work on 32bit on cirrus KMS. See > https://bugzilla.suse.com/show_bug.cgi?id=917385 for more details. I think selectively compiling with -D_FILE_OFFSET_BITS=64 is a seriously

Re: [xserver-xorg][PATCH 1/1] xwayland: ftruncate if posix_fallocate fails

2016-04-26 Thread Mark Kettenis
> Date: Tue, 26 Apr 2016 15:58:47 +0300 > From: Ian Ray > > On Mon, Apr 25, 2016 at 04:49:07PM +0300, Pekka Paalanen wrote: > > On Mon, 25 Apr 2016 15:47:09 +0300 > > Ian Ray wrote: > > > > > On a slow system that is configured with SMART_SCHEDULE_POSSIBLE,

Re: [PATCH] Avoid 10x7 heuristic, handled by server

2016-04-26 Thread Mark Kettenis
> From: Stefan Dirsch > Date: Tue, 26 Apr 2016 11:45:15 +0200 > > From: Frederic Crozat > > Remove the 10x7 heuristic, since the server has equivalent code now. > Instead, disable "acceleration" under qemu, since taking the hypercall > trap is really quite

Re: [PATCH] Use 16bpp when running in virt and on XenSource gfx

2016-04-26 Thread Mark Kettenis
> From: Stefan Dirsch > Date: Tue, 26 Apr 2016 11:45:38 +0200 > > From: Frederic Crozat > > Due to graphics corruption default to 16bpp in virt instead of 24 (Fedora). > Do the same on XenSource gfx, which suffers from the same issue. I think using magic

Re: [PATCH xserver] os: Treat ssh as a non-local client (v3)

2016-01-12 Thread Mark Kettenis
atch "ssh" itself, not other executable names starting with > > that prefix. > > * Ignore executable path for the match. > > v3: (Michel Dänzer) > > * Use GetClientCmdName (Mark Kettenis) > > * Perform check on Windows as well, but only ignore path on Cy

Re: [PATCH xserver 4/8] Create a threaded mechanism for input [v3]

2015-12-12 Thread Mark Kettenis
> From: Keith Packard <kei...@keithp.com> > Date: Fri, 11 Dec 2015 15:37:24 -0800 > > Keith Packard <kei...@keithp.com> writes: > > > Mark Kettenis <mark.kette...@xs4all.nl> writes: > > > >> However, is there a reason why you

Re: [PATCH xserver] os: Treat ssh as a non-local client (v2)

2015-12-12 Thread Mark Kettenis
> From: =?UTF-8?q?Michel=20D=C3=A4nzer?= > Date: Fri, 11 Dec 2015 11:28:51 +0900 > > By the time we get to ComputeLocalClient, we've already done > NextAvailableClient → ReserveClientIds → > DetermineClientCmd (assuming we're built with #define CLIENTIDS), so > we can

Re: [PATCH xserver 4/8] Create a threaded mechanism for input [v3]

2015-12-12 Thread Mark Kettenis
> From: Keith Packard <kei...@keithp.com> > Date: Sat, 12 Dec 2015 13:19:59 -0800 > > Mark Kettenis <mark.kette...@xs4all.nl> writes: > > > I'd say that would be overkill. The use of recursive mutexes is > > somewhat controversal, which is almost certa

Re: [PATCH xserver 4/8] Create a threaded mechanism for input [v3]

2015-12-11 Thread Mark Kettenis
> From: Keith Packard <kei...@keithp.com> > Date: Thu, 10 Dec 2015 07:18:23 -0800 > > Mark Kettenis <mark.kette...@xs4all.nl> writes: > > > Ugh. Exporting global variables as part of the ABI is generally not > > such a good idea. Perhaps it is better to u

Re: [PATCH 0/5] Remove DRI1

2015-12-09 Thread Mark Kettenis
> From: Adam Jackson > Date: Tue, 8 Dec 2015 17:41:35 -0500 > > DRI1 hasn't really been a supported option for a while now, Mesa hasn't > supplied any drivers for it in years, and the design really isn't > compatible with KMS-like drivers. Also, Keith has some upcoming work to

Re: [PATCH xserver 0/6] Use a thread for input

2015-12-09 Thread Mark Kettenis
> From: Keith Packard > Date: Tue, 8 Dec 2015 15:44:48 -0800 > > Here's a series which revives Tiago's ancient threaded input > patch. This has been cleaned up to make sure that it does locking > correctly, and then patches for xf86 and kdrive/fbdev hook the code to > a

Re: [PATCH xserver 4/8] Create a threaded mechanism for input [v3]

2015-12-09 Thread Mark Kettenis
> From: Keith Packard > Date: Wed, 09 Dec 2015 16:04:08 -0800 > > >> +extern _X_EXPORT pthread_mutex_t input_mutex; > >> +extern _X_EXPORT __thread int input_mutex_count; > >> + > > Are these really meant to be exported - a wild guess will be that the > > input drivers won't

Re: [PATCH:libxtrans] Remove support for SysV on x86 platforms other than Solaris & SCO

2015-11-29 Thread Mark Kettenis
igned-off-by: Alan Coopersmith <alan.coopersm...@oracle.com> Reviewed-by: Mark Kettenis <kette...@openbsd.org> > --- > Xtrans.c |7 ++- > Xtransint.h |8 > Xtranssock.c | 12 > 3 files changed, 6 insertions(+), 21 deletions(-) _

Re: [PATCH:libX11] Remove unused definition of XCONN_CHECK_FREQ

2015-11-29 Thread Mark Kettenis
Coopersmith <alan.coopersm...@oracle.com> Reviewed-by: Mark Kettenis <kette...@openbsd.org> > --- > include/X11/Xlibint.h |8 > 1 file changed, 8 deletions(-) ___ xorg-devel@lists.x.org: X.Org development Archives: h

Re: [PATCH 1/2] modesetting: drop platform_dev pointer.

2015-11-18 Thread Mark Kettenis
> From: Dave Airlie <airl...@gmail.com> > Date: Wed, 18 Nov 2015 09:51:04 +1000 > > This isn't used anywhere, so no point storing it until we need it. Makes sense to me. Reviewed-by: Mark Kettenis <kette...@openbsd.org> > Signed-off-by: Dave Airlie <airl...@r

Re: [PATCH v2] glamor: Make glamor_name_from_pixmap work without DRI3

2015-11-18 Thread Mark Kettenis
> From: Eric Anholt <e...@anholt.net> > Date: Wed, 18 Nov 2015 12:57:31 -0800 > > Mark Kettenis <kette...@openbsd.org> writes: > > > This function is used by the modesetting driver to implement DRI2 and > > shouldn't fail on systems that don't suppo

[PATCH v2] glamor: Make glamor_name_from_pixmap work without DRI3

2015-11-17 Thread Mark Kettenis
This function is used by the modesetting driver to implement DRI2 and shouldn't fail on systems that don't support DRI3. Remove the check for DRI3 and rename glamor_egl_dri3_fd_name_from_tex to glamor_egl_fd_name_from_tex. Signed-off-by: Mark Kettenis <kette...@openbsd.org> --- glamor/gl

[PATCH] glamor: Make glamor_sync_init work with --disable-xshmfence

2015-11-17 Thread Mark Kettenis
Signed-off-by: Mark Kettenis <kette...@openbsd.org> --- glamor/glamor_sync.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/glamor/glamor_sync.c b/glamor/glamor_sync.c index fbc47d4..907e0c6 100644 --- a/glamor/glamor_sync.c +++ b/glamor/glamor_sync.c @@ -97,6 +97,9 @@ glamor_syn

Re: [PATCH] glamor: Make glamor_name_from_pixmap work without DRI3

2015-11-16 Thread Mark Kettenis
> From: Keith Packard <kei...@keithp.com> > Date: Sun, 15 Nov 2015 23:51:04 -0800 > > Mark Kettenis <kette...@openbsd.org> writes: > > > This function is used by the modesetting driver to implement DRI2 and > > shouldn't

Re: zaphod support broke the modesetting driver

2015-11-16 Thread Mark Kettenis
> Date: Mon, 16 Nov 2015 09:05:53 +1000 > From: Dave Airlie <airl...@gmail.com> > > On 16 November 2015 at 02:57, Mark Kettenis <mark.kette...@xs4all.nl> wrote: > > Commit 19e1dc8f6ea6d7ff5ba4a5caa0e2f40a47879408 broke the modesetting > > driver quite badly on

[PATCH] glamor: Make glamor_name_from_pixmap work without DRI3

2015-11-15 Thread Mark Kettenis
This function is used by the modesetting driver to implement DRI2 and shouldn't fail on systems that don't support DRI3. Signed-off-by: Mark Kettenis <kette...@openbsd.org> --- glamor/glamor.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/glamor/glamor.c b/glamor/glamor.c index d

Re: glamor and the sync extension

2015-11-15 Thread Mark Kettenis
mfence implementationand should probably be avoided. > On Sun, Nov 15, 2015 at 8:59 AM, Mark Kettenis <mark.kette...@xs4all.nl> > wrote: > > Currently glamor hits an assertion on systems that don't have > > xshmfence. This happens when the glamor code calls > >

glamor and the sync extension

2015-11-15 Thread Mark Kettenis
Currently glamor hits an assertion on systems that don't have xshmfence. This happens when the glamor code calls miSyncGetScreenFuncs() because the miSyncScreenPrivateKey has not been set up. For systems with xshmfence, this happens when miSyncShmScreenInit() gets called, but that code is

Re: [PATCH xserver 23/24] Remove readmask from screen block/wakeup handler

2015-09-21 Thread Mark Kettenis
> From: Keith Packard <kei...@keithp.com> > Date: Mon, 21 Sep 2015 12:06:22 +0100 > > Mark Kettenis <mark.kette...@xs4all.nl> writes: > > > This, of course, has impact on pretty much all the drivers. Many use > > compat-api.h and could probably be f

Re: [PATCH xserver 23/24] Remove readmask from screen block/wakeup handler

2015-09-21 Thread Mark Kettenis
> From: Keith Packard > Date: Mon, 21 Sep 2015 07:16:34 +0100 > > With no users of the interface needing the readmask anymore, we can > remove it from the argument passed to these functions. > > Signed-off-by: Keith Packard This, of course, has impact on

Re: [xrandr] Only use the current information when setting modes

2015-09-13 Thread Mark Kettenis
> From: Chris Wilson > Date: Sun, 13 Sep 2015 11:40:37 +0100 > > Before we change the state (e.g. adding a mode or applying one to an > output), we query the screen resources for the right identifiers. This > should only use the current information rather than force a

Re: [xrandr] Only use the current information when setting modes

2015-09-13 Thread Mark Kettenis
> Date: Sun, 13 Sep 2015 12:14:57 +0100 > From: Chris Wilson <ch...@chris-wilson.co.uk> > > On Sun, Sep 13, 2015 at 01:08:11PM +0200, Mark Kettenis wrote: > > > From: Chris Wilson <ch...@chris-wilson.co.uk> > > > Date: Sun, 13 Sep 2015 11:40:37 +0100 &g

Re: Fwd: [PATCH] Make configure test for LD_NO_UNDEFINED_FLAG on Solaris work w/autoconf 2.69

2015-09-12 Thread Mark Kettenis
> Date: Sat, 12 Sep 2015 09:40:18 -0700 > > Anyone want to review this 4 month old patch? (void *)0 certainly is avalid null pointer constant. So Reviewed-by: Mark Kettenis <kette...@openbsd.org> > Forwarded Message > Subject: [PATCH

Re: [PATCH xinit] remove bogus \/ escapes

2015-08-31 Thread Mark Kettenis
> correction, never producing any output, having no effect at all in > terminal output, and only changing spacing in a minor way in typeset > output. > > Signed-off-by: Matthieu Herrb <matth...@herrb.eu> Verified that even man on Linux doesn't render \/ as a slash. Reviewed-

Re: [PATCH] remove bogus \/ escapes

2015-08-31 Thread Mark Kettenis
> correction, never producing any output, having no effect at all in > terminal output, and only changing spacing in a minor way in typeset > output. > > Signed-off-by: Matthieu Herrb <matth...@herrb.eu> Reviewed-by: Mark Kettenis <kette...@openbsd.org> > --- > hw/

Re: [PATCH xorg-docs] remove bogus \/ escapes

2015-08-31 Thread Mark Kettenis
> correction, never producing any output, having no effect at all in > terminal output, and only changing spacing in a minor way in typeset > output. > > Signed-off-by: Matthieu Herrb <matth...@herrb.eu> Reviewed-by: Mark Kettenis <kette...@openbsd.org> > --- > ma

Re: [PATCH libXt] Fix builds on X32

2015-05-18 Thread Mark Kettenis
From: Ross Burton ross.bur...@intel.com Date: Mon, 18 May 2015 17:05:46 +0100 The x86 X32 ABI is a 32-bit environment on 64-bit processors, so __amd64__ is defined but pointers and longs are 32-bit. Handle this case by also checking __LP64__. That's the wrong way to handle it. Not all

Re: [PATCH] Allow system call restarts upon signal interruption

2015-05-13 Thread Mark Kettenis
From: =?UTF-8?Q?Michel_D=c3=a4nzer?= mic...@daenzer.net Date: Wed, 13 May 2015 11:18:45 +0900 On 13.05.2015 07:39, Daniel Drake wrote: The X server frequently deals with SIGIO and SIGALRM interruptions. If process execution is inside certain blocking system calls when these signals

Re: [PATCH xinit] Remove workaround for xterm -L (#89653)

2015-03-24 Thread Mark Kettenis
Date: Tue, 24 Mar 2015 11:33:28 +0100 From: Hans de Goede hdego...@redhat.com Hi, On 24-03-15 05:49, Peter Hutterer wrote: The -L flag was removed in 1989. This enables the legacy keyboard driver again when the server is started with -keeptty (bd6cacdd3661) X.Org Bug 89653

Re: [PATCH:xf86-video-mga] Fix pointer cast warning.

2015-02-25 Thread Mark Kettenis
Date: Wed, 25 Feb 2015 11:31:50 +0100 From: Tormod Volden lists.tor...@gmail.com On Tue, Feb 24, 2015 at 7:36 AM, Mark Kettenis mark.kette...@xs4all.nl wrote: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] Signed-off-by: Thomas Klausner w

Re: [PATCH:xf86-video-mga] Fix pointer cast warning.

2015-02-23 Thread Mark Kettenis
Date: Mon, 23 Feb 2015 22:55:51 -0800 From: Alan Coopersmith alan.coopersm...@oracle.com On 02/23/15 10:36 PM, Mark Kettenis wrote: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] Signed-off-by: Thomas Klausner w...@netbsd.org --- src

[PATCH xinit] startx: Don't use GNU expr extensions

2015-01-29 Thread Mark Kettenis
Use the ':' operator instead of match and avoid the use of \+. Both constructions aren't specified by POSIX and not supported in BSD expr. Also drop the '^' from the regular expressions as it is implicit and POSIX leaves its behaviour undefined. Signed-off-by: Mark Kettenis kette...@openbsd.org

Re: [PATCH:xauth v2] include POSIX-standard limits.h for PATH_MAX instead of sys/syslimits.h

2015-01-03 Thread Mark Kettenis
From: Alan Coopersmith alan.coopersm...@oracle.com Date: Sat, 3 Jan 2015 10:52:28 -0800 Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com Reviewed-by: Mark Kettenis kette...@openbsd.org --- gethost.c |2 +- parsedpy.c |2 +- 2 files changed, 2 insertions(+), 2

Re: [PATCH:xauth] include limits.h for PATH_MAX on OS'es without sys/syslimits.h

2015-01-02 Thread Mark Kettenis
From: Alan Coopersmith alan.coopersm...@oracle.com Date: Fri, 2 Jan 2015 09:50:36 -0800 Are there any systems that have sys/syslimits.h but don't have a limits.h that provides PATH_MAX? POSIX requires that limits.h provides PATH_MAX. And as far as I can tell sys/syslimits.h is a BSD-ism, and

Re: [PATCH] Solaris: delete undocumented, unuseful -protect0 flag

2014-12-09 Thread Mark Kettenis
fd; ^ Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com Reviewed-by: Mark Kettenis kette...@openbsd.org in case you need one. --- hw/xfree86/os-support/solaris/sun_init.c | 31 -- 1 file changed, 31 deletions

Re: [PATCH 4/5] dix: GetHosts bounds check using wrong pointer value

2014-12-09 Thread Mark Kettenis
by: Mark Kettenis kette...@openbsd.org --- os/access.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/os/access.c b/os/access.c index f393c8d..28f2d32 100644 --- a/os/access.c +++ b/os/access.c @@ -1308,7 +1308,7 @@ GetHosts(void **data, int *pnHosts, int *pLen, BOOL

Re: [PATCH 2/4] xfree86: Remove implicit xf86EnableIO from BSD for PowerPC

2014-10-24 Thread Mark Kettenis
with an r128 on OpenBSD. Although I think that on OpenBSD we actually avoid accessing VGA registers. Reviewed-by: Mark Kettenis kette...@openbsd.org --- hw/xfree86/os-support/bsd/ppc_video.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/xfree86/os-support/bsd/ppc_video.c b/hw/xfree86

Re: [PATCH 1/4] xfree86: Remove no-op /dev/mem checks from xf86OSInitVidMem

2014-10-15 Thread Mark Kettenis
back if we ever add it back (which isn't all that likely). Reviewed-by: Mark Kettenis kette...@openbsd.org Signed-off-by: Adam Jackson a...@redhat.com --- hw/xfree86/os-support/bsd/alpha_video.c | 122 hw/xfree86/os-support/bsd/arm_video.c | 52

Re: [PATCH 0/4] Finish killing VidMemInfo

2014-10-13 Thread Mark Kettenis
From: Adam Jackson a...@redhat.com Date: Wed, 8 Oct 2014 17:38:55 +0200 This finishes the job from: http://lists.freedesktop.org/archives/xorg-devel/2014-July/043343.html OpenBSD retains its special case for privsep setup, but otherwise this is the same as before. Please give me a

[PATCH pciaccess] Use PCIOCREADMASK on OpenBSD.

2014-09-29 Thread Mark Kettenis
the devices was initially probed. Reviewed-by: Matthieu Herrb matth...@herbb.eu Signed-off-by: Mark Kettenis kette...@openbsd.org --- Given that Matthieu already reviewed this diff, I'll push it in a couple of days unless somebody speaks up. src/openbsd_pci.c | 31 +-- 1

Re: [PATCH 04/19] loader: Deobfuscate RTLD_* macro stuff

2014-09-25 Thread Mark Kettenis
From: Adam Jackson a...@redhat.com Date: Thu, 25 Sep 2014 13:37:20 -0400 POSIX requires that these be named correctly, no need to be clever. None of the BSDs have needed those compatibility defines for quite some time, and I doubt anything else still supported cares. Reviewed-by: Mark

Re: [PATCH 18/19] xfree86: Remove driver entity hooks and private

2014-09-25 Thread Mark Kettenis
From: Adam Jackson a...@redhat.com Date: Thu, 25 Sep 2014 13:37:34 -0400 No driver is using these, as far as I know. The xf86-video-mga driver uses these, but only if DISABLE_VGA_IO is defined, and by default it isn't, and there is no configure option to turn it on. I'm a bit worried about

Re: [PATCH 19/19] x86emu: Undefine _NO_INLINE

2014-09-25 Thread Mark Kettenis
From: Adam Jackson a...@redhat.com Date: Thu, 25 Sep 2014 13:37:35 -0400 Never defined by the server. Fairly certain it was never intended to be defined by the server, but used as a compile-time option to make debugging easier. Signed-off-by: Adam Jackson a...@redhat.com ---

Re: [PATCH] os: Don't listen to 'tcp' or 'unix' by default. Add '-listen' option.

2014-09-13 Thread Mark Kettenis
From: Keith Packard kei...@keithp.com Date: Fri, 12 Sep 2014 15:19:53 -0700 Mark Kettenis mark.kette...@xs4all.nl writes: Unconditionally disabling the unix listen ports by default might be a step too far. Abstract sockets are only available on Linux. Yes, of course. So on other

Re: [PATCH] os: Don't listen to 'tcp' or 'unix' by default. Add '-listen' option.

2014-09-13 Thread Mark Kettenis
From: Keith Packard kei...@keithp.com Date: Fri, 12 Sep 2014 11:35:41 -0700 This disables tcp and unix listen ports by default (the unix port is the non-abstract /tmp/.X11-unix port that xcb doesn't use). Then, it uses a new xtrans interface, TRANS(Listen), to provide a command line option

Re: [PATCH xinit 0/1] startx: Pass -nolisten tcp by default

2014-09-12 Thread Mark Kettenis
From: Colin Harrison colin.harri...@virgin.net Date: Fri, 12 Sep 2014 09:37:05 +0100 Hi, 'this day and age' 'this time and age' Time is good: it allows evolution (or erosion) to slowly happen. But I for one vote that X11 network transparency remains default. In this day^H^H^Htime

Re: [PATCH xinit 0/1] startx: Pass -nolisten tcp by default

2014-09-12 Thread Mark Kettenis
From: Hans de Goede hdego...@redhat.com Date: Fri, 12 Sep 2014 09:25:17 +0200 Hi All, After doing the 1.3.4 release yesterday, I've started working on updating the Fedora packages to 1.3.4. While looking at our open bug list against xinit, I found one bug which is not yet resolved in

Re: [PATCH xinit 0/1] startx: Pass -nolisten tcp by default

2014-09-12 Thread Mark Kettenis
Date: Fri, 12 Sep 2014 12:17:24 +0200 From: Hans de Goede hdego...@redhat.com Hi, On 09/12/2014 11:12 AM, Mark Kettenis wrote: From: Hans de Goede hdego...@redhat.com Date: Fri, 12 Sep 2014 09:25:17 +0200 Hi All, After doing the 1.3.4 release yesterday, I've started working

Re: [PATCH] os: Don't listen to 'tcp' or 'unix' by default. Add '-listen' option.

2014-09-12 Thread Mark Kettenis
From: Keith Packard kei...@keithp.com Date: Fri, 12 Sep 2014 11:35:41 -0700 This disables tcp and unix listen ports by default (the unix port is the non-abstract /tmp/.X11-unix port that xcb doesn't use). Then, it uses a new xtrans interface, TRANS(Listen), to provide a command line option

Re: [PATCH 09/12] xfree86: Remove leaky /dev/mem checks from xf86OSInitVidMem

2014-07-29 Thread Mark Kettenis
From: Adam Jackson a...@redhat.com Date: Tue, 29 Jul 2014 15:00:16 -0400 This is mostly a no-op, the checks didn't have much effect since pciaccess didn't end up using the fd we opened. Except for OpenBSD, where you have to pass that in from above, which is sort of a weird API decision.

Re: [PATCH] modesetting: Support native primary plane rotation

2014-07-10 Thread Mark Kettenis
From: Chris Wilson ch...@chris-wilson.co.uk Date: Wed, 9 Jul 2014 12:14:41 +0100 With the advent of universal drm planes and the introduction of generic plane properties for rotations, we can query and program the hardware for native rotation support. NOTE: this depends upon the next

Re: [PATCH] modesetting: Support native primary plane rotation

2014-07-09 Thread Mark Kettenis
Date: Wed, 09 Jul 2014 09:28:31 +0200 From: walter harms wha...@bfs.de Am 09.07.2014 09:00, schrieb Chris Wilson: With the advent of universal drm planes and the introduction of generic plane properties for rotations, we can query and program the hardware for native rotation support.

Re: [PATCH] libx11:lcDefConv.c:fix use before check

2014-06-04 Thread Mark Kettenis
Date: Wed, 04 Jun 2014 12:07:25 +0200 From: walter harms wha...@bfs.de Do not use variables before checked for NULL. Signed-off-by: wharms wha...@bfs.de --- modules/lc/def/lcDefConv.c | 35 +-- 1 file changed, 25 insertions(+), 10 deletions(-)

Re: [PATCH] libx11:lcDefConv.c:fix use before check

2014-06-04 Thread Mark Kettenis
Date: Wed, 04 Jun 2014 13:28:35 +0200 From: walter harms wha...@bfs.de Am 04.06.2014 12:23, schrieb Mark Kettenis: Date: Wed, 04 Jun 2014 12:07:25 +0200 From: walter harms wha...@bfs.de Do not use variables before checked for NULL. Signed-off-by: wharms wha...@bfs.de

Re: [PATCH 0/9] Rewrite include/servermd.h

2014-05-22 Thread Mark Kettenis
From: Adam Jackson a...@redhat.com Date: Wed, 21 May 2014 15:31:16 -0400 We really don't want to be in the business of knowing about CPU architectures. servermd.h is one of the worst offenders for that in the tree; this series attempts to clean out the gunk. Probably the most contentious

Re: [PATCH 1/3] xfree86: Report DRI3 as a built-in module

2014-05-12 Thread Mark Kettenis
From: Chris Wilson ch...@chris-wilson.co.uk Date: Mon, 12 May 2014 08:12:37 +0100 This is so that drivers can do a runtime check that DRI3 is available, similar to existing runtime checks performed by the drivers for DRI and DRI2. Does that run-time check actually work? It seems any check

Re: xserver ABI freeze policy (was: [PATCH] hw/xfree86: Restore API compatibility for cursor loading functions)

2014-04-29 Thread Mark Kettenis
From: Keith Packard kei...@keithp.com Date: Mon, 28 Apr 2014 15:59:32 -0700 Aaron Plattner aplatt...@nvidia.com writes: Changing the ABI at the last minute, even if you bump the ABI version number, defeats the purpose of that. In this case, I just added support for ABI 17 so that

Re: [PATCH 0/4] Xorg.wrap: Misc cleanups and porting

2014-04-14 Thread Mark Kettenis
From: Guillem Jover guil...@hadrons.org Date: Mon, 14 Apr 2014 18:13:21 +0200 Hi! I've adapted the porting patches I submitted to the Debian Xorg wrapper long ago to the native one, and in the process fixed some other issues. I've only tested that it builds, and that it fails on a

Re: libdrm: ERESTART undefined

2014-04-12 Thread Mark Kettenis
Date: Sat, 12 Apr 2014 09:21:06 +0200 From: Thomas Klausner w...@netbsd.org After updating libdrm in pkgsrc, I got a bug report from David Shao --- begin quote --- For current cvs pkgsrc on DragonFly 3.7-DEVELOPMENT and perhaps other BSDs, ERESTART is not defined for userland programs

Re: [PATCH libxtrans] Increase UNIX socket buffer size

2014-03-30 Thread Mark Kettenis
Date: Sat, 29 Mar 2014 17:26:00 -0700 From: Alan Coopersmith alan.coopersm...@oracle.com Do we need to do the same for the SO_RCVBUF as well? Not really. These connections are local by defenition so in principle it doesn't really matter whether we queue on the sending side or on the

Re: [PATCH] dix/dispatch: DoGetImage: Use a single buffer

2014-03-29 Thread Mark Kettenis
From: Keith Packard kei...@keithp.com Date: Sat, 29 Mar 2014 10:38:01 -0700 Daniel Kurtz djku...@chromium.org writes: DoGetImage chops up an image into IMAGE_BUFSIZE strips. This predates commit [0] (a pull from XFree86 to X.Org), at which time IMAGE_BUFSIZE was 8k. It's worked

[PATCH libxtrans] Increase UNIX socket buffer size

2014-03-29 Thread Mark Kettenis
From: Mark Kettenis kette...@openbsd.org Some systems provide a really small default buffer size for UNIX sockets. Bump it up to 64k if necessary such that large transfers (such as XGetImage() on a 8-megapixel image) don't take tens of seconds. --- Xtranssock.c | 21 + 1 file

Re: [PATCH] dix/dispatch: DoGetImage: Use a single buffer

2014-03-29 Thread Mark Kettenis
From: Keith Packard kei...@keithp.com Date: Sat, 29 Mar 2014 12:40:07 -0700 In my case the problem shows up with Firefox, which apparently is rendering images to the screen when downloading them, then grabs the pixels with XGetImage() and re-renders using those grabbed pixels. Seems

Re: [PATCH xinit v2 1/3] Remove unixware / sco support

2014-03-27 Thread Mark Kettenis
From: Hans de Goede hdego...@redhat.com Date: Thu, 27 Mar 2014 12:55:55 +0100 We don't support SCO / Unixware anymore, so lets remove the SCO / Unixware specific bits from startx and xinitrc Signed-off-by: Hans de Goede hdego...@redhat.com Reviewed-by: Mark Kettenis kette...@openbsd.org

Re: [PATCH xinit v2 3/3] startx: Under Linux start X on the current VT

2014-03-27 Thread Mark Kettenis
From: Hans de Goede hdego...@redhat.com Date: Thu, 27 Mar 2014 12:55:57 +0100 When we let X allocate a new VT, systemd-logind will not recognize any processes running on this VT as belonging to a valid session (since there was no pam session opened on that tty). This causes problems like

Re: [PATCH v2 2/2] xf86LogInit: log to XDG_DATA_HOME when not running as root

2014-03-26 Thread Mark Kettenis
From: Hans de Goede hdego...@redhat.com Date: Wed, 26 Mar 2014 12:24:50 +0100 When no logfile was specified (xf86LogFileFrom == X_DEFAULT) and we're not running as root log to $XDG_DATA_HOME/xorg/Xorg.#.log as Xorg won't be able to log to the default /var/log/... when it is not running as

Re: [PATCH:libxtrans 1/2] Add missing headers for free() and strlen().

2014-03-26 Thread Mark Kettenis
From: Thomas Klausner w...@netbsd.org Date: Wed, 26 Mar 2014 12:49:31 +0100 Signed-off-by: Thomas Klausner w...@netbsd.org Reviewed-by: Mark Kettenis kette...@openbsd.org --- Xtrans.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Xtrans.c b/Xtrans.c index 735d7b8..9a6dfbc

Re: [PATCH libxtrans v2] configure: Also add -D_DEFAULT_SOURCE to .pc cflags to shut up glibc warnings

2014-03-25 Thread Mark Kettenis
compromise to me. Still think that what the glibc developers did is unhelpful though. Reviewed-by: Mark Kettenis kette...@openbsd.org ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman

Re: [PATCH xf86-video-ati] Add support for server managed fds

2014-03-15 Thread Mark Kettenis
From: Hans de Goede hdego...@redhat.com Date: Tue, 11 Mar 2014 11:09:19 +0100 Signed-off-by: Hans de Goede hdego...@redhat.com --- src/radeon_kms.c | 60 +- src/radeon_probe.c | 5 + src/radeon_probe.h | 2 ++ 3 files

Re: [PATCH 02/10] fb: Use #error instead of a syntax error

2014-03-10 Thread Mark Kettenis
From: Adam Jackson a...@redhat.com Date: Mon, 10 Mar 2014 11:04:26 -0400 Signed-off-by: Adam Jackson a...@redhat.com Reviewed-by: Mark Kettenis kette...@openbsd.org --- fb/fb.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fb/fb.h b/fb/fb.h index f63aa4f

Re: [PATCH 01/10] fb: Modernize the FbBits typedef for FB_SHIFT == 6

2014-03-10 Thread Mark Kettenis
From: Adam Jackson a...@redhat.com Date: Mon, 10 Mar 2014 11:04:25 -0400 Signed-off-by: Adam Jackson a...@redhat.com Not immediately obvious to me how you get stdint.h. Perhaps you should explicitly include it? --- fb/fb.h | 15 +-- 1 file changed, 1 insertion(+), 14

  1   2   3   4   5   6   >