Re: Anything depending on non-libpciaccess ?

existing setups gratuitously. -- Matthieu Herrb

Re: Meson vs. automake/autoconf

on is forcing us to rewrite a build system that can run on those systems. Moreover, since the fdo CI doesn't check builds on those systems, the meson configurations are more or less broken on those systems. And unfortunatly I don't have time anymore to take care of all of theses issues alone. -- Matthieu Herrb

Re: Minor bug in xcb_connect

@ xcb_connection_t *xcb_connect_to_display > > if(auth) { > c = xcb_connect_to_fd(fd, auth); > -goto out; > } > - > -if(_xcb_get_auth_info(fd, , display)) > +else if(_xcb_get_auth_info(fd, , display)) > { > c = xcb_connect_to_fd(fd, ); > free(ourauth.name); > -- Matthieu Herrb

Re: Making new releases of X.Org modules

So currently having releases that get pushed to OpenBSD-current, Arch Linux and other rolling releases helps with testing patches. (the libX11 pthreads stuff is a good illustration ihmo). -- Matthieu Herrb

Re: vblank-synchronized Present copy

On Thu, Nov 24, 2022 at 06:35:07PM +0800, Po Lu wrote: > Matthieu Herrb writes: > > > Not all systems supported by X.Org have timerfd. So please make this > > feàture conditional it's presence, > > Sure, but isn't modesetting recent-Linux-only? No, the version

Re: vblank-synchronized Present copy

t; also send the PresentCompleteNotify event at vblank start time (as > opposed to the first-pixel-out time, which is when it's sent in response > to a page flip.) > Not all systems supported by X.Org have timerfd. So please make this feàture conditional it's presence, -- Matthieu Herrb

Re: Fwd: XInitThreads in library constructor breaks Motif!

On Wed, Nov 02, 2022 at 10:13:02PM +0100, Matthieu Herrb wrote: > On Wed, Nov 02, 2022 at 11:29:19AM -0700, Alan Coopersmith wrote: > > On 11/2/22 07:53, Adam Jackson wrote: > > > I missed that! My apologies. I've merged the reentrancy patch, we should > > > probab

Re: Fwd: XInitThreads in library constructor breaks Motif!

few days for any more testing to > be reported and then probably cut a 1.8.2 release next week. > https://marc.infœ?l=openbsd-tech=166742060513284=2 doesn't look too good. unfortunatly no time to try to see if I can reproduce this before next week. -- Matthieu Herrb

Re: Fwd: XInitThreads in library constructor breaks Motif!

1.8.1: https://marc.infœ?l=openbsd-tech=166729483920618=2 On my small test case it seems to fix the issue. -- Matthieu Herrb

Re: XInitThreads in library constructor breaks Motif!

. However one of the software that's doing a lot of Xlib calls in the X*IfEvents() callbacks is fvwm{2,3}. The MR I send them is wrong, and I fear they are fiddling with the input queue in the callbacks. I'll have to test how it behaves with this change. -- Matthieu Herrb

Re: Requiring newer autoconf for X.Org packages?

4cd2d0331655 > Hi, autoconf 2.71 complains about obsolete contructs in X.Org's configure.ac : AC_PROG_LIBTOOL AC_PROG_CC_C99 and suggests to run autoupdate to fix. This will trigger a lot of new packages releases :-) -- Matthieu Herrb

Re: Xorg projects to archive on gitlab?

- appears abandoned, no commits since 2007 > > Does anyone still use these or ship them in a distro or packaging > system? None of those are in OpenBSD... > Most importantly, does anyone want to maintain them? -- Matthieu Herrb

Re: X server new numbering scheme

On Thu, Dec 09, 2021 at 06:17:13PM +0100, Michel Dänzer wrote: > On 2021-12-06 22:36, Matthieu Herrb wrote: > > Hi, > > > > I don't understand why the 1.20.x -> 21.x.y change was needed, but I > > can accept it. > > > > That said, why try t

X server new numbering scheme

peing this from an X server build with VENDOR_RELEASE = (((21) * 1000) + ((1) * 10) + ((1) * 1000) + 0) and have found no issue yet. What was the need for this "backward compatibility" ? What do you think ? -- Matthieu Herrb

libX11 security advisory: May 11, 2021

== This vulnerability has been discovered by Roman Fiedler from Unparalleled IT Services e.U. -- Matthieu Herrb signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https

X.Org server security advisory: April 13, 2021

== These vulnerabilities have been discovered by Jan-Niklas Sohn working with Trend Micro Zero Day Initiative. -- Matthieu Herrb signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info

X.Org server security advisory: December 1, 2020

() and SetDeviceIndicators() heap overflows ZDI-CAN 11389 / CVE-2020-25712 Thanks == These vulnerabilities have been discovered by Jan-Niklas Sohn working with Trend Micro Zero Day Initiative. -- Matthieu Herrb ___ xorg-devel@lists.x.org: X.Org development

Re: Preparing for libX11 1.7.0

was added, the shared lib version number in src/Makefie.am probably needs to be adjusted too. -- Matthieu Herrb ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel

release fonttosfnt 1.1.1 ?

, -- Matthieu Herrb ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: xorg xinit: use `uname -n` instead of `hostname`

://gitlab.freedesktop.org/xorg/app/xinit/-/merge_requests/3 > > I've cc'ed the developer list since I don't know if there are any platforms > this will cause problems for. (I'm one of the last people to ask about > Linux issues, since I work on Solaris, not Linux.) > No o

[PATCH util/modular] release.sh: check that umask will create archives with correct modes

Signed-off-by: Matthieu Herrb --- release.sh | 8 1 file changed, 8 insertions(+) diff --git release.sh release.sh index 86d0d49..665c103 100755 --- release.sh +++ release.sh @@ -944,6 +944,14 @@ do shift done +umask=$(umask) +if [ "${umask}" != "022" -o

X.Org libX11 security advisory: August 25, 2020

020-14363 This can lead to a double free later, as reported by Jayden Rivers. Thanks -- X.Org thanks Jayden Rivers for reporting this issue to our security team and assisting them in understanding them and providing fixes. -- Matthieu Herrb signature.asc Description:

X.Org security advisory: July 31, 2020: Xserver

n NullPixmap; Thanks == This vulnerability was discovered by Jan-Niklas Sohn working with Trend Micro Zero Day Initiative. -- Matthieu Herrb signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http:/

X.Org security advisory: July 31, 2020: libX11

ion. Thanks == X.Org thanks Todd Carson for reporting these issues to our security team and assisting them in understanding them and providing fixes. -- Matthieu Herrb signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org developm

X.Org security advisory: July 31, 2020: libX11

ion. Thanks == X.Org thanks Todd Carson for reporting these issues to our security team and assisting them in understanding them and providing fixes. -- Matthieu Herrb signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org developm

Re: cherry-pick candidate for a future 1.20.9 release

On Tue, Apr 14, 2020 at 11:12:37AM +0200, Michel Dänzer wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 2020-04-13 7:52 p.m., Matthieu Herrb wrote: > > Hi, > > > > I'd like to nominate 364d64981549544213e2bca8de6ff8a5b2b5a69e as a > > commit

cherry-pick candidate for a future 1.20.9 release

. -- Matthieu Herrb signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH libXmu v2 1/2] Remove support for XA_IP_ADDRESS

On Tue, Jan 14, 2020 at 06:29:52PM -0500, Thomas Dickey wrote: > On Tue, Jan 14, 2020 at 10:23:15PM +0100, Matthieu Herrb wrote: > > This code has a number of issues: > > - It doesn't support IPv6 https://bugs.freedesktop.org/show_bug.cgi?id=7611 > > - The IP address is set b

Re: [patch libXmu] Fix OWNER_OS in XmuConvertStandardSelection() on Linux

On Tue, Jan 14, 2020 at 11:32:46PM +0100, Matthieu Herrb wrote: > It used to return BSD > --- > src/CvtStdSel.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/CvtStdSel.c b/src/CvtStdSel.c > index 36423c6..d462273 100644 > --- a/src/CvtStdSel.c > +++ b

[patch libXmu] Fix OWNER_OS in XmuConvertStandardSelection() on Linux

It used to return BSD --- src/CvtStdSel.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/CvtStdSel.c b/src/CvtStdSel.c index 36423c6..d462273 100644 --- a/src/CvtStdSel.c +++ b/src/CvtStdSel.c @@ -89,6 +89,9 @@ in this Software without prior written authorization from The Open Group.

[PATCH libXmu v2 1/2] Remove support for XA_IP_ADDRESS

environments (like OpenBSD's pledge https://marc.info/?l=openbsd-bugs=157842725819911=2) Signed-off-by: Matthieu Herrb --- src/CvtStdSel.c | 30 ++ 1 file changed, 2 insertions(+), 28 deletions(-) diff --git a/src/CvtStdSel.c b/src/CvtStdSel.c index 36423c6..5089623

[PATCH libXmu v2 2/2] Unifdef SYSVNET

This has not been set by configure since the switch to autotools. Signed-off-by: Matthieu Herrb --- src/CvtStdSel.c | 9 - 1 file changed, 9 deletions(-) diff --git a/src/CvtStdSel.c b/src/CvtStdSel.c index 5089623..f84f2dd 100644 --- a/src/CvtStdSel.c +++ b/src/CvtStdSel.c @@ -36,13

[PATCH libXmu 1/2] Remove support for XA_IP_ADDRESS

environments (like OpenBSD's pledge https://marc.info/?l=openbsd-bugs=157842725819911=2) Signed-off-by: Matthieu Herrb --- src/CvtStdSel.c | 27 +-- 1 file changed, 1 insertion(+), 26 deletions(-) diff --git a/src/CvtStdSel.c b/src/CvtStdSel.c index 36423c6..0d577ef

[PATCH libXmu 2/2] Unifdef SYSVNET

This has not been set by configure since the switch to autotools. Signed-off-by: Matthieu Herrb --- src/CvtStdSel.c | 9 - 1 file changed, 9 deletions(-) diff --git a/src/CvtStdSel.c b/src/CvtStdSel.c index 0d577ef..3414f1e 100644 --- a/src/CvtStdSel.c +++ b/src/CvtStdSel.c @@ -36,13

Re: xorgproto header installation conflicts

libXpm > libXpresent > libXrandr > libXrender > libXres > libXt > libXtst > libXv > libXvMC > libXxf86dga > libXxf86misc > libXxf86vm > libdmx > libdrm > libxkbfile > libxkbui > > Thanks, > Thomas > ___ > xorg-devel@lists.x.org: X.Org d

Re: Proposed addition to CodingStyle web page about assert(a && b)

e used to reject bad user input or any other error condition that can happen for some known reason. It should really only be used to document conditions that should really never happen. In all other cases the function should be able to return an error to the caller (which should of cours

Re: [PATCH libXext] add ACLOCAL_AMFLAGS = -I m4 to make aclocal pick ax_gcc_builtin.m4

On Sun, Mar 17, 2019 at 09:07:00AM -0700, Alan Coopersmith wrote: > On 3/17/19 6:29 AM, Matthieu Herrb wrote: > > Signed-off-by: Matthieu Herrb > > --- > > Makefile.am | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Makefile.am b/Makefi

[PATCH libXext] add ACLOCAL_AMFLAGS = -I m4 to make aclocal pick ax_gcc_builtin.m4

Signed-off-by: Matthieu Herrb --- Makefile.am | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Makefile.am b/Makefile.am index b76bc6c..4f5c67d 100644 --- a/Makefile.am +++ b/Makefile.am @@ -1,5 +1,7 @@ SUBDIRS = man src specs +ACLOCAL_AMFLAGS = -I m4 + pkgconfigdir = $(libdir

[PATCH xman] Fix typo in manual page.

reported by Alejandro G. Peregrina on OpenBSD tech@ list Signed-off-by: Matthieu Herrb --- man/xman.man | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/xman.man b/man/xman.man index 5edb892..d9e3667 100644 --- a/man/xman.man +++ b/man/xman.man @@ -152,7 +152,7 @@ n(n

[PATCH xf86-input-synaptics] Use fabs() instead of abs() on double values.

Silences clang warnings. Signed-off-by: Matthieu Herrb --- src/synaptics.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/synaptics.c b/src/synaptics.c index 930d02e..bc2d2af 100644 --- a/src/synaptics.c +++ b/src/synaptics.c @@ -2602,7 +2602,7

[PATCH xf86-video-neomagic] Use fabs() instead of abs() on double value.

Silences clang warnings. Signed-off-by: Matthieu Herrb --- src/neo_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/neo_driver.c b/src/neo_driver.c index 84e09ca..4301881 100644 --- a/src/neo_driver.c +++ b/src/neo_driver.c @@ -2953,7 +2953,7 @@ neoCalcVCLK

[PATCH xf86-input-joystick] Silence clang warnings on floating point abs() / pow() calls.

Signed-off-by: Matthieu Herrb --- src/jstk_axis.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/jstk_axis.c b/src/jstk_axis.c index cb4a004..37bb66b 100644 --- a/src/jstk_axis.c +++ b/src/jstk_axis.c @@ -136,11 +136,11 @@ jstkAxisTimer(OsTimerPtrtimer

[xorgproto] Remove RCS Ids

Signed-off-by: Matthieu Herrb --- include/X11/extensions/xcalibrateproto.h | 2 -- include/X11/extensions/xcalibratewire.h | 2 -- 2 files changed, 4 deletions(-) diff --git a/include/X11/extensions/xcalibrateproto.h b/include/X11/extensions/xcalibrateproto.h index cafdab2..f9b9425 100644

Re: Xwayland on demand (Re: [PATCH xwayland 3/3] xwayland: Handle the case of windows being realized before redirection)

han having resouces loaded in the X server by xrdb, but you can always link .Xdefaults to .Xresources for this kind of situation. Not sure if Gtk/Qt/whatever use the Xlib functions or if they have their own code that would ignore .Xdefaults. -- Matthieu Herrb signature.asc Description: PGP s

Re: Will like to release xf86-video-mga Version 1.7 soon

. You may want to consider it for the 1.7.0 release. -- Matthieu Herrb ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel

[PATCH xf86-video-mga] Use fabs() to compute absolute value of floating point number.

Fixes a warning from clang and looks like it was a real bug. Signed-off-by: Matthieu Herrb --- src/mga_dacG.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mga_dacG.c b/src/mga_dacG.c index 3b0d93e..5c08f8a 100644 --- a/src/mga_dacG.c +++ b/src/mga_dacG.c @@ -986,8

Re: [PATCH app/xcursorgen v3] Update README for gitlab migration

EADME.md alone. As Ray say people are used to that now. -- Matthieu Herrb signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel

X.Org security advisory: August 21, 2018

X.Org security advisory: August 21, 2018 Multiple issues in libX11 = The functions XGetFontPath, XListExtensions and XListFonts from libX11 are vulnerable to three different issues: Off-by-one writes (CVE-2018-14599). --- The functions

Re: [PATCH app/xdm] Add missing brackets to multi-statement if in SaveServerAuthorizations

] > if (auths[i]->data_length > 0) > ^~ > auth.c:452:3: note: ...this statement, but the latter is misleadingly > indented as if it were guarded by the ‘if’ >(void) fflush (auth_file); >^ > > Signed-off-by: Alan Coopersmith <alan.coopersm...@oracl

Re: [PATCH:libXaw] Fix xload crashes if the window is wider than 2048 pixels

On Sat, Mar 24, 2018 at 10:45:47PM -0700, Alan Coopersmith wrote: > https://bugs.freedesktop.org/show_bug.cgi?id=96670 > > Signed-off-by: Alan Coopersmith <alan.coopersm...@oracle.com> Reviewed-by: Matthieu Herrb <matth...@herrb.eu> > --- > > I wasn't sure

Re: [PATCH libX11] Use size_t for buffer sizes in SetHints.c

On Sat, Mar 24, 2018 at 07:48:49PM -0700, Alan Coopersmith wrote: > These variables store values returned from strlen() as a size_t > and are passed to Xmalloc, which expects a size_t, so lets stop > converting back and forth to int along the way. LGTM, Reviewed-by: Matthieu Her

Re: [PATCH xserver 00/10] Implement RandR 1.6 (leases and non-desktop)

favor of meson in general would be a major PITA. For the proto case, we actually don't use the autotools build system for the split packages version, because of the overhead, and the (relative) simplicity of just writing BSD makefiles for these. I haven't looked that the merged xproto yet though. --

[PATCH bdftopcf] Depend on xproto and fsproto that are now used.

Signed-off-by: Matthieu Herrb <matth...@herrb.eu> --- Makefile.am | 3 ++- configure.ac | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index 6012b42..caaf6e8 100644 --- a/Makefile.am +++ b/Makefile.am @@ -22,7 +22,8 @@ SUBDIRS = man bin_PR

Re: [PATCH:macros] Update check for manpage section numbers to not rely on Solaris version

racle.com> Hi, I can't test it anymore, but it looks good to me. Reviewed-by: Matthieu Herrb <matth...@herrb.eu> > --- > xorg-macros.m4.in | 31 +++ > 1 file changed, 19 insertions(+), 12 deletions(-) > > diff --git a/xorg-macros.m4.in b/xorg-ma

[xproto] _X_NONNULL and C++ 11

1 */ #define _X_NONNULL(...) __attribute__((nonnull(__VA_ARGS__))) #elif __has_attribute(nonnull) \ || defined(__GNUC__) && ((__GNUC__ * 100 + __GNUC_MINOR__) >= 303) -- 2.13.0 -- Matthieu Herrb signature.asc Description: PGP signature __

[PATCH] Brown bag commit to fix 957e8d (arc4random_buf() support)

- typo in #ifdef check - also need to add AC_CHECK_FUNCS([arc4random_buf]) Reported-by Eric Engestrom. Thanks Signed-off-by: Matthieu Herrb <matth...@herrb.eu> --- configure.ac | 1 + os/auth.c| 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/configure.ac b/config

Re: [PATCH 1/3] Use timingsafe_memcmp() to compare MIT-MAGIC-COOKIES CVE-2017-2624

On Wed, Mar 01, 2017 at 12:15:00AM +0100, Hans de Goede wrote: > Hi, > > On 28-02-17 23:52, Matthieu Herrb wrote: > > > > On Tue, Feb 28, 2017 at 10:41:29PM +, Emil Velikov wrote: > > > Hi Matthieu, > > > > > > On 28 February 2017 at

Re: [PATCH 1/3] Use timingsafe_memcmp() to compare MIT-MAGIC-COOKIES CVE-2017-2624

On Tue, Feb 28, 2017 at 10:41:29PM +, Emil Velikov wrote: > Hi Matthieu, > > On 28 February 2017 at 18:18, Matthieu Herrb <matth...@herrb.eu> wrote: > > Provide the function definition for systems that don't have it. > > > > Signed-off-by: Matthieu Herrb

Re: [PATCH 0/3] patches for Advisory X41-2017-001

On Tue, Feb 28, 2017 at 02:17:39PM -0500, Adam Jackson wrote: > On Tue, 2017-02-28 at 19:18 +0100, Matthieu Herrb wrote: > > Hi, > > > > this patches series, already sent (and partially reviewed by) to > > xorg-security address the X server side of Advisory X41-2017-

[PATCH 3/3] auth: remove AuthToIDFunc and associated functions. Not used anymore.

And the current code for MitToId has a use-after-free() issue. Signed-off-by: Matthieu Herrb <matth...@herrb.eu> Reviewed-by: Alan Coopersmith <alan.coopersm...@oracle.com> --- os/auth.c | 7 +++ os/osdep.h | 6 -- 2 files changed, 3 insertions(+), 10 deletions(-) dif

[PATCH 2/3] Use arc4random_buf(3) if available to generate cookies.

Signed-off-by: Matthieu Herrb <matth...@herrb.eu> --- configure.ac| 2 ++ include/dix-config.h.in | 6 ++ os/auth.c | 7 +++ 3 files changed, 15 insertions(+) diff --git a/configure.ac b/configure.ac index f6a49302f..6a7c4cc6f 100644 --- a/configure.ac

[PATCH 1/3] Use timingsafe_memcmp() to compare MIT-MAGIC-COOKIES CVE-2017-2624

Provide the function definition for systems that don't have it. Signed-off-by: Matthieu Herrb <matth...@herrb.eu> Reviewed-by: Alan Coopersmith <alan.coopersm...@oracle.com> --- configure.ac| 3 ++- include/dix-config.h.in | 3 +++ include/os.h| 5 +

[PATCH 0/3] patches for Advisory X41-2017-001

Org builds (with build.sh) do depend on libbsd and use arc4random_buf() here to generate the cookies. I don't know why the versions shipped by some distros seem to still use the fallback code. -- Matthieu Herrb signature.asc Description: PGP signature ___

Re: [PATCH libXpm] Handle size_t in file/buffer length

On Sun, Dec 11, 2016 at 01:50:05PM +0100, Matthieu Herrb wrote: > From: Tobias Stoeckmann <tob...@stoeckmann.org> > > The values of file sizes and buffer sizes can exceed current limits. > Therefore, use proper variable types for these operations. This is bug

[PATCH libXpm] Handle size_t in file/buffer length

From: Tobias Stoeckmann The values of file sizes and buffer sizes can exceed current limits. Therefore, use proper variable types for these operations. --- src/RdFToBuf.c | 4 src/WrFFrBuf.c | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git

[PATCH libXpm] Avoid OOB write when handling malicious XPM files.

From: Tobias Stoeckmann libXpm uses unsigned int to store sizes, which fits size_t on 32 bit systems, but leads to issues on 64 bit systems. On 64 bit systems, it is possible to overflow 32 bit integers while parsing XPM extensions in a file. At first, it looks like a

Re: [PATCH libXpm] Gracefully handle EOF while parsing files.

On Tue, Dec 06, 2016 at 10:34:33PM +0100, Matthieu Herrb wrote: This is from https://bugs.freedesktop.org/show_bug.cgi?id=98878 > From: Tobias Stoeckmann <tob...@stoeckmann.org> > > libXpm does not properly handle EOF conditions when xpmGetC is called > multiple times in

Re: [PATCH libXpm] Fix out out boundary read on unknown colors

On Tue, Dec 06, 2016 at 10:31:53PM +0100, Matthieu Herrb wrote: This is from https://bugs.freedesktop.org/show_bug.cgi?id=98877 > From: Tobias Stoeckmann <tob...@stoeckmann.org> > > libXpm is vulnerable to an out of boundary read if an XPM file contains > a color wi

Re: [patch libICE] Fix use after free on subsequent calls

On Tue, Dec 06, 2016 at 10:26:59PM +0100, Matthieu Herrb wrote: This is from https://bugs.freedesktop.org/show_bug.cgi?id=98822 > From: Tobias Stoeckmann <tob...@stoeckmann.org> > > The function IceAuthFileName is vulnerable to a use after free. The > flaw can be tr

[PATCH libXpm] Gracefully handle EOF while parsing files.

From: Tobias Stoeckmann libXpm does not properly handle EOF conditions when xpmGetC is called multiple times in a row to construct a string. Instead of checking its return value for EOF, the result is automatically casted into a char and attached to a string. By carefully

[patch libICE] Fix use after free on subsequent calls

From: Tobias Stoeckmann The function IceAuthFileName is vulnerable to a use after free. The flaw can be triggered by calling the function three times: - First call succeeds and stores the path in buf, a dynamically allocated buffer with size bsize. - Second call fails

[PATCH libXpm] Fix out out boundary read on unknown colors

From: Tobias Stoeckmann libXpm is vulnerable to an out of boundary read if an XPM file contains a color with a symbolic name but without any default color value. A caller must set XpmColorSymbols and a color with a NULL name in the supplied XpmAttributes to

Re: [PATCH libX11] Don't rebuild ks_tables.h if nothing changed.

On Sat, Oct 08, 2016 at 11:22:45PM +0200, Martin Natano wrote: > On Sat, Oct 08, 2016 at 09:45:09PM +0200, Matthieu Herrb wrote: > > > > It looks good to me. 2 little things though: > > > > - you should use 'git commit -s' to generate a Signed-off-by: field in > &

Re: [PATCH libX11] Don't rebuild ks_tables.h if nothing changed.

es_h > mv ks_tables_h $@ > > -$(top_builddir)/src/util/makekeys$(EXEEXT): force > +$(top_builddir)/src/util/makekeys$(EXEEXT): > $(top_builddir)/src/util/makekeys.c > cd util && $(MAKE) > - > -force: > -- > 2.9.3 -- Matthieu Herrb signa

Re: 2 patches for glamor on OpenBSD (without DRI3/XSHM_FENCE)

On Fri, Sep 23, 2016 at 04:45:37PM +0300, Hans de Goede wrote: > Hi, > > On 09/23/2016 04:33 PM, Matthieu Herrb wrote: > > Hi > > > > Adam, Keith, any chance to get those 2 patches merged for 1.19 ? > > It would reduce the number of local patches I'm maintai

2 patches for glamor on OpenBSD (without DRI3/XSHM_FENCE)

there. Thanks -- Matthieu Herrb signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH xserver] Enable XTRANS_SEND_FDS on FreeBSD and DragonFly too

ase make that: - linux*|solaris*) + linux*|solaris*|freebsd*|dragonfly*|openbsd*) With that: Reviewed-by: Matthieu Herrb <matth...@herrb.eu> Thanks, -- Matthieu Herrb signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.

Re: [PATCH xserver 0/2] os: Fix write block handling in poll(2) path

ooks like the poll(2) path is working. > Tested-by: Matthieu Herrb <matth...@herrb.eu> Thanks ! -- Matthieu Herrb signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/arch

Re: [PATCH 1/2] os/connection: Call ClientReady() based on a level trigger rather than an edge trigger

ogo, emacs 24 , or the XFCE4 base desktop environment don't trigger it, but some other big applications like inkscape trigger the same issue. I've not been able to really understand the issue yet, but that's a data point. (And I'm glad to see that it doesn't seem to be an OpenBSD specific issue :) -- Matthieu Herrb pgpmGGI83FWWV.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH font/arabic-misc] Typo: font.dir -> fonts.dir

de Goede <hdego...@redhat.com> > > So Matthieu do you have xorg repo commit / push rights ? > > If not how are we going to deal with fixing this for > all these ? Yes I have access. I will push them all. -- Matthieu Herrb signature.asc Description: Digital signatur

Re: [PATCH font/arabic-misc] Typo: font.dir -> fonts.dir

On Sun, Sep 11, 2016 at 10:14:53PM +0200, Matthieu Herrb wrote: I'm stopping here sending the mails, but you've got the idea: all fonts Makefile.am share the same typo since the initial conversion to the autotools build system... ok? > Signed-off-by: Matthieu Herrb <matth...@he

[PATCH font/arabic-misc] Typo: font.dir -> fonts.dir

Signed-off-by: Matthieu Herrb <matth...@herrb.eu> --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git Makefile.am Makefile.am index af56a62..b4c89d5 100644 --- Makefile.am +++ Makefile.am @@ -39,7 +39,7 @@ EXTRA_DIST = $(BDF_FILES) uniarab.txt MAINTAINERCLEA

[PATCH font/adobe-75dpi] Typo: font.dir -> fonts.dir

Signed-off-by: Matthieu Herrb <matth...@herrb.eu> --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git Makefile.am Makefile.am index 0e891ed..a070186 100644 --- Makefile.am +++ Makefile.am @@ -257,7 +257,7 @@ MAINTAINERCLEANFILES = ChangeLog INSTALL all

[PATCH font/adobe-utopia-type1] Typo: font.dir -> fonts.dir

Signed-off-by: Matthieu Herrb <matth...@herrb.eu> --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git Makefile.am Makefile.am index d5e6407..19bc82a 100644 --- Makefile.am +++ Makefile.am @@ -39,7 +39,7 @@ MAINTAINERCLEANFILES = ChangeLog INSTALL install-dat

[PATCH font/adobe-utopia-100dpi] Typo: font.dir -> fonts.dir

Signed-off-by: Matthieu Herrb <matth...@herrb.eu> --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git Makefile.am Makefile.am index 20d60d2..a38bbdb 100644 --- Makefile.am +++ Makefile.am @@ -174,7 +174,7 @@ MAINTAINERCLEANFILES = ChangeLog INSTALL all

[PATCH font/adobe-100dpi] Typo font.dir -> fonts.dir

Signed-off-by: Matthieu Herrb <matth...@herrb.eu> --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git Makefile.am Makefile.am index 0e891ed..a070186 100644 --- Makefile.am +++ Makefile.am @@ -257,7 +257,7 @@ MAINTAINERCLEANFILES = ChangeLog INSTALL all

[PATCH font/adobe-utopia-75dpi] Typo: font.dir -> fonts.dir

Signed-off-by: Matthieu Herrb <matth...@herrb.eu> --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git Makefile.am Makefile.am index 20d60d2..a38bbdb 100644 --- Makefile.am +++ Makefile.am @@ -174,7 +174,7 @@ MAINTAINERCLEANFILES = ChangeLog INSTALL all

[PULL] Autoconfig: Fix the loop adding dectected drivers to the list of screen

to f656d643093a6cfe17b915276837227999620ed6: Autoconfig: Fix the loop adding dectected drivers to the list of screens (2016-08-01 23:16:43 +0200) Matthieu Herrb (1): Autoconfig: Fix the loop adding dectected drivers to the list of screens

[PATCH xf86-input-joystick] use xf86{Add,Remove}EnabledDevice()

Signed-off-by: Matthieu Herrb <matth...@herrb.eu> --- src/jstk.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/jstk.c b/src/jstk.c index 6cf0ef9..158d77a 100644 --- a/src/jstk.c +++ b/src/jstk.c @@ -147,7 +147,7 @@ jstkReadProc(InputInfoPtr

[PATCH v2 xserver] Autoconfig: Fix the loop adding dectected drivers to the list of screens

the driver names and the last one contains NULL. For systems that don't accept NULL for '%s' this would cause a segmentation fault when this code is used (no xorg.conf, but partial config in xorg.conf.d for instance). Signed-off-by: Matthieu Herrb <matth...@herrb.eu> --- hw/xfree86/common/

Re: [PATCH xserver] Autoconfig: Fix the loop adding dectected drivers to the list of screens

On Sat, Jul 30, 2016 at 03:39:41PM -0700, Keith Packard wrote: > Matthieu Herrb <matth...@herrb.eu> writes: > > > @@ -389,8 +389,7 @@ autoConfigDevice(GDevPtr preconf_device) > > > > /* for each other driver found,

[PATCH xserver] Autoconfig: Fix the loop adding dectected drivers to the list of screens

the driver names and the last one contains NULL. For systems that don't accept NULL for '%s' this would cause a segmentation fault when this code is used (no xorg.conf, but partial config in xorg.conf.d for instance). Signed-off-by: Matthieu Herrb <matth...@herrb.eu> --- Alan, any ide

Re: [PATCH:xdm] Remove non-existent cpp resource from man page

> Reported-by: John Smith <wemp...@gmail.com> > Signed-off-by: Alan Coopersmith <alan.coopersm...@oracle.com> Reviewed-by: Matthieu Herrb <matth...@herrb.eu> > --- > man/xdm.man | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/man/xdm.man b/man/xdm.man

Re: [PATCH:libX11] Stop checking XTRANS_SECURE_RPC_FLAGS since we no longer use them

acle.com> Reviewed-by: Matthieu Herrb <matth...@herrb.eu> > --- > configure.ac | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/configure.ac b/configure.ac > index 663abf2..20b01cd 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -87,9 +87,6 @@ m4_pat

Re: [PATCH:libX11] Stop checking for preferred order of local transports

t; Signed-off-by: Alan Coopersmith <alan.coopersm...@oracle.com> Reviewed-by: Matthieu Herrb <matth...@herrb.eu> > --- > configure.ac | 72 > > 1 file changed, 72 deletions(-) > > diff --git a/configu

[PATCH luit] Fix LNEXT handling on BSD

ICANON. That isn't a bug either; both the OpenBSD code and the rather different FreeBSD code explicitly handle it this way. IEXTEN is part of POSIX, even if the actual behavior is "implementation-defined", so I don't think it needs an ifdef. Signed-off-by: Matthieu Herrb <matth...@herrb.eu>

Re: [PATCH xdm] Missed on arc4random() conversion.

On Tue, Jan 05, 2016 at 02:49:44PM -0800, Alan Coopersmith wrote: > On 01/ 5/16 12:34 PM, Matthieu Herrb wrote: > >Signed-off-by: Matthieu Herrb <matth...@herrb.eu> > >--- > > xdm/genauth.c | 9 +++-- > > 1 file changed, 7 insertions(+), 2 deletions(-) &g

[PATCH xdm] Missed on arc4random() conversion.

Signed-off-by: Matthieu Herrb <matth...@herrb.eu> --- xdm/genauth.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git xdm/genauth.c xdm/genauth.c index 5db7315..f50be3b 100644 --- xdm/genauth.c +++ xdm/genauth.c @@ -408,15 +408,20 @@ GenerateAuthData (char *auth, i

Re: [PATCH:xf86-input-vmmouse] Update "See Also" list in vmmouse_detect man page

On Sat, Dec 05, 2015 at 04:29:38PM -0800, Alan Coopersmith wrote: > Signed-off-by: Alan Coopersmith <alan.coopersm...@oracle.com> Reviewed-by: Matthieu Herrb <matth...@herrb.eu> > --- > man/vmmouse_detect.man | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(

[patch xdm 4/4] Unifdef X_NO_SYS_UN

Nothing has set that since the modularization Signed-off-by: Matthieu Herrb <matth...@herrb.eu> --- xdm/choose.c | 5 + xdm/netaddr.c | 4 +--- xdm/prngc.c | 4 +--- xdm/socket.c | 4 +--- xdm/xdmcp.c | 4 +--- 5 files changed, 5 insertions(+), 16 deletions(-) diff --git xdm/ch

  1   2   3   4   >