On Mon, 11 Jun 2012 13:04:20 +, Lu, Hongjiu hongjiu...@intel.com wrote:
If a software checks __amd64__, it is likely that it won't compile
correctly for -mx32, no matter if -mx32 defines __amd64__ or not.
In this senses, this software is broken for -mx32. Yes, this package
needs updates
I'll just refer to 1faba79 (Death to libcwrapper., 2007-12-03).
Signed-off-by: Tomas Carnecky tomas.carne...@gmail.com
---
configure.ac |2 --
1 file changed, 2 deletions(-)
diff --git a/configure.ac b/configure.ac
index 97ceab1..d3881e4 100644
--- a/configure.ac
+++ b/configure.ac
Many years ago I wrote a small patch to generate protocol bindings from XCB.
Initially only for DPMS, it worked quite well. I've been running my xserver
with that patch since then. A few weeks ago I decided to port another
extension and that where the trouble started. I've run into big problems
whitespace cleanup is included as well (tabs vs spaces).
Signed-off-by: Tomas Carnecky tomas.carne...@gmail.com
---
hw/vfb/Makefile.am | 12
hw/xnest/Makefile.am | 10 +++---
2 files changed, 7 insertions(+), 15 deletions(-)
diff --git a/hw/vfb/Makefile.am b/hw/vfb/Makefile.am
Failing to do so makes the dist tarball unusable, compilation fails with:
xres.c:30:23: fatal error: hashtable.h: No such file or directory
Signed-off-by: Tomas Carnecky tomas.carne...@gmail.com
---
Xext/Makefile.am |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Does anyone
These two patches replace all custom inline keywords with a plain `inline`,
while still maintaining backwards compatibility through a autoconf macro.
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info:
The current code uses a mix of inline, __inline, __inline__ and _X_INLINE.
Settle on C99 inline, but add AC_C_INLINE to configure.ac to take care
of old compilers. Also remove reference to _X_INLINE in doc/c-extensions.
Signed-off-by: Tomas Carnecky tomas.carne...@gmail.com
---
Xext/security.c
But keep compatibility defines for __inline and __inline__ in case some
drivers still use those (hw/xfree86/common/compiler.h).
Signed-off-by: Tomas Carnecky tomas.carne...@gmail.com
---
hw/xfree86/common/compiler.h | 289 --
hw/xfree86/x86emu/sys.c
On 5/20/11 5:35 PM, Cyril Brulebois wrote:
-oldmaster = GetMaster(dev, MASTER_ATTACHED);
dev-master = master;
Does the GetMaster() function have any side effects?
tom
___
xorg-devel@lists.x.org: X.Org development
Archives:
On 10/11/10 10:37 PM, Adam Jackson wrote:
Move the basic sanity checking to an inline wrapper, which avoids the
function call overhead if the callback list is empty. On an XACEful
server on a 2.4GHz Core 2 Duo:
1 2 Operation
-
On 8/29/10 7:01 PM, Fernando Carrijo wrote:
Tomas Carnecky t...@dbservice.com wrote:
diff --git a/mi/miinitext.c b/mi/miinitext.c
index 5ad7a39..e6f150f 100644
--- a/mi/miinitext.c
+++ b/mi/miinitext.c
@@ -532,6 +532,12 @@ static ExtensionModule staticExtensions[] = {
#ifdef XSELINUX
Which makes it useless, so remove it.
Signed-off-by: Tomas Carnecky t...@dbservice.com
Reviewed-by: Peter Hutterer peter.hutte...@who-t.net
---
mi/miinitext.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/mi/miinitext.c b/mi/miinitext.c
index a7441c9..4499f37 100644
The change is trivial: simply move the ExtensionModule definitions from
hw/xfree/dixmods/extmod/modinit.c to mi/miinitext.c. Then also make sure
the required sources for those extensions are built into libXextbuiltin.la
instead of libXextmodule.la.
Signed-off-by: Tomas Carnecky t...@dbservice.com
It was defined to void anyway. Everyone but panoramix used INITARGS, but
PanoramiXExtensionInit() had hardcoded argc/argv. Replace that with void
as well.
Signed-off-by: Tomas Carnecky t...@dbservice.com
---
Xext/bigreq.c|4 +-
Xext/dpms.c
was initializing (DGAEventBase).
Signed-off-by: Tomas Carnecky t...@dbservice.com
---
Xext/Makefile.am | 31 +
{hw/xfree86/dixmods/extmod = Xext}/dgaproc.h|1 -
{hw/xfree86/dixmods/extmod = Xext}/xf86dga2.c |8 +-
{hw/xfree86
and the whole extmod/
directory obsolete.
Signed-off-by: Tomas Carnecky t...@dbservice.com
---
Xext/Makefile.am | 36 --
Xext/bigreq.c |1 -
Xext/dpms.c |1 -
Xext/panoramiX.c |1 -
Xext
Straightforward, move the ExtensionModule definitions into mi/miinitext.c
and make sure the required libraries are linked directly into Xorg.
Signed-off-by: Tomas Carnecky t...@dbservice.com
---
configure.ac |2 +-
hw/xfree86/common/xf86Config.c |6 -
hw/xfree86
Traces of extmod are still left in the sample xorg.conf files.
Signed-off-by: Tomas Carnecky t...@dbservice.com
---
Xext/xace.h|1 -
hw/dmx/Makefile.am |1 -
hw/xfree86/common/Makefile.am |2 +-
hw/xfree86/common/xf86Config.c |1 -
hw/xfree86/doc
There are two classes of extensions: those available in all DDX and
those only supported by the Xorg DDX. Extensions supported by all DDX
go into libXext.la. Additional extensions only available in Xorg go
into libXext-Xorg.la.
Signed-off-by: Tomas Carnecky t...@dbservice.com
---
Xext
Just one big patch for now (it's not that many changes anyway). I just don't
know how to split it up. There's one change that could easily be split up,
but other than that, it's a simple 'replace DPMS related sources in Xext/
with code from proto/ and ext/'. If you have an idea how to split this
On 8/4/10 3:39 AM, Peter Hutterer wrote:
On Sun, Aug 01, 2010 at 09:28:19PM +0200, Tomas Carnecky wrote:
The change is trivial: simply move the ExtensionModule definitions from
hw/xfree/dixmods/extmod/modinit.c to mi/miinitext.c. Then also make sure
the required sources for those extensions
On 8/4/10 3:40 AM, Peter Hutterer wrote:
the problem is that other DDXs don't have a config file and xf86FindOption
would be undefined or at least meaningless. This is the reason why all this
is split into DIX/DDX code, by moving this in - even with the ifdefs in
place you're losing this
On 8/3/10 7:27 PM, Jamey Sharp wrote:
One note on this patch:
On Sun, Aug 01, 2010 at 09:28:23PM +0200, Tomas Carnecky wrote:
-INCLUDES = -I$(top_srcdir)/hw/xfree86/dixmods/extmod @XORG_INCS@
+INCLUDES = @XORG_INCS@
Doesn't this change belong in the earlier patch that deletes the extmod
On 8/4/10 6:06 PM, Tiago Vignatti wrote:
On Tue, Aug 03, 2010 at 10:34:10PM +0200, ext Tomas Carnecky wrote:
MAIN_LIB only implements the main() method and doesn't provide anything
that other libraries would depend on. So it can go as the very first
into the set of libraries linked to each
On 8/4/10 6:28 PM, Tiago Vignatti wrote:
Hi Tomas,
On Tue, Aug 03, 2010 at 10:34:09PM +0200, ext Tomas Carnecky wrote:
The gloal of this patchset is to simplify the configure.ac script and
the makefiles, especially the definitions of variables which hold the
set of libraries linked to each
On 8/3/10 3:55 AM, Fernando Carrijo wrote:
Cc-ing Tomas
Tiago Vignatti tiago.vigna...@nokia.com wrote:
I'm looking forward now to see proto/ created, as discussed.
It seems Tomas is already working on this area. See here:
http://marc.info/?l=freedesktop-xorg-develm=128050875331099w=3
The gloal of this patchset is to simplify the configure.ac script and
the makefiles, especially the definitions of variables which hold the
set of libraries linked to each server.
There are libraries which each server has to link to, those include
the core implementation of the server (libdix.la,
but
did not expose this to clients. This may or may not have been
intentioal. With this commit Xdmx will also expose the Damage
functionality to clients.
Signed-off-by: Tomas Carnecky t...@dbservice.com
---
configure.ac | 18 +-
1 files changed, 9 insertions(+), 9 deletions(-)
diff
servers link fine when
FIXES_LIB comes before OS_LIB.
Signed-off-by: Tomas Carnecky t...@dbservice.com
---
configure.ac| 21 ++---
hw/vfb/Makefile.am |3 +--
hw/xfree86/Makefile.am |3 +--
hw/xquartz/mach-startup/Makefile.am
_DEPENDENCIES.
Signed-off-by: Tomas Carnecky t...@dbservice.com
---
configure.ac| 13 +
hw/kdrive/ephyr/Makefile.am |4 +++-
hw/kdrive/fake/Makefile.am |5 +++--
hw/kdrive/fbdev/Makefile.am |5 +++--
4 files changed, 14 insertions(+), 13 deletions(-)
diff --git
hw/xquartz/. But this change doesn't
affect xquartz because the library which calls dix_main() (libXquartz.la)
is passed before $(DARWIN_LIBS) to X11.bin.
Signed-off-by: Tomas Carnecky t...@dbservice.com
---
configure.ac| 13 ++---
hw/vfb/Makefile.am
.
DIX_CFLAGS already includes XSERVER_FLAGS.
Signed-off-by: Tomas Carnecky t...@dbservice.com
---
configure.ac |7 +--
miext/rootless/Makefile.am |2 +-
2 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/configure.ac b/configure.ac
index 786ff39..7644230 100644
Which makes it useless, so remove it.
Signed-off-by: Tomas Carnecky t...@dbservice.com
---
mi/miinitext.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/mi/miinitext.c b/mi/miinitext.c
index a7441c9..4499f37 100644
--- a/mi/miinitext.c
+++ b/mi/miinitext.c
@@ -389,9
The change is trivial: simply move the ExtensionModule definitions from
hw/xfree/dixmods/extmod/modinit.c to mi/miinitext.c. Then also make sure
the required sources for those extensions are built into libXextbuiltin.la
instead of libXextmodule.la.
Signed-off-by: Tomas Carnecky t...@dbservice.com
were not NULL, it meant that the extension is enabled and the DDX
performed the XVideo initialization. Instead of checking the pointers, use
the global variable noXvExtension.
Signed-off-by: Tomas Carnecky t...@dbservice.com
---
Xext/Makefile.am |2 +-
hw/kdrive/src/kxv.c
This short series moves extensions which used to live in extmod into
the Xext directory. Some were easy to move (simply move the ExtensionModule
defintion), some require additional source files (XF86VidMode and DGA).
I moved them all into Xext so that hw/xfree86/dixmods/extmod can be removed
There are two classes of extensions: those available in all DDX and
those only supported by the Xorg DDX. Extensions supported by all DDX
go into libXext.la. Additional extensions only available in Xorg go
into libXext-Xorg.la.
Signed-off-by: Tomas Carnecky t...@dbservice.com
---
Xext
was initializing (DGAEventBase).
Signed-off-by: Tomas Carnecky t...@dbservice.com
---
Xext/Makefile.am | 31 +
{hw/xfree86/dixmods/extmod = Xext}/dgaproc.h|1 -
{hw/xfree86/dixmods/extmod = Xext}/xf86dga2.c |8 +-
{hw/xfree86
On 7/30/10 5:22 PM, Fernando Carrijo wrote:
I probably didn't understand quite well the reason for what you guys mean by
server-side XCB. Google did't help too much either, although I wonder it might
be not far from avoiding the burden of maintaining bulky and error-prone code
by automatically
On 7/21/10 6:19 AM, Jesse Adkins wrote:
__func__ is the ISO C99 way of getting the current function name.
The xserver only depends on C89, though it does use some C99 some
extensions. The required extensions are documented in doc/c-extensions.
How about adding the dependency on __func__ to the
(including x...@lists.fdo as they also might be interested)
The DPMS extension is finally working! Whether it's correctly
implemented I can't say, but `xset +dpms; xset dpsm force off works`. I
had a couple problems integrating my part of the code with the rest of
the code. Maybe DPMS wasn't
I started looking into how to generate everything that has to do with
the wire protocol using xcb. I'm starting small, with the easier
extensions first (dpms), and I'll be gradually adding support for the
more complicated extensions as the time goes.
This mail serves as an overview of what
Same for xfree/xrealloc/xcalloc. Also, the return value from
malloc/realloc/calloc doesn't require a cast, same for the
argument of free(). Also remove if()'s that check if the
pointer that is about to be passed to free() is NULL, since
free(NULL) is allowed.
Signed-off-by: Tomas Carnecky t
Same for xfree/xrealloc/xcalloc. Also, yay for Xcalloc() taking only
one argument.
Signed-off-by: Tomas Carnecky t...@dbservice.com
---
XKBsrv.h | 14 +++---
1 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/XKBsrv.h b/XKBsrv.h
index 26a4ed8..4ab7587 100644
--- a/XKBsrv.h
On 6/16/10 9:25 PM, Matt Turner wrote:
On Wed, Jun 16, 2010 at 2:28 PM, Tomas Carneckyt...@dbservice.com wrote:
Same for xfree/xrealloc/xcalloc. Also, the return value from
malloc/realloc/calloc doesn't require a cast, same for the
argument of free(). Also remove if()'s that check if the
Replace xalloc/xfree/xrealloc/xcalloc with stdlib equivalents,
and bzero with memset.
Signed-off-by: Tomas Carnecky t...@dbservice.com
---
This is a reroll of the earlier patch, incorporating the suggestions.
I changed the subject because the patch is also changing bzero
to memset.
XKBsrv.h
On 6/1/10 4:59 PM, Tiago Vignatti wrote:
It's not PCI? So what?!
Signed-off-by: Tiago Vignattitiago.vigna...@nokia.com
---
hw/xfree86/common/xf86pciBus.c |6 --
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/hw/xfree86/common/xf86pciBus.c
On 6/1/10 8:07 PM, Vignatti Tiago (Nokia-D/Helsinki) wrote:
On Tue, Jun 01, 2010 at 06:29:28PM +0200, ext Tomas Carnecky wrote:
On 6/1/10 4:59 PM, Tiago Vignatti wrote:
It's not PCI? So what?!
Signed-off-by: Tiago Vignattitiago.vigna...@nokia.com
---
hw/xfree86/common/xf86pciBus.c |6
On 5/19/10 5:30 AM, Randy Turner wrote:
Hi All,
I am developing an application that processes the output of the X Windows Dump
(xwd) application. I'm assembling use-case scenarios for testing this app and
was wondering about how xwd actually works.
When I use xwd to dump the contents of a
On 4/29/10 8:59 AM, Keith Packard wrote:
Most of this should be fairly obvious, the one exception is probably the
'type' value. This is a fixed enumeration of all possible data
structures holding devPrivates. Let me make that a bit louder.
I AM PROPOSING TO ELIMINATE THE ABILITY TO USE THE DEV
On 4/13/10 5:01 PM, Alan Coopersmith wrote:
If the server was moved to xcb protocol definitions (like we'd all like to see
so we can stop having every extension have it's own handwritten protocol
marshalling with the same byte swapping and integer overflow bugs in each),
would we then be merging
This fixed a 'Result of operation is garbage or undefined' bug found
by clang. 'framebuffer.base' was read before being initialized.
Signed-off-by: Tomas Carnecky t...@dbservice.com
---
glx/glxdri.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/glx/glxdri.c b/glx
Since this attribute has been supported since GCC 2.5 only check the presence
of the GNU C compiler but not its version.
Signed-off-by: Tomas Carnecky t...@dbservice.com
---
Xfuncproto.h.in |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/Xfuncproto.h.in b
On Dec 7, 2009, at 10:32 PM, Brian Paul wrote:
Tomas Carnecky wrote:
During the past two days I played with the clang static analyzer. Clang is a
C/C++ compiler based on LLVM. The clang static analyzer makes use of clang
and the LLVM infrastructure to perform static analysis on C source
On Dec 8, 2009, at 1:52 AM, Tiago Vignatti wrote:
Tomas Carnecky wrote:
On Dec 7, 2009, at 10:32 PM, Brian Paul wrote:
Tomas Carnecky wrote:
During the past two days I played with the clang static analyzer. Clang is
a C/C++ compiler based on LLVM. The clang static analyzer makes use
On Dec 8, 2009, at 7:29 AM, Jamey Sharp wrote:
On Mon, Dec 7, 2009 at 9:55 PM, Tomas Carnecky t...@dbservice.com wrote:
[1] http://78.46.209.101/stuff/clang-static-analyzer/fdo/
Looking at the libX11 output: What kind of annotation do you need to
express that _XIOError can't ever return
Signed-off-by: Tomas Carnecky t...@dbservice.com
---
exa/exa_render.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/exa/exa_render.c b/exa/exa_render.c
index 1b68e1c..ae0ed26 100644
--- a/exa/exa_render.c
+++ b/exa/exa_render.c
@@ -650,7 +650,7 @@ exaTryDriverComposite
This avoids NULL from being passed to memcpy() later in the code. While
that wasn't an issue before - that value being NULL implied 'size == 0'
so memcpy() wouldn't try to dereference it - it made the code harder
to read and also confused clang.
Signed-off-by: Tomas Carnecky t...@dbservice.com
Through some code paths it is possible that NULL is being passed in the
'ed' parameter to XkbFlushLedEvents(). Make sure we don't pass it along
to bzero().
Signed-off-by: Tomas Carnecky t...@dbservice.com
---
xkb/xkbLEDs.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git
Previously the code would rely on xalloc(0) to return NULL and so in case
either width or height is zero return an error to the client. It's better
to be explicit though so add a check and return BadAlloc in that case.
Signed-off-by: Tomas Carnecky t...@dbservice.com
---
render/render.c |4
On Dec 7, 2009, at 2:14 AM, Peter Hutterer wrote:
On Sun, Dec 06, 2009 at 11:52:55PM +0100, Tomas Carnecky wrote:
Through some code paths it is possible that NULL is being passed in the
'ed' parameter to XkbFlushLedEvents(). Make sure we don't pass it along
to bzero().
Signed-off
Through some code paths it is possible that NULL is being passed in the
'ed' parameter to XkbFlushLedEvents(). Make sure we don't pass it along
to bzero().
Signed-off-by: Tomas Carnecky t...@dbservice.com
---
xkb/xkbLEDs.c | 14 --
1 files changed, 8 insertions(+), 6 deletions
On Nov 18, 2009, at 10:58 AM, Daniel Stone wrote:
On Wed, Nov 18, 2009 at 10:14:47AM +0100, Michel Dänzer wrote:
It's not
These two defines were defined in C files but not used anywhere:
dix/window.c #define DeviceEventMasks (KeyPressMask | [...]
os/connection.c #define MAXFD 500
Signed-off-by: Tomas Carnecky t...@dbservice.com
---
dix/window.c|3 ---
os/connection.c |1 -
2 files changed, 0
No traces of FID in the xserver nor in the modules listed in
util/modular/xorg.modules
Signed-off-by: Tomas Carnecky t...@dbservice.com
---
include/os.h |3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/include/os.h b/include/os.h
index df5c73a..7da31a5 100644
But keep compatibility defines for __inline and __inline__ in case
some drivers still use those (hw/xfree86/common/compiler.h).
Signed-off-by: Tomas Carnecky t...@dbservice.com
---
I think this will break drivers if you try to compile them with a compiler
that doesn't support C99 inline. Each
On Mar 17, 2009, at 6:58 PM, Adam Jackson wrote:
On Mon, 2009-03-16 at 08:42 -0700, Alan Coopersmith wrote:
The casts of function returns to (void) were typically to silence
warnings from lint and similar source checkers that you were ignoring
the return values from the function, and really
67 matches
Mail list logo
