Re: [PATCH 6/8] edid-decode: support HLG, decode luminance values

Am 07.09.2017 20:03, schrieb Hans Verkuil: > From: Hans Verkuil > > Add support for the new CTA-861-G Hybrid Log-Gamma transfer > function. > > Also decode the luminance values in the static metadata block to > cd/m^2 values. > > Signed-off-by: Hans Verkuil

Re: [PATCH 7/8] edid-decode: add HDR Dynamic Metadata Data Block

Am 07.09.2017 20:03, schrieb Hans Verkuil: > From: Hans Verkuil > > Support this CTA-861-G data block. > > Signed-off-by: Hans Verkuil > --- > edid-decode.c | 33 + > 1 file changed, 33 insertions(+) > > diff

[PATCH libICE 2/2] iceauth.c: FIX warning: unused variable 'ret' in 'arc4random_buf'

commit ff5e59f32255913bb1cdf51441b98c9107ae165b left ret outside the #if causing a gcc warnung: In function 'arc4random_buf': iceauth.c:89:13: warning: unused variable 'ret' [-Wunused-variable] fixed by moving #if 1 up Signed-off-by: Walter Harms <wha...@bfs.de> --- src/iceauth

[PATCH libICE 1/2] connect.c: FIX 'iceConn' shadows a previous local, [-Wshadow]

In function 'IceOpenConnection': gcc give the following warning: connect.c:106:11: warning: declaration of 'iceConn' shadows a previous local [-Wshadow] fixed by renaming 2. iceConn to iConn (and all its uses) Signed-off-by: Walter Harms <wha...@bfs.de> --- src/connect.

Re: [PATCH libICE 3/3] Make sure string is never NULL

Am 04.09.2017 13:00, schrieb Emil Velikov: > On 7 July 2017 at 11:23, Eric Engestrom wrote: >> `error_message` is passed in to strncpy() without any check, which >> doesn't handle NULL itself, so let's make it a valid empty string in >> cases where it was NULL. >> >

Re: [PATCH libX11 1/3] Make _XCloseLC thread safe.

hi, can you provide a simple program does needs the patch to work ? re, wh Am 10.08.2017 23:04, schrieb Jacek Caban: > Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=55678 > Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=68538 > Fixes:

Re: [PATCH v2 app/xrandr] Document that --dpi and --fbmm options set DPI of whole X screen

Sorry, i had the idea you already got my ack. Reviewed-by: Walter Harms wha...@bfs.de Am 07.08.2017 12:56, schrieb Pali Rohár: > walter, any other objections? I fixed problematic parts which you pointed. > > On Monday 24 July 2017 20:34:39 Pali Rohár wrote: >> Explicitly do

Re: [PATCH xserver] composite: Make compIsAlternateVisual safe even if Composite is off

Am 27.07.2017 22:02, schrieb Adam Jackson: > As of ea483af9 we're calling this unconditionally from the GLX code so > the synthetic visual is in a lower select group. If Composite has been > disabled then GetCompScreen() will return NULL, and this would crash. > > Rather than force the caller

Re: [PATCH app/xrandr] Document that --dpi and --fbmm options set DPI of whole X screen

documentation is a painful job, thx for doing this. re, wh Am 28.05.2017 23:33, schrieb Pali Rohár: > Explicitly document and make it clear that those options does not change > DPI of some monitor output. Also state that these options have no useful > meaning for multi-monitor configuration. >

Re: Stabilizing Xdmx -- advice

Am 23.06.2017 19:50, schrieb Joshua Marshall: > Hello all, > > Xdmx is giving me a fair bit of trouble. In particular regard to > segfaulting. Now, I'm assuming all the easy to catch stuff is already > done, so where in general should I give attention to improving the state of > Xdmx? > >

Re: [xproto] _X_NONNULL and C++ 11

Am 27.05.2017 14:10, schrieb Mark Kettenis: >> Date: Sat, 27 May 2017 13:33:25 +0200 >> From: walter harms <wha...@bfs.de> >> >> Am 27.05.2017 11:02, schrieb Matthieu Herrb: >>> Hi, >>> >>> Marc Espie recently found out that the X_NONNULL

Re: [xproto] _X_NONNULL and C++ 11

Am 27.05.2017 11:02, schrieb Matthieu Herrb: > Hi, > > Marc Espie recently found out that the X_NONNULL macro in Xfuncproto.h > is generating spurious warnings when included in C++ code build with > clang++ -std=c++11. > > Other OpenBSD developper tried to find uses of the macro in the wild >

Re: [PATCH xrandr 2/2] xrandr: stricter --scale argument parsing

Am 17.05.2017 18:30, schrieb Giuseppe Bilotta: > We used to accept something like --scale 2x3junk as a valid input > (scaling x by 2 and y by 3), even though this isn't really a valid > scaling factor. > > Fix by making sure there is nothing after the parsed number(s). > > Signed-off-by:

Re: [PATCH xserver] xfree86: up the path name size to 512 in xf86MatchDriverFromFiles

if i remember correctly asprint() was added last year. Would that be an option ? re, wh Am 05.05.2017 01:06, schrieb Peter Hutterer: > ./hw/xfree86/common/xf86pciBus.c: In function ‘xf86MatchDriverFromFiles’: > ./hw/xfree86/common/xf86pciBus.c:1330:52: warning: ‘snprintf’ output may be >

Re: [PATCH xserver 2/2] Remove default defines of some directories.

Am 24.04.2017 22:19, schrieb Eric Anholt: > The build defines these, so having the defaults is just a way for the > build system's configuration to get out of sync with the code. > > v2: Drop #ifndefs around the other two defines. > > Signed-off-by: Eric Anholt > --- >

Re: [PATCH libXdmcp] Use getrandom() syscall if available

Am 03.04.2017 17:30, schrieb Benjamin Tissoires: > On Mon, Apr 3, 2017 at 3:17 PM, walter harms <wha...@bfs.de> wrote: >> >> >> Am 03.04.2017 14:52, schrieb Benjamin Tissoires: >>> This allows to fix CVE-2017-2625 on Linux platforms without pulling in &

Re: [PATCH libXdmcp] Use getrandom() syscall if available

Am 03.04.2017 14:52, schrieb Benjamin Tissoires: > This allows to fix CVE-2017-2625 on Linux platforms without pulling in > libbsd. > The syscall getrandom is available since kernel v3.17. The code first > tries to use the syscall on a supported kernel. If the syscall fails, > it falls back to

Re: [PATCH xserver] dix: Don't leak swapped events

Am 28.03.2017 19:42, schrieb Adam Jackson: > The original code here is silly. Just allocate an event on the stack and > swap into that instead of forcing an ever-growing array into the heap. > > Signed-off-by: Adam Jackson > --- > dix/events.c | 23 +-- >

Re: [PATCH v2 xserver 1/3] xfree86: Silence always true condition warning.

looks nice Reviewed-by: wha...@bfs.de Am 27.03.2017 17:36, schrieb Michal Srb: > xf86pciBus.c:1464:21: warning: comparison of constant 256 with expression of > type 'uint8_t' (aka 'unsigned char') is always true > [-Wtautological-constant-out-of-range-compare] > if (pVideo->bus < 256) > >

Re: [PATCH xserver 1/3] xfree86: Silence always true condition warning.

Am 27.03.2017 14:03, schrieb m...@suse.com: > From: Michal Srb > > xf86pciBus.c:1464:21: warning: comparison of constant 256 with expression of > type 'uint8_t' (aka 'unsigned char') is always true > [-Wtautological-constant-out-of-range-compare] > if (pVideo->bus < 256) >

Re: [PATCH rendercheck 0/5] Convert to meson.

Am 24.03.2017 22:13, schrieb Mark Kettenis: >> From: Eric Anholt >> Date: Fri, 24 Mar 2017 13:17:45 -0700 >> >> Having bitten off a bit more than I can chew in 3 days with the X >> Server (hw/xfree86/sdksyms.c is the worst), I decided to take a quick >> pass at converting a

Re: [PATCH] dmx: Fix null pointer dereference

Am 12.03.2017 14:21, schrieb Tobias Stoeckmann: > A null pointer dereference can occur in dmxSync, because TimerForce > does not handle a null pointer. > > dmxSyncTimer is set to NULL a few lines above on a certain condition, > which happened on my machine. The explicit NULL check allowed me to

Re: [PATCH xf86-input-libinput 1/3] Add streq() macro, replace strcmp instances with it

Am 24.02.2017 15:13, schrieb Eric Engestrom: > On Friday, 2017-02-24 13:10:17 +1000, Peter Hutterer wrote: >> And why isn't this a thing in glibc yet > > Indeed :( > So many bugs caused by someone assuming `if (strcmp(a, b))` means a==b... > >> >> Signed-off-by: Peter Hutterer

Re: [RFC xserver] os: log a bug whenever WriteToClient is called from the input thread

Am 23.02.2017 17:16, schrieb Olivier Fourdan: > Hi, > >>> +extern inline int >>> +in_input_thread(void); >>> + >> >> maybe i am old fashion but this should be done with input.h, should it ? > > No, I don't think this is possible (in the middle of a stable release) nor > even suitable, it's

Re: [RFC xserver] os: log a bug whenever WriteToClient is called from the input thread

Am 23.02.2017 01:22, schrieb Peter Hutterer: > The input thread should generate events, not send them. Make it easier to > find the instances where it's doing so. > > Signed-off-by: Peter Hutterer > --- > include/input.h | 1 + > os/inputthread.c | 7 +++ >

Re: (timeout in ms vs. XSyncValueSubtract) Frozen client, found cause, need advise for fix

Am 21.02.2017 20:28, schrieb Mihail Konev: > On Tue, Feb 21, 2017 at 05:48:19PM +0100, walter harms wrote: >>> >> >> XSyncValueSubtract is doing as expected, >> XSyncValue is the simulation of 64bitvalues on 32bit. >> see this in hex: >> 1000

Re: (timeout in ms vs. XSyncValueSubtract) Frozen client, found cause, need advise for fix

Am 20.02.2017 10:55, schrieb Daniel Martin: > Hi everyone, > > I've got a Qt5 client, which receives mouse input only and freezes > soon and often. It gets stuck waiting for a reply from the server. > Pressing a none-modifier key releases the lock and the client > continues as normal until the

Re: [PATCH xim] Send screen number

Am 17.02.2017 04:33, schrieb Takao Fujiwara: > Hi, > I'm a maintainer of IBus which is an input method framework. > Xorg ZaphodHeads environment provides the multiple screens. > I think currently XIM protocol does not send the $DISPLAY information in > the client applications to the XIM server

Re: [PATCH edid-decode v2 1/2] Make do_checksum reusable for DisplayID checksums.

look good for me. Reviewed-by: wha...@bfs.de Am 06.02.2017 14:51, schrieb Mark Ferry: > DisplayID, unlike EDID and CEA, is a variable length structure. > Allow for reuse of do_checksum by adding a length parameter. > > Return a boolean to allow the caller to record failure. > --- >

Re: [PATCH edid-decode v2 2/2] Report broken CEA and DisplayID checksums.

look good for me. Reviewed-by: wha...@bfs.de Am 06.02.2017 14:51, schrieb Mark Ferry: > --- > edid-decode.c | 21 ++--- > 1 file changed, 18 insertions(+), 3 deletions(-) > > diff --git a/edid-decode.c b/edid-decode.c > index 15660dc..95e9c96 100644 > --- a/edid-decode.c > +++

Re: libx11: Issues with Data32/_XData32

Am 24.01.2017 09:18, schrieb Julien Cristau: > On Tue, Jan 24, 2017 at 01:12:23 +, James Clarke wrote: > >> Hi, >> I've been debugging an issue in gtk2-perl causing it to SIGBUS on >> sparc64, and traced it back to what seems to be dodgy code inside >> libx11. One of the tests calls

Re: [PATCH libdrm v3 2/5] xf86drm: Add USB support

Am 19.01.2017 11:20, schrieb Thierry Reding: > Adding back dri-de...@lists.freedesktop.org > > On Wed, Jan 18, 2017 at 12:21:23PM +0100, walter harms wrote: >> >> >> Am 18.01.2017 10:02, schrieb Thierry Reding: >>> Allow DRM/KMS devices hosted on

Re: [PATCH libdrm v3 3/5] xf86drm: Add platform and host1x bus support

Am 19.01.2017 11:25, schrieb Thierry Reding: > Adding back dri-de...@lists.freedesktop.org > > On Wed, Jan 18, 2017 at 04:00:20PM +0100, walter harms wrote: >> Am 18.01.2017 10:02, schrieb Thierry Reding: > [...] >>> diff --git a/xf86drm.c b/xf86drm.c > [...] >

Re: [PATCH libdrm v3 2/5] xf86drm: Add USB support

Am 18.01.2017 10:02, schrieb Thierry Reding: > Allow DRM/KMS devices hosted on USB to be detected by the drmDevice > infrastructure. > > v3: > - guard Linux-specific sysfs parsing code with #ifdef __linux__ > > v2: > - make sysfs_uevent_get() more flexible using a format string > >

Re: [PATCH:xdm] Install xdm man pages under admin section (8), not user programs (1)

Am 17.01.2017 01:26, schrieb Alan Coopersmith: > As best I can tell, it was historically under section 1 mainly because > the old X Consortium Imake configs only supporting installing program > man pages there, and didn't have an option for using other sections. > > Signed-off-by: Alan

Re: [edid-decode] [PATCH 2/2] Calculate DisplayID checksums. Refactor do_checksum.

Am 13.12.2016 11:39, schrieb Mark Ferry: > Thanks for the feedback Walter. Comments below. > > On Mon, 12 Dec 2016 20:02:08 +0100, walter harms wrote: >> >> >> Am 10.12.2016 20:44, schrieb Mark Ferry: >>> +printf("Checksum: 0x%hx", x[l

Re: [edid-decode] [PATCH 2/2] Calculate DisplayID checksums. Refactor do_checksum.

Am 10.12.2016 20:44, schrieb Mark Ferry: > --- > edid-decode.c | 40 +--- > 1 file changed, 25 insertions(+), 15 deletions(-) > > diff --git a/edid-decode.c b/edid-decode.c > index c18697f..6df2b6e 100644 > --- a/edid-decode.c > +++ b/edid-decode.c > @@

patchwork.freedesktop.org Re: [xserver PULL master] randr fixes + primary GPU fallback

Am 05.12.2016 11:39, schrieb Hans de Goede: > Hi Adam, Keith, > > > > p.s. > > Talking about unreviewed patched it would be really good to get > a review of / some discussion on: > > https://patchwork.freedesktop.org/patch/112579/ > > Which is the last magic sauce in the Fedora xserver

Re: [PATCH app/setxkbmap] Add $HOME/.xkb to default search path

Am 17.11.2016 03:39, schrieb Mihail Konev: > Signed-off-by: Mihail Konev > BugLink: https://github.com/xkbcommon/libxkbcommon/issues/40 > --- > setxkbmap.c | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/setxkbmap.c b/setxkbmap.c > index

Re: [PATCH xserver] Fix a segfault that occurs if xorg.conf.d is absent:

Am 15.11.2016 22:34, schrieb Ben Crocker: > In InitOutput, if xf86HandleConfigFile returns CONFIG_NOFILE > (which it does if no config file or directory is present), the > autoconfig flag is set, causing xf86AutoConfig to be called > later on. > > xf86AutoConfig calls xf86OutputClassDriverList

Re: [PATCH v2 xserver] xkb: fix releasing overlay while keydown

Am 05.11.2016 20:03, schrieb Mihail Konev: > The overlay_keys array could be avoided. > > Testcase: > > // In the exact order: > // - press Insert > // - press Tilde > // - release Insert > // - wait > // - release Tilde > // > // Keyboard input would be locked. > > xkb_keymap { >

Re: [PATCH xts] Don't sleep(2) at the beginning of Xt test setup

Am 02.11.2016 15:09, schrieb Adam Jackson: > Regeneration is fast enough these days, we can skip this. This > eliminates about 40 minutes of wall time from a full xts run. > > Signed-off-by: Adam Jackson > --- > xts5/src/libXtTest/avs_init.c | 7 --- > 1 file changed, 7

Re: [PATCH xts 2/3] xts5: Fix missing variable for format specifier

Am 29.10.2016 05:37, schrieb Rhys Kidd: > XtRemoveEventHandler.c:458:3: warning: format '%d' expects a matching 'int' > argument [-Wformat=] >sprintf(ebuf, "ERROR: Error message handler was invoked %d times"); >^ > XtRemoveEventHandler.c:463:3: warning: format '%d' expects a matching

Re: [PATCH libxi 2/2] Check that allocating a buffer succeeded

looks good to me. Signed-off-by: wha...@bfs.de Am 25.10.2016 21:31, schrieb Emilio Pozuelo Monfort: > Since we are going to write into the buffer, we should make sure the > allocation didn't fail. > > Reported-by: Julien Cristau > Signed-off-by: Emilio Pozuelo Monfort

Re: [PATCH] ramdac: Check sPriv != NULL in xf86CheckHWCursor()

Am 25.10.2016 00:25, schrieb Alex Goins: > xf86CheckHWCursor() would dereference sPriv without NULL checking it. If > Option > "SWCursor" is specified, sPriv == NULL. In this case we should assume that HW > cursors are not supported. > > Signed-off-by: Alex Goins >

Re: [PATCH] Handle animated cursor on shared sprite

Am 12.10.2016 11:05, schrieb Pierre Ossman: > Sprites (and hence cursors) can be shared between multiple devices. > However the animation code was not prepared for this and could wind > up in a case where it would continue to animate a free:d cursor. > --- > include/inputstr.h | 14 - >

Re: [PATCH xserver] os/xdmcp: Honour -once when session is dead

looks good to me (and hope that helps) reviewed-by: wharms re, wh Am 30.09.2016 14:05, schrieb Daniel Martin: > Terminate a dead session when -once was passed. Don't restart it. > > Signed-off-by: Daniel Martin > --- > os/xdmcp.c | 2 +- > 1 file

Re: [PATCH libXi] SizeClassInfo can return 0 even without an error

Am 10.10.2016 12:24, schrieb Emil Velikov: > On 9 October 2016 at 21:31, Niels Ole Salscheider > wrote: >> Hi Emil, >> >> On Sunday, 9 October 2016, 15:34:28 CEST, Emil Velikov wrote: >>> Hi Niels, >>> >>> On Friday, 7 October 2016, Niels Ole Salscheider < >>>

PATCH bitmap-1.0.8:fix num_lock bug

hello list, same time ago the user Frederic Baldit complained (on xorg) that the ability to set single dots in the programm Bitmap depend on the state of num_lock. This is a long standing bug that affect all versions of bitmap. the problem was that the corresponding function was erroneously

Re: [PATCH libX11] XFree will accept NULL as argument

Am 26.08.2016 11:08, schrieb Hans de Goede: > Hi, > > On 15-08-16 19:18, walter harms wrote: >> since Xfree is a define for free() >> Xlibint.h:#define Xfree(ptr) free((ptr)) >> >> Xfree will accept NULL and do nothing. >> >> the patch is also

Re: [PATCH xserver] Fix Xorg -configure not working anymore

Am 17.08.2016 17:13, schrieb Adam Jackson: > On Wed, 2016-08-17 at 08:03 -0700, Keith Packard wrote: >>> Adam Jackson writes: >> >>> Perhaps we'd want to move to a model where xorg.conf.d comes pre- >>> populated with the default settings (possibly just commented out). If >>>

Re: [PATCH libX11] XFree will accept NULL as argument

Am 16.08.2016 13:10, schrieb Eric Engestrom: > On Tue, Aug 16, 2016 at 11:56:50AM +0100, Eric Engestrom wrote: >> On Mon, Aug 15, 2016 at 07:18:14PM +0200, walter harms wrote: >>> since Xfree is a define for free() >>> Xlibint.h:#define Xfree(ptr) free((ptr)) >

[PATCH libX11] XFree will accept NULL as argument

since Xfree is a define for free() Xlibint.h:#define Xfree(ptr) free((ptr)) Xfree will accept NULL and do nothing. the patch is also available on github.com/xtforever/libX11.git --- man/XFree.man | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/man/XFree.man

Re: [PATCH xserver v2] glamor: Handle bitplane in glamor_copy_fbo_cpu

Am 15.08.2016 11:43, schrieb Michel Dänzer: > From: Michel Dänzer > > This can significantly speed up at least some CopyPlane cases, e.g. > indirectly for stippled fills. > > v2: > * Make temporary pixmap the same size as the destination pixmap > (instead of the

Re: [PATCH libXrandr 1/2] fix: doGetScreenResources() info: redundant null check on calling free()

Am 15.08.2016 09:03, schrieb Hans de Goede: > Hi, > > On 13-08-16 19:53, Hans de Goede wrote: >> Hi, >> >> On 12-08-16 18:10, walter harms wrote: >>> >>> >>> Am 12.08.2016 16:36, schrieb Hans de Goede: >>>> Hi, >>>>

Re: [PATCH libXrandr 1/2] fix: doGetScreenResources() info: redundant null check on calling free()

Am 12.08.2016 16:36, schrieb Hans de Goede: > Hi, > > On 12-08-16 16:09, walter harms wrote: >> >> >> Am 12.08.2016 12:11, schrieb Hans de Goede: >>> Hi, >>> >>> On 28-07-16 19:31, walter harms wrote: >>>> >>>> jani

Re: [PATCH libXrandr 1/2] fix: doGetScreenResources() info: redundant null check on calling free()

Am 12.08.2016 12:11, schrieb Hans de Goede: > Hi, > > On 28-07-16 19:31, walter harms wrote: >> >> janitorial patch: remove some unneeded if() before free() > > This is not free() but Xfree() and "man Xfree" states: > > "A NULL pointer canno

Re: [PATCH xserver 1/3] xfree86/modes: Move gamma initialization to xf86RandR12Init12 v2

Am 28.07.2016 19:11, schrieb Keith Packard: > walter harms <wha...@bfs.de> writes: > >> 1. I do not want to start an argument here. > > Your comments are welcome and helpful. > >> but i seems i need to explain what i wanted to say: >> "b and c do

[PATCH libXrandr 2/2] fix: redundant null check on calling free()

janitorial patch: remove some unneeded if() before free() --- src/XrrMonitor.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/XrrMonitor.c b/src/XrrMonitor.c index 71d3943..f45ea04 100644 --- a/src/XrrMonitor.c +++ b/src/XrrMonitor.c @@ -84,8 +84,8 @@

[PATCH libXrandr 1/2] fix: doGetScreenResources() info: redundant null check on calling free()

janitorial patch: remove some unneeded if() before free() --- src/XrrScreen.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/XrrScreen.c b/src/XrrScreen.c index f29071c..b8ce7e5 100644 --- a/src/XrrScreen.c +++ b/src/XrrScreen.c @@ -127,8 +127,8 @@

Re: [PATCH xserver 1/3] xfree86/modes: Move gamma initialization to xf86RandR12Init12 v2

>>> output->crtc = NULL; >>> diff --git a/hw/xfree86/modes/xf86RandR12.c b/hw/xfree86/modes/xf86RandR12.c >>> index 9f93270..5b24ebb 100644 >>> --- a/hw/xfree86/modes/xf86RandR12.c >>> +++ b/hw/xfree86/modes/xf86RandR12.c >>> @@ -1313,6 +1313,116 @@ xf86RandR12CrtcGetGamma(ScreenPtr

Re: [PATCH xserver 1/3] xfree86/modes: Move gamma initialization to xf86RandR12Init12 v2

Am 27.07.2016 04:39, schrieb Michel Dänzer: > On 26.07.2016 23:25, walter harms wrote: >> Am 26.07.2016 11:11, schrieb Michel Dänzer: >>> >>> diff --git a/hw/xfree86/modes/xf86RandR12.c b/hw/xfree86/modes/xf86RandR12.c >>> index 9f93270..5b24ebb 100644 >

Re: [PATCH xserver 1/3] xfree86/modes: Move gamma initialization to xf86RandR12Init12 v2

Am 26.07.2016 11:11, schrieb Michel Dänzer: > From: Michel Dänzer > > RRCrtcGammaSetSize cannot be used yet in xf86InitialConfiguration, > because randr_crtc isn't allocated yet at that point, but a following > change will require RRCrtcGammaSetSize to be called from >

Re: [PATCH xserver] modesetting: resubmit dirty rects on EINVAL

Am 15.07.2016 17:28, schrieb Adam Jackson: > This error code can mean we're submitting more rects at once than the > driver can handle. If that happens, resubmit one at a time. > > Signed-off-by: Adam Jackson > --- > hw/xfree86/drivers/modesetting/driver.c | 11 +++ >

Re: [PATCH edid-decode 7/9] Print video format preference data block

>> >>> + >>> + if (index < ARRAY_SIZE(edid_cea_modes)) >>> + mode = edid_cea_modes[vic]; >>> + else >>> + mode = "Unknown mode"; >>> + >>> + printf("VIC %02d %s\n", vic, mode); >>> + >>> + } else if (svr > 128 && svr < 145) { >>> +

Re: [PATCH edid-decode 7/9] Print video format preference data block

Am 08.07.2016 16:09, schrieb Arnaud Vrac: > From: Arnaud Vrac > > This only prints VIC codes, not DTD. > --- > edid-decode.c | 31 +++ > 1 file changed, 31 insertions(+) > > diff --git a/edid-decode.c b/edid-decode.c > index cd5a257..2e367b3

Re: [PATCH edid-decode 8/9] Print HDR static metadata block

Am 08.07.2016 18:39, schrieb Arnaud Vrac: > On Fri, Jul 8, 2016 at 4:56 PM, walter harms <wha...@bfs.de> wrote: >> >> >> Am 08.07.2016 16:09, schrieb Arnaud Vrac: >>> From: Arnaud Vrac <av...@freebox.fr> >>> >>> --- >>>

Re: [PATCH edid-decode 8/9] Print HDR static metadata block

Am 08.07.2016 16:09, schrieb Arnaud Vrac: > From: Arnaud Vrac > > --- > edid-decode.c | 38 ++ > 1 file changed, 38 insertions(+) > > diff --git a/edid-decode.c b/edid-decode.c > index 2e367b3..c18697f 100644 > --- a/edid-decode.c > +++

Re: [PATCH xserver] xephyr: Don't crash if the server advertises zero xv adaptors

Am 05.07.2016 19:07, schrieb Adam Jackson: > Useless as an XVideo implementation with zero adaptors might be, it's > apparently a thing in the wild. Catch this case and bail out of xv init > if it happens. > > Signed-off-by: Adam Jackson > --- > hw/kdrive/ephyr/ephyrvideo.c |

Re: [PATCH xserver 3/4] os: Use strtok instead of xstrtokenize in ComputeLocalClient

Am 05.06.2016 05:27, schrieb Keith Packard: > From: Michel Dänzer > > Fixes leaking the memory pointed to by the members of the array returned > by xstrtokenize. > > Reviewed-by: Adam Jackson > --- > os/access.c | 9 + > 1 file changed, 5

[PATCH libX11 1/4] Bunch of cleanup Patches

this a a further batch of cleanup patches for libX11. the git repository can be found at https://github.com/xtforever/libX11 This repository contains also the other cleanup patches that were send to the list in the last months. Signed-off-by: harms wha...@bfs.de ---

[PATCH libX11 2/4] mark _XDefaultIOError as no_return

mark _XDefaultIOError as no_return. No one comes back from exit() ... Signed-off-by: harms wha...@bfs.de --- src/XlibInt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/XlibInt.c b/src/XlibInt.c index 7296948..86ae1d9 100644 --- a/src/XlibInt.c +++ b/src/XlibInt.c @@

[PATCH libX11 4/4] no need to check XFree arguments

You can save a bit of code. The is no need to check XFree arguments bring free_fontdataOM in line with other free function and check for NULL arg Signed-off-by: harms wha...@bfs.de --- modules/om/generic/omGeneric.c | 32 ++-- 1 file changed, 10 insertions(+), 22

[PATCH libX11 3/4] Fixes: warning: variable 'req' set but not,used

Fixes: warning: variable 'req' set but not used [-Wunused-but-set-variable] by marking req _X_UNUSED Solution was discussed on xorg-devel ML Peter Hutter, Alan Coopersmith Re: [PATCH libX11 3/5] fix: warning: pointer targets in passing argument 2 of '_XSend' differ

Re: [PATCH libX11 3/5] fix: warning: pointer targets in passing argument 2 of '_XSend' differ in signedness [-Wpointer-sign]

Am 29.04.2016 03:03, schrieb Alan Coopersmith: > On 04/28/16 04:43 PM, Peter Hutterer wrote: >> fixing this isn't going to do much, and adding fake statements neither. >> to fix the compiler warnings you could do something like: >> >> #define _xlib_used_internally __attribute__((unused)) >> >>

Re: [PATCH libX11 3/5] fix: warning: pointer targets in passing argument 2 of '_XSend' differ in signedness [-Wpointer-sign]

Am 27.04.2016 07:04, schrieb Alan Coopersmith: > On 04/26/16 07:31 AM, walter harms wrote: >> >> fix signess warning by casting >> Signed-off-by: walter harms <wha...@bfs.de> >> >> >> --- >> src/ModMap.c | 4 ++-- >> 1 file change

[PATCH libX11 4/5 V2] fix memleak in error path

V2: remove unneeded NULL (reported by eric.engest...@imgtec.com) fix mem leak in error path Signed-off-by: walter harms <wha...@bfs.de> --- src/xlibi18n/lcPublic.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/xlibi18n/lcPublic.c b/src/xlibi18n/lcPublic.c index 98a7435..f

Re: [PATCH libX11 4/5] fix memleak in error path

Am 26.04.2016 16:47, schrieb Eric Engestrom: > On Tue, Apr 26, 2016 at 04:29:41PM +0200, walter harms wrote: >> >> >> free all memory on error >> >> Signed-off-by: walter harms <wha...@bfs.de> >> >> >> --- >> src/xlibi18n/lcP

[PATCH libX11 4/5] fix memleak in error path

free all memory on error Signed-off-by: walter harms <wha...@bfs.de> --- src/xlibi18n/lcPublic.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/xlibi18n/lcPublic.c b/src/xlibi18n/lcPublic.c index 98a7435..08122b9 100644 --- a/src/xlibi18n/lcPublic.c +++

[PATCH libX11 2/5] no need to check args for Xfree()

simplify code Signed-off-by: walter harms <wha...@bfs.de> --- src/xlibi18n/lcGeneric.c | 74 +--- 1 file changed, 33 insertions(+), 41 deletions(-) diff --git a/src/xlibi18n/lcGeneric.c b/src/xlibi18n/lcGeneric.c index 69090f7..9a599c5

[PATCH libX11 5/5] fix memleak in error path

free all mem on error Signed-off-by: walter harms <wha...@bfs.de> --- src/xlibi18n/lcGeneric.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/xlibi18n/lcGeneric.c b/src/xlibi18n/lcGeneric.c index 1c78a95..69090f7 100644 --- a/src/xlibi18n/lcGeneric.c +++ b/src/xlibi18n/lcGen

[PATCH libX11 3/5] fix: warning: pointer targets in passing argument 2 of '_XSend' differ in signedness [-Wpointer-sign]

fix signess warning by casting Signed-off-by: walter harms <wha...@bfs.de> --- src/ModMap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ModMap.c b/src/ModMap.c index a809aa2..4263a8b 100644 --- a/src/ModMap.c +++ b/src/ModMap.c @@ -39,7

[PATCH libX11 1/5] remove stray extern

remove stray extern Signed-off-by: walter harms <wha...@bfs.de> --- src/xkb/XKBExtDev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/xkb/XKBExtDev.c b/src/xkb/XKBExtDev.c index b9710f8..d45460e 100644 --- a/src/xkb/XKBExtDev.c +++ b/src/xkb/XKBExtDev.c @@ -36,7

[PATCH libX11 2/4] _XIOError(dpy); will never return so remore dead code

remove dead code _XIOError(dpy); will never return and the return never reached Signed-off-by: walter harms <wha...@bfs.de> --- src/xcb_io.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/xcb_io.c b/src/xcb_io.c index bd26a62..4826621 100644 --- a/src/xcb_io.c

[PATCH libX11 1/3] fix more shadow warning

Signed-off-by: walter harms <wha...@bfs.de> --- fix an other shadow warning by renaming the var --- modules/im/ximcp/imCallbk.c | 6 +++--- modules/im/ximcp/imLcLkup.c | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/modules/im/ximcp/imCallbk.c b/modules/im

Re: [PATCH xserver v2 7/9] xfree86: Remove a never-hit diagnostic message

edidSize() checks for if (DDC->ver.version != 1) (see 6/9) so this is bogus either ? re, wh Am 05.04.2016 19:54, schrieb Adam Jackson: > Practically speaking, the EDID major version is never not 1. > > Signed-off-by: Adam Jackson > --- > hw/xfree86/ddc/ddcProperty.c | 15

Re: [PATCH xserver v2 6/9] xfree86: Make xf86SetDDCproperties work more than once per generation

Am 05.04.2016 19:54, schrieb Adam Jackson: > We can call this more than once via xf86OutputSetEDID since hotplug is > actually a thing in RANDR 1.2, but xf86RegisterRootWindowProperty merely > adds the data to a list to be applied to the root at CreateWindow time, > so calls past the first (for

Re: [PATCH xserver v2 3/9] xfree86: Create VT atoms from the root window callback (v2)

Am 05.04.2016 19:54, schrieb Adam Jackson: > v2: Fix swapped callback args > > Signed-off-by: Adam Jackson > --- > hw/xfree86/common/xf86Init.c | 67 > +--- > 1 file changed, 25 insertions(+), 42 deletions(-) > > diff --git

[PATCH libX11 0/4] various fixes

hi list, This fixes a bunch of bugs inside libX11. I did some experiments with smatch https://blogs.oracle.com/linuxkernel/entry/smatch_static_analysis_tool_overview It found some more but all of them are fixed easily. These patches will not change the function of the current code In case of

[PATCH libX11 4/4] fix shadow char_size

Signed-off-by: walter harms <wha...@bfs.de> --- fix shadow warning by renaming the var --- src/xlibi18n/lcCT.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/xlibi18n/lcCT.c b/src/xlibi18n/lcCT.c index b161300..1f413e9 100644 --- a/src/xlibi18n/lcCT.c

[PATCH libX11 3/4] remove argument check for free() adjust one inden

Signed-off-by: walter harms <wha...@bfs.de> --- there is no need to check the argument for free() --- modules/im/ximcp/imDefIc.c | 57 +++--- 1 file changed, 28 insertions(+), 29 deletions(-) diff --git a/modules/im/ximcp/imDefIc.c b/modules/im

[PATCH libX11 2/4] _XIOError(dpy); will never return so remore dead

Signed-off-by: walter harms <wha...@bfs.de> --- remove dead code as _XIOError will never return --- src/xcb_io.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/xcb_io.c b/src/xcb_io.c index bd26a62..4826621 100644 --- a/src/xcb_io.c +++ b/src/xcb_io.c @@ -

[PATCH libX11 1/4] fix shadow warning

Signed-off-by: walter harms <wha...@bfs.de> --- resolve anoying shadow warning from gcc --- src/StrKeysym.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/StrKeysym.c b/src/StrKeysym.c index 12fce68..be77a93 100644 --- a/src/StrKeysym.c +++ b/src/StrKe

Re: [PATCH:makedepend] Use do { ... } while(0) idiom to make debug() macro safer

Am 12.03.2016 19:43, schrieb Matt Turner: > On Sat, Mar 12, 2016 at 10:24 AM, walter harms <wha...@bfs.de> wrote: >> >> >> Am 12.03.2016 19:15, schrieb Alan Coopersmith: >>> Cleans up several -Wempty-body warnings from gcc 5.3 >>> >>> Signed

Re: [PATCH:makedepend] Use do { ... } while(0) idiom to make debug() macro safer

Am 12.03.2016 19:15, schrieb Alan Coopersmith: > Cleans up several -Wempty-body warnings from gcc 5.3 > > Signed-off-by: Alan Coopersmith > --- > def.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/def.h b/def.h > index

Re: [PATCH xserver 1/9] xvmc: Fix unchecked AddResource

Am 07.03.2016 23:20, schrieb Julien Cristau: > Signed-off-by: Julien Cristau > --- > Xext/xvmc.c | 17 ++--- > 1 file changed, 14 insertions(+), 3 deletions(-) > > diff --git a/Xext/xvmc.c b/Xext/xvmc.c > index 64eda92..7565c17 100644 > --- a/Xext/xvmc.c > +++

Re: [PATCH] Allows holding down two keys to repeat both ("Two-key repeat")

Am 29.02.2016 23:59, schrieb thomassross: > From: Germain Bossu > > https://git.framasoft.org/bobo/xkb_repeat/blob/master/patches/xkb-repeat2-easy.patch > --- > include/xkbsrv.h | 1 + > xkb/xkbAccessX.c | 9 + > 2 files changed, 10 insertions(+) > > diff --git

Re: Contribute.

Am 19.12.2015 01:00, schrieb Edi Anderson: > Hi guys, I'm a programmer and would like to contribute to the project but > do not know where to start. Could anyone help me ?. > > Hi and welcome to the project, to make thinks clear i am also a beginner, i wanted to start last year but i got

Re: [PATCH xf86-input-libinput] Drain the fd after opening

Am 16.12.2015 01:15, schrieb Peter Hutterer: > Make sure we discard any events that may have been enqueued before we > re-opened the fd. Specifically, if we're using systemd-logind the fd remains > open when we disable/enable the device, allowing events to queue up on the > fd. These events are

Re: [PATCH] os: Treat ssh as a non-local client

Am 08.12.2015 19:55, schrieb Adam Jackson: > By the time we get to ComputeLocalClient, we've already done > NextAvailableClient → ReserveClientIds → DetermineClientCmd (assuming > we're built with #define CLIENTIDS), so we can look up the name of the > client process and refuse to treat ssh's X

<    1   2   3   4   5   6   >