Re: [PATCH] xauth: improve to handle FamilyWild necessary for GDM/XDMCP/SSH. #43425

2011-12-19 Thread walter harms
Am 19.12.2011 10:23, schrieb Dr. Tilmann Bubeck: Hello xorg, I sent you the mail below a few days ago with a patch for xauth. According to http://www.x.org/wiki/Development/Documentation/SubmittingPatches I am now pinging the list again. I do not know any maintainer to CC, so I only

Re: [PATCH 06/42] tests: update for touch support

2011-12-16 Thread walter harms
Am 15.12.2011 04:01, schrieb Peter Hutterer: Touch event mask must be set for all three event types. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- test/xi2/protocol-xipassivegrabdevice.c |2 +- test/xi2/protocol-xiselectevents.c | 38 --

Re: [PATCH 10/42] Xi: process raw touch events

2011-12-16 Thread walter harms
Am 15.12.2011 04:01, schrieb Peter Hutterer: No-one can generated them yet, but if they could, we'd be processing them like there was no tomorrow. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- Xi/exevents.c |3 +++ Xi/extinit.c |3 +++ Xi/xiselectev.c

Re: [PATCH 06/42] tests: update for touch support

2011-12-16 Thread walter harms
Am 16.12.2011 12:12, schrieb Peter Hutterer: On 16/12/11 20:56 , walter harms wrote: Am 15.12.2011 04:01, schrieb Peter Hutterer: Touch event mask must be set for all three event types. Signed-off-by: Peter Huttererpeter.hutte...@who-t.net --- test/xi2/protocol-xipassivegrabdevice.c

Re: [PATCH] dix: add a MAXEVENTS define for the number of core + extension events

2011-12-11 Thread walter harms
looks good for me but not compile tested ntl Reviewed-by: wharms wha...@bfs.de Am 11.12.2011 03:55, schrieb Peter Hutterer: Not including GenericEvents Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- dix/events.c |6 +++--- dix/extension.c |3 +--

Re: [REMINDER libX11] XIM: Allow modifier releases in compose sequences (#26705)

2011-12-11 Thread walter harms
hi, i am not a XIM or XKB expert but for me the code looks reasonable. @Andreas Wettstein could you please add a line or two how to test the function ? what does not work (what keys to press) what works after the patch ? re, wh Am 10.12.2011 18:36, schrieb Alan Coopersmith: On 12/10/11

Re: [PATCH 3/5] dix: move storing last.valuators into a helper function

2011-12-10 Thread walter harms
Am 10.12.2011 08:54, schrieb Peter Hutterer: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- dix/getevents.c | 38 ++ 1 files changed, 26 insertions(+), 12 deletions(-) diff --git a/dix/getevents.c b/dix/getevents.c index bc532ca..3b3194d

Re: [PATCH 5/5] dix: move event filter retrieval helpers to inpututils.c

2011-12-10 Thread walter harms
Am 10.12.2011 08:54, schrieb Peter Hutterer: No functional changes Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- dix/events.c | 24 ++-- dix/inpututils.c | 19 +++ include/input.h |1 - include/inpututils.h |

Re: [PATCH] Add Solaris support to DetermineClientCmd

2011-12-04 Thread walter harms
hi alan, to make that more readable could you make two function DetermineClientCmd() ? something like #ifdef sun #include errno.h #include procfs.h void DetermineClientCmd(pid_t pid, const char **cmdname, const char **cmdargs) { } #else void DetermineClientCmd(pid_t pid, const char

Re: [PATCH 5/5] Add dummy return 0 to Xnest Xephyr io error handler for Sun compilers

2011-12-03 Thread walter harms
Hi, perhaps you can call it DUMMY_RETURN or so ? Other compilers may have the same idea. Otherwise ... will gcc complain ? If not something like: return 0; /* make SUNPRO C happy */ would sufficent. re, wh Am 02.12.2011 19:48, schrieb Alan Coopersmith: Required in order to build with

Re: [PATCH:xsm] Add size limit to scanf string specifier

2011-11-29 Thread walter harms
Am 29.11.2011 03:56, schrieb Alan Coopersmith: While it's tempting to just switch to fgets(), that would require implementing our own whitespace stripping to match the current scanf behavior. Fixes parfait static analysis warning: Error: Buffer overrun Buffer overflow (CWE 120): Use

Re: [PATCH] Fix segfault when there's no config dir

2011-11-28 Thread walter harms
Am 28.11.2011 17:09, schrieb przan...@gmail.com: From: Paulo Zanoni paulo.r.zan...@intel.com Also, call AddConfigDirFiles only if we found a file, protecting ourselves from future changes to the AddConfigDirFiles function. Signed-off-by: Paulo Zanoni paulo.r.zan...@intel.com ---

Re: [PATCH 1/3] InitRootWindow: Use ChangeWindowAttributes instead of duplicating it.

2011-11-20 Thread walter harms
Am 20.11.2011 12:48, schrieb Jamey Sharp: The protocol requires ChangeWindowAttributes to be able to set the root window's background and cursor to their defaults. So let's just use that when InitRootWindow needs to set up the defaults in the first place. This guarantees that using

Re: [PATCH libdri2] dri2video support

2011-11-16 Thread walter harms
Am 15.11.2011 23:49, schrieb Rob Clark: --- Makefile.am | 16 ++- include/X11/extensions/dri2.h | 52 +++- src/Makefile.am |2 +- src/dri2.c| 324 - test/Makefile.am |

Re: [PATCH] Save major/minor opcodes in ClientRec for RecordAReply

2011-11-14 Thread walter harms
Am 14.11.2011 18:04, schrieb Keith Packard: On Tue, 8 Nov 2011 10:47:44 -0800, Jamey Sharp ja...@minilop.net wrote: And can I persuade you to just inline this directly into its only call site, below, in Dispatch? I don't think factoring it out enhances clarity in this case, especially

Re: [PATCH:xmodmap 3/3] Replace chk_malloc + sprintf with asprintf

2011-11-14 Thread walter harms
Am 13.11.2011 18:27, schrieb Alan Coopersmith: On 11/12/11 01:14, walter harms wrote: Exit(-1); translates into exit(-1); (Why ?) this does not work as intended. maybe 1 or EXIT_FAILURE is better here. It's what the original code had and I didn't think about changing

Re: [PATCH:xmodmap 3/3] Replace chk_malloc + sprintf with asprintf

2011-11-12 Thread walter harms
Am 12.11.2011 06:27, schrieb Alan Coopersmith: Includes local private copy of asprintf for OS'es without it in libc. Removes chk_malloc as no callers remain anymore. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- configure.ac |2 +- xmodmap.c| 69

Re: [PATCH:libICE 6/6] Remove ancient workaround for System V/386 Release 4.2 compiler bug

2011-11-10 Thread walter harms
I love this part, UNIX System V/386 Release 4.2 Version 1 Reviewed-by: walter wha...@bfs.de Am 10.11.2011 07:19, schrieb Alan Coopersmith: Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- src/process.c | 12 +--- 1 files changed, 1 insertions(+), 11 deletions(-)

Re: [PATCH 7/7] Fix gcc -Wwrite-strings warnings in xf86Modes code

2011-11-09 Thread walter harms
jus 2 minor remarks, re, wh Am 08.11.2011 21:42, schrieb Alan Coopersmith: Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- hw/xfree86/modes/xf86Crtc.c |8 hw/xfree86/modes/xf86Crtc.h |2 +- hw/xfree86/modes/xf86EdidModes.c |2 +-

Re: [PATCH 11/12] Add a new XI2Mask struct and a few helper functions.

2011-11-09 Thread walter harms
Am 09.11.2011 05:04, schrieb Peter Hutterer: On Tue, Nov 08, 2011 at 11:00:21AM +0100, walter harms wrote: Am 07.11.2011 22:39, schrieb Peter Hutterer: The current XI2 mask handling is handy for copying (fixed size arrays) but a pain to deal with otherwise. Add a struct for XI2 masks

Re: [PATCH 07/12] dix: add AllocGrab helper function

2011-11-08 Thread walter harms
Am 07.11.2011 22:39, schrieb Peter Hutterer: Not needed since the GrabRec is a self-contained struct but will be needed for the xi2 input mask rework. FreeGrab already exists, make it available to other callers. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- dix/grabs.c

Re: [PATCH 11/12] Add a new XI2Mask struct and a few helper functions.

2011-11-08 Thread walter harms
Am 07.11.2011 22:39, schrieb Peter Hutterer: The current XI2 mask handling is handy for copying (fixed size arrays) but a pain to deal with otherwise. Add a struct for XI2 masks and the required accessors. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- dix/inpututils.c |

Re: Get the snapshot of a window , save the image to file ?

2011-11-08 Thread walter harms
Am 08.11.2011 01:43, schrieb Aaron Lewis: Hi, How can i get a snapshot of a window , and save the image to a file ? (i mean to program , not to run a command) Thanks ! take a look at xwd.c re, wh ___

Re: [PATCH evdev] Don't crop long value from EvdevBitIsSet.

2011-11-02 Thread walter harms
Am 02.11.2011 00:52, schrieb Peter Hutterer: Introduced in xf86-input-evdev-2.6.0-26-g4969389 Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- Cutting long to int for the return value loses us some values, notably in the ABS_MT ranges. src/evdev.c |2 +- 1 files

Re: [PATCH 1/7] Convert a bunch of sprintf to snprintf calls

2011-11-02 Thread walter harms
looks ok to me, some minor comments inside. re, wh Am 01.11.2011 23:42, schrieb Alan Coopersmith: This batch is the straightforward set - others are more complex and need more analysis to determine right size to pass. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com ---

Re: [PATCH 4/7] Convert glx/single2.c:DoGetString() to use asprintf()

2011-11-02 Thread walter harms
Am 01.11.2011 23:42, schrieb Alan Coopersmith: Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- glx/single2.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/glx/single2.c b/glx/single2.c index 9884f40..9f8254b 100644 --- a/glx/single2.c +++

Re: [PATCH evdev] Don't crop long value from EvdevBitIsSet.

2011-11-02 Thread walter harms
Am 02.11.2011 14:15, schrieb Chase Douglas: On 11/02/2011 07:29 AM, walter harms wrote: Am 02.11.2011 00:52, schrieb Peter Hutterer: Introduced in xf86-input-evdev-2.6.0-26-g4969389 Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- Cutting long to int for the return value loses

Re: [PATCH joystick 1/2] Fix option type for option duplication

2011-10-31 Thread walter harms
Am 31.10.2011 05:41, schrieb Peter Hutterer: xf86OptionListDuplicate() duplicates an XF86Option list, not an InputOption list. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/jstk_key.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff

Re: [PATCH joystick 2/2] Deal with opaque input option types.

2011-10-31 Thread walter harms
Am 31.10.2011 07:18, schrieb Jeremy Huddleston: You need to declare InputOption tmp; in input_option_free_list. With that, both are Reviewed-by: Jeremy Huddleston jerem...@apple.com On Oct 30, 2011, at 21:41, Peter Hutterer wrote: ABI 14 made the InputOption type opaque, move the

Re: [PATCH 2/5] Convert strncpy/strncat to strlcpy/strlcat

2011-10-29 Thread walter harms
Am 29.10.2011 06:41, schrieb Alan Coopersmith: As long as we're carrying around a compatibility copy in os/strl*.c, might as well use them. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- Xext/xvmc.c|6 ++ hw/dmx/config/dmxcompat.c |3

Re: [PATCH libX11 v2 1/4] Add _XGetRequest as substitute for GetReq/GetReqExtra

2011-10-27 Thread walter harms
Am 27.10.2011 06:21, schrieb Peter Hutterer: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- Changes to v1: - a few comment fixes, whitespace fixes to better align the code with the rest of the file - Warning added to _XGetRequest - typecast added to _XGetRequest usage from

Re: [PATCH libX11 v2 1/4] Add _XGetRequest as substitute for GetReq/GetReqExtra

2011-10-27 Thread walter harms
Am 27.10.2011 09:55, schrieb Jamey Sharp: On Thu, Oct 27, 2011 at 09:15:54AM +0200, walter harms wrote: Am 27.10.2011 06:21, schrieb Peter Hutterer: +void *_XGetRequest(Display *dpy, CARD8 type, size_t len) +{ +xReq *req; + +WORD64ALIGN + +if (dpy-bufptr + len dpy-bufmax

Re: [PATCH xinput 1/2] Centralise supported major/minor version.

2011-10-26 Thread walter harms
Am 26.10.2011 00:13, schrieb Peter Hutterer: Only have one location where the currently supported major/minor version is listed. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/list.c |9 +++-- src/xinput.c |8 ++-- 2 files changed, 13 insertions(+), 4

Re: [PATCH 1/2] xfree86: Fix type of IOPortBase to be a pointer

2011-10-16 Thread walter harms
Am 16.10.2011 06:38, schrieb Jeremy Huddleston: This addresses issues on 64bit systems where the IOPortBase is higher in memory space. Partially fixes: https://bugs.freedesktop.org/show_bug.cgi?id=41038 Signed-off-by: Jeremy Huddleston jerem...@apple.com ---

Re: [RFC] Bugzilla Cleanup

2011-09-19 Thread walter harms
hi, You actions are understandable but i warn to be careful. I did a quick look some time ago and found some bugs that where still open and valid and even contained patches but where is the wrong section so no one found them. Is it an option to have a open bugs marked as OLD BUG when age 2 ?

Re: [PATCH 1/9] dmx: Fix a non-constant printf format string warning.

2011-09-17 Thread walter harms
Am 17.09.2011 10:22, schrieb Jamey Sharp: Signed-off-by: Jamey Sharp ja...@minilop.net --- hw/dmx/input/lnx-keyboard.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/dmx/input/lnx-keyboard.c b/hw/dmx/input/lnx-keyboard.c index 5bfb881..5b92f3b 100644 ---

Re: [PATCH] savage: Avoid unnecessary float calculation in video display

2011-09-17 Thread walter harms
Am 17.09.2011 11:58, schrieb Tormod Volden: From: Tormod Volden debian.tor...@gmail.com There is no reason to do the division using floats as long as the result is an integer and there is no risk of intermediate overflow. This is in the code for Old chipsets. Integer division was

Re: [PATCH:libXaw3d] Make laygram.y compatible with bison 2.3 and older

2011-09-04 Thread walter harms
Am 04.09.2011 03:25, schrieb Gaetan Nadon: On Sat, 2011-09-03 at 11:34 -0700, Alan Coopersmith wrote: bison 2.3b added %name-prefix prefix and deprecated the older %name-prefix=prefix form, but we don't have a check for the bison version in autoconf. Without this fix, older bison gives

Re: [PATCH xserver/hw/xfree86/parser/scan.c] potential buffer overflow

2011-08-31 Thread walter harms
Am 31.08.2011 07:06, schrieb v...@picaros.org: [PATCH xserver/hw/xfree86/parser/scan.c] potential buffer overflow The patch below fixes a potential buffer overflow in xf86addComment(). This occurs if curlen 0 eol_seen == 0 iscomment == 0 , as follows from the code: char

Re: [PATCH 1/2] dri2: Let client call swap before previous swap target has been passed

2011-08-29 Thread walter harms
Am 29.08.2011 13:45, schrieb Pauli Nieminen: From: Pauli Nieminen pauli.niemi...@linux.intel.com Client has to be allowed to call swap buffers before last_swap_target has been passed if driver implements triple buffering with swap_interval. Time that swap may come before reaching

Re: [PATCH 1/4] Add null-terminated list interface.

2011-08-11 Thread walter harms
Am 11.08.2011 05:20, schrieb Peter Hutterer: This is a set of macros to provide a struct list-alike interface for classic linked lists such as the XF86OptionRec or the DeviceIntRec. The typical format for these is to have a struct foo *next pointer in each struct foo and walk through those.

Re: [PATCH 2/5] Use correct swap{l,s} (or none at all for CARD8)

2011-08-07 Thread walter harms
Am 05.08.2011 18:04, schrieb Mikhail Gusarov: Twas brillig at 16:54:57 05.08.2011 UTC+02 when wha...@bfs.de did gyre and gimble: wh But is this a common problem in network programming ? In X11 client decides the byte order, and server has to deal with what comes over the wire. Most

Re: [PATCH 2/5] Use correct swap{l,s} (or none at all for CARD8)

2011-08-05 Thread walter harms
hi matt, I am not sure if i understand the purpose of swap() really. do you generaly swap bytes ? then you may like a look at swab() (man 3 swab). On the other side when endianes is a problem ntoh() and friends may be more friendly. the macro uses sizeof((src)) != 2 perhaps you can use int16_t

Re: [PATCH 4/4 v4] xf86Helper: use LogHdrMessageVerb in xf86VDrvMsgVerb

2011-08-05 Thread walter harms
Am 05.08.2011 16:20, schrieb Daniel Kurtz: LogHdrMessageVerb allows passing a parameterized header to insert in a log message between MessageType and the formatted message body string. Signed-off-by: Daniel Kurtz djku...@chromium.org Reviewed-by: Peter Hutterer peter.hutte...@who-t.net

Re: [PATCH 2/5] Use correct swap{l,s} (or none at all for CARD8)

2011-08-05 Thread walter harms
Am 05.08.2011 16:34, schrieb Daniel Stone: Hi, On Fri, Aug 05, 2011 at 04:07:13PM +0200, walter harms wrote: I am not sure if i understand the purpose of swap() really. To account for different byte ordering (rather than bit ordering) on machines of different endianness. The bit

Re: [PATCH evtest 2/2] Add one-shot query functionality

2011-07-17 Thread walter harms
Am 17.07.2011 00:07, schrieb Daniel Drake: Add functionality to query evdev state of a specific key, switch, button, LED or sound event. This is useful in programs such as powerd (http://wiki.laptop.org/go/Powerd) which need to query things like the state of the laptop lid switch from shell

Re: [PATCH] xclipboard: avoid overflow crash when building labels

2011-07-08 Thread walter harms
Am 08.07.2011 21:10, schrieb Kees Cook: Hi, On Fri, Jul 08, 2011 at 08:34:48PM +0200, Julien Cristau wrote: On Fri, Jul 8, 2011 at 11:01:45 -0700, Kees Cook wrote: This replaces sprintf with snprintf to avoid crashing when creating various labels.

Re: [PATCH 02/10] xfree86: NULL option values are technically valid, don't strdup them

2011-07-04 Thread walter harms
Am 04.07.2011 08:09, schrieb Peter Hutterer: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- hw/xfree86/common/xf86Option.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/xfree86/common/xf86Option.c b/hw/xfree86/common/xf86Option.c index

Re: [PATCH 01/15] Fix pressure-motion property format

2011-06-10 Thread walter harms
The code says INT32. Something to worry about ? Why you are not using (u)int32_t ? re, wh Am 09.06.2011 21:57, schrieb Daniel Stone: From: Derek Foreman derek.fore...@collabora.co.uk UINT32, not float. Signed-off-by: Derek Foreman derek.fore...@collabora.co.uk Reviewed-by: Daniel

Re: [PATCH 07/15] Replace the motion estimator

2011-06-10 Thread walter harms
Am 09.06.2011 21:57, schrieb Daniel Stone: From: Derek Foreman derek.fore...@collabora.co.uk Use a smarter motion estimator that attempts to draw a best-fit line through the history where possible, including taking acceleration into account. Signed-off-by: Derek Foreman

Re: [PATCH] randr: void function cannot return value

2011-06-06 Thread walter harms
Am 06.06.2011 16:53, schrieb Nicolas Kaiser: Providing an argument to return in a function with void return type is not allowed by the C standard, and makes the Sun compilers unhappy. Signed-off-by: Nicolas Kaiser ni...@nikai.net Reviewed-by: Jeremy Huddleston jerem...@apple.com

Re: [PATCH 3/4] xserver: Use regular expressions in Match entries

2011-06-05 Thread walter harms
Am 05.06.2011 07:52, schrieb Oleh Nykyforchyn: Use regular expressions in Match entries Signed-off-by: Oleh Nykyforchyn oleh@gmail.com --- hw/xfree86/common/xf86Xinput.c | 22 -- hw/xfree86/parser/InputClass.c | 17 -

Re: [PATCH:xdm 5/5] Simplify FailedLogin code

2011-06-03 Thread walter harms
mmmh, you are changing FailedLogin (d, struct greet_info) into FailedLogin (d, char *) maybe it is better to keep greet_info as future version may need additional info. I would stick with struct greet_info and use greet-name instead username. It is not a real problem just my experience. re, wh

Re: [PATCH 02/27] Input: Add round_towards_zero helper

2011-06-03 Thread walter harms
Hello daniel, C99 defines FE_TOWARDZERO, so any compiler that support c99 should work with the example below. re, wh ntl: i guess you code will work also with older compilers #include stdio.h #include fenv.h #include math.h /* gcc fesetround.c -lm -std=c99 */ int main() { double ii;

Re: [PATCH 02/27] Input: Add round_towards_zero helper

2011-06-03 Thread walter harms
, schrieb Daniel Stone: Hi, On Fri, Jun 03, 2011 at 06:04:34PM +0200, walter harms wrote: C99 defines FE_TOWARDZERO, so any compiler that support c99 should work with the example below. Well ... there aren't many of those. :) I had started with fesetround, but there were a couple

Re: [PATCH] makekeys: Fix build/target word size mismatch when cross-compiling

2011-05-31 Thread walter harms
Am 31.05.2011 17:24, schrieb Derek Buitenhuis: On 11-05-30 12:07 PM, walter harms wrote: (val 24) 0xff = hi val 0xff = lo (maybe a simple %08x would do the same) Ntl. the coding style (byte oriented) indicated that the Signature may be different on big/little endian machines

Re: [PATCH] makekeys: Fix build/target word size mismatch when cross-compiling

2011-05-30 Thread walter harms
Am 30.05.2011 15:37, schrieb Derek Buitenhuis: From: Derek Buitenhuis dbuit...@windriver.com Since makekeys is built using build environment's gcc and run natively, we have to make sure that the size of the Signature type is the same on both the native build environment and the host,

Re: [PATCH] makekeys: Fix build/target word size mismatch when cross-compiling

2011-05-30 Thread walter harms
Am 30.05.2011 17:27, schrieb Derek Buitenhuis: On 11-05-30 10:28 AM, walter harms wrote: The way it is printed does not take into account big/little endian, is this adressed somewhere else ? re, wh Could you perhaps elaborate a bit on what you mean by this? I have a vague idea what

Re: [PATCH 7/8] dix: rename ProcessRawEvents to dix/events.c:DeliverRawEvent

2011-05-28 Thread walter harms
Am 27.05.2011 07:13, schrieb Peter Hutterer: No functional changes, prep work for future changes. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- Xi/exevents.c | 31 +-- dix/events.c | 29 + include/dix.h |5

Re: [PATCH] regular expression support (was Re: [PATCH xfree86] Signed-off-by: Oleh Nykyforchyn)

2011-05-27 Thread walter harms
Am 27.05.2011 07:56, schrieb Peter Hutterer: On Wed, May 25, 2011 at 03:08:32PM +0300, Oleh Nykyforchyn wrote: On Wed, 25 May 2011 16:14:42 +1000 Peter Hutterer peter.hutte...@who-t.net wrote: I believe | is used frequently in regular expressions, so using it as decision over regex or

Re: [PATCH:xts 11/16] xts5: Add parentheses around assignment in an if.

2011-05-26 Thread walter harms
Am 25.05.2011 13:00, schrieb Cyril Brulebois: Tell compilers we really meant to assign and then check. The following warning goes away accordingly: | CC nextvclass.lo | nextvclass.c:224:14: warning: using the result of an assignment as a condition without parentheses

Re: [PATCH:xts 03/16] xts5: Fix missing type specifier.

2011-05-26 Thread walter harms
Am 25.05.2011 13:00, schrieb Cyril Brulebois: The caller stores the result in an integer, so let's use that as return type (which is the default anyway): | CC checkevent.lo | checkevent.c:664:1: warning: type specifier missing, defaults to 'int' [-Wimplicit-int] |

Re: [PATCH] fbbltone.c: Mark bitmasks as unsigned ints

2011-05-22 Thread walter harms
Am 22.05.2011 22:50, schrieb Alan Coopersmith: Clears many Sun compiler warnings: fbbltone.c, line 491: warning: integer overflow detected: op fbbltone.c, line 491: warning: integer overflow detected: op fbbltone.c, line 491: warning: integer overflow detected: op fbbltone.c, line 491:

Re: crash after setting root background to None, then setting color - patch for review

2011-05-18 Thread walter harms
Looks ok to me, feel free to improve the code further, Reviewed-by: Walter Harms Am 17.05.2011 20:22, schrieb Marko Macek: Hello! Please review/apply this patch: diff -ru xorg-server-1.10.1/dix/window.c xorg-server-1.10.1-new/dix/window.c --- xorg-server-1.10.1/dix/window.c2011-02

Re: [PATCH twm 2/3] Add sanity checking to avoid a possible NULL dereference

2011-05-16 Thread walter harms
Am 12.05.2011 07:43, schrieb Jeremy Huddleston: menus.c:934:26: warning: Access to field 'fore' results in a dereference of a null pointer (loaded from variable 'cur') cur-hi_back = cur-fore = f3.pixel; ~~~ ^ Found-by: clang static analyzer

Re: [PATCH:libXt] Bug 34715: XtAppMainLoop doesn't work without a Display

2011-03-08 Thread walter harms
Am 07.03.2011 22:19, schrieb Alan Coopersmith: On 03/ 7/11 03:00 AM, walter harms wrote: Am 06.03.2011 21:53, schrieb Alan Coopersmith: From: Jordan Hayes jor...@bitway.com https://bugs.freedesktop.org/show_bug.cgi?id=34715 XtAppNextEvent() doesn't return until there's an actual XEvent

Re: [PATCH:libXt 3/3] Convert ALLOCATE_LOCAL + sprintf to XtAsprintf

2011-03-08 Thread walter harms
the only place where a change is, is CombineAppUserDefaults() can you set XAPPLRESDIR to see if both paths generate the same error ? re, wh Am 08.03.2011 12:45, schrieb Cyril Brulebois: Alan Coopersmith alan.coopersm...@oracle.com (07/03/2011): Perhaps a difference in the setting of $HOME

Re: [PATCH:libXt] Bug 34715: XtAppMainLoop doesn't work without a Display

2011-03-07 Thread walter harms
, but doesn't return (because of course, those aren't XEvents). Which means that the exit flag doesn't get a chance to break the loop until/unless there's an actual XEvent. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com looks ok to me Signed-off-by: Walter Harms wham...@bfs.de --- src

Re: [PATCH 2/2] os: Work around integer overflow in TimerSet.

2011-03-07 Thread walter harms
Am 06.03.2011 21:34, schrieb Fernando Carrijo: Cyril Brulebois k...@debian.org wrote: If TimerSet gets called with a big timeout, this call can overflow: millis += now; Detect overflow and set millis to the maximal integer when that happens, to avoid falling in the “already expired”

Re: touchpad dell latitude d620 buffer overflow after touch

2011-02-27 Thread walter harms
you are using 1.9.3 RC 1. did is work before ? i use a D620 with touchpad but the X11 is much older (7.2) and i have no problems. re, wh Am 26.02.2011 12:08, schrieb Bastiaan Wakkie: 1.9.3 RC 1 ___ xorg-devel@lists.x.org: X.Org development

Re: [PATCH:xscope] Greatly reduce xscope's bss pages

2011-02-26 Thread walter harms
the patch look reasonable, just one small thing: the naming in unfortune the original calloc() uses (number,size) perhaps you can rename it simply into zalloc() (z=zero) or what every you thing fits. Just my two cents, re, wh Am 26.02.2011 08:28, schrieb Alan Coopersmith: xscope had several

Re: [Patch] refactor pointer acceleration

2011-02-06 Thread walter harms
hi Simon, thx for you effort, just one thing: you will get more feedback when you send the patches one by one in the body and not as attachment. re, wh Am 05.02.2011 22:39, schrieb Simon Thum: Hi Peter, the patch series consists mainly of refactoring, no functional changes. The main point

Re: [PATCH:libXt 2/3] GetResources: protect against underflow when type conversion fails

2011-02-05 Thread walter harms
Hello Alan, here is an other bug not related but also resource handling. Whould you mind to take a look at this patch ? https://bugs.freedesktop.org/show_bug.cgi?id=22543 I had simply no time to evaluate and this will change for the next weeks. re, wh Am 05.02.2011 07:29, schrieb Alan

Re: [PATCH x11perf] Make sure that window fits into screen.

2011-01-28 Thread walter harms
Am 28.01.2011 13:59, schrieb Michel Dänzer: On Fre, 2011-01-28 at 13:10 +0200, Rami Ylimäki wrote: XGetImage request will correctly fail and terminate x11perf with a BadMatch error if window is larger than its backing pixmap. This change makes all tests from putimage10 to getimagexy500

Re: [PATCH 28/32] [libx11] Comparing array against NULL is not useful xkb-server-vmods != NULL

2011-01-27 Thread walter harms
Am 27.01.2011 08:54, schrieb Erkki Seppälä: Removed superfluous comparison. Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi --- src/xkb/XKBMisc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/xkb/XKBMisc.c b/src/xkb/XKBMisc.c index fc5ae5f..4aa1f73

Re: [PATCH 31/32] [libx11] Cannot reach dead expression 0U inside statement if (1U + (target_dir ? strl...

2011-01-27 Thread walter harms
Am 27.01.2011 08:54, schrieb Erkki Seppälä: Removed superfluous check for NULL target_dir; it is already handled before this code. Reviewed-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi ---

Re: [PATCH 32/32] [libx11] Cannot reach dead statement return NULL;

2011-01-27 Thread walter harms
Am 27.01.2011 08:54, schrieb Erkki Seppälä: Removed superfluous check for NULL. name == NULL is already checked at the function entry. Reviewed-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi ---

Re: [PATCH] libtXt: add simple example for XtAppNextEvent() man page

2011-01-25 Thread walter harms
Am 25.01.2011 06:18, schrieb Alan Coopersmith: On 01/24/11 05:16 AM, walter harms wrote: The bits in [] are to provide information to the e-mail readers, letting us know which module it's for, but are removed by git when applying the patch, leaving the rest of the subject line

Re: [PATCH] libXt: add simple example for XtName man page

2011-01-24 Thread walter harms
Am 23.01.2011 18:26, schrieb Alan Coopersmith: @@ -134,7 +138,36 @@ Specifies the widget. .SH DESCRIPTION .ZN XtName returns the widget's name. + +.SH EXAMPLE + +The example demonstrate the use. I'd just leave that line out, since it's obvious that's what the example is for -

[PATCH] libXt: add example to XtCreateApplicationContext man page

2011-01-23 Thread walter harms
[PATCH] add example for XtCreateApplicationContext man page Signed-off-by: walter harms wha...@bfs.de --- man/XtCreateApplicationContext.man | 50 +++- 1 files changed, 49 insertions(+), 1 deletions(-) diff --git a/man/XtCreateApplicationContext.man b/man

[PATCH] libXt add example for XtAppAddSignal man page

2011-01-23 Thread walter harms
libXt add example for XtAppAddSignal man page add specs for XtSignalCallbackProc Signed-off-by: walter harms wha...@bfs.de --- man/XtAppAddSignal.man | 89 +++- 1 files changed, 88 insertions(+), 1 deletions(-) diff --git a/man/XtAppAddSignal.man b

[PATCH] libXt add example to XtSetValues man page

2011-01-23 Thread walter harms
Add example for Signed-off-by: walter harms wha...@bfs.de --- man/XtSetValues.man | 57 +++ 1 files changed, 57 insertions(+), 0 deletions(-) diff --git a/man/XtSetValues.man b/man/XtSetValues.man index a07e9b6..56f7ab2 100644 --- a/man

[PATCH] libXt: add example to XtGetResourceList man page

2011-01-23 Thread walter harms
add example for XtGetResourceList and XtGetConstraintResourceList add used structure to page Signed-off-by: walter harms wha...@bfs.de --- man/XtGetResourceList.man | 67 + 1 files changed, 67 insertions(+), 0 deletions(-) diff --git a/man

[PATCH] libXt: add simple example for XtName man page

2011-01-23 Thread walter harms
[PATCH] add simple example for XtName Signed-off-by: walter harms wha...@bfs.de --- man/XtName.man | 33 + 1 files changed, 33 insertions(+), 0 deletions(-) diff --git a/man/XtName.man b/man/XtName.man index d271c9d..30036b3 100644 --- a/man/XtName.man +++ b

[PATCH] libtXt: add simple example for XtAppNextEvent() man page

2011-01-23 Thread walter harms
Add simple example for XtAppNextEvent() man page Signed-off-by: walter harms wha...@bfs.de --- man/XtAppNextEvent.man | 43 +++ 1 files changed, 43 insertions(+), 0 deletions(-) diff --git a/man/XtAppNextEvent.man b/man/XtAppNextEvent.man index e7278a5

Re: [PATCH:libXt 2/4] Add XtAsprintf() to Alloc.c Intrinsic.h

2010-12-15 Thread walter harms
Am 14.12.2010 19:36, schrieb Alan Coopersmith: walter harms wrote: Am 14.12.2010 01:40, schrieb Alan Coopersmith: Like asprintf() but using XtMalloc() to tie into the Xt memory allocation and error handling subsystems. should that have a #ifndef HAVE_ASPRINTF ? when the system has

Re: [PATCH:libXt 4/4] Convert some sprintf calls to snprintf

2010-12-14 Thread walter harms
Am 14.12.2010 01:40, schrieb Alan Coopersmith: Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- src/Selection.c |3 ++- src/Shell.c |5 +++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/Selection.c b/src/Selection.c index

Re: [PATCH:libXt 2/4] Add XtAsprintf() to Alloc.c Intrinsic.h

2010-12-14 Thread walter harms
Am 14.12.2010 01:40, schrieb Alan Coopersmith: Like asprintf() but using XtMalloc() to tie into the Xt memory allocation and error handling subsystems. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- COPYING |2 +- include/X11/Intrinsic.h |9

Re: [PATCH xinput] use ASCII art when UTF-8 environment is not available

2010-12-10 Thread walter harms
Am 10.12.2010 02:11, schrieb Peter Hutterer: On Thu, Dec 09, 2010 at 01:30:18PM -0500, James Cloos wrote: PH == Peter Hutterer peter.hutte...@who-t.net writes: PH urgh, no. I'd rather change the output ASCII only than have if/else PH conditions for the output. Unfortunate. Actually using

Re: [PATCH:libXmu] XmuCvtStringToCursor: sprintf - snprintf check for XtMalloc failure

2010-12-06 Thread walter harms
Am 05.12.2010 23:53, schrieb Julien Cristau: On Sun, Dec 5, 2010 at 21:43:50 +0100, walter harms wrote: Can you use XFNasprintf() here ? libXmu is not the X server. That does not mean not to use helper from the server side. Otherwise you would have to reimplement everything also

Re: [PATCH v4 6/7] Replace alloc+strcpy+strcat with asprintf() XNFasprintf() calls

2010-12-06 Thread walter harms
Am 06.12.2010 09:34, schrieb Alan Coopersmith: walter harms wrote: Am 05.12.2010 18:51, schrieb Alan Coopersmith: diff --git a/hw/xfree86/common/xf86ShowOpts.c b/hw/xfree86/common/xf86ShowOpts.c index ce86090..c0fa80a 100644 --- a/hw/xfree86/common/xf86ShowOpts.c +++ b/hw/xfree86

Re: [PATCH v4 6/7] Replace alloc+strcpy+strcat with asprintf() XNFasprintf() calls

2010-12-05 Thread walter harms
Am 04.12.2010 21:14, schrieb Alan Coopersmith: Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- dix/devices.c | 17 +++-- hw/xfree86/common/xf86Config.c |4 +--- hw/xfree86/common/xf86Option.c |5 +

Re: [PATCH:libXmu] XmuCvtStringToCursor: sprintf - snprintf check for XtMalloc failure

2010-12-05 Thread walter harms
Am 05.12.2010 09:14, schrieb Alan Coopersmith: Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- src/StrToCurs.c | 24 ++-- 1 files changed, 14 insertions(+), 10 deletions(-) diff --git a/src/StrToCurs.c b/src/StrToCurs.c index 53d98f5..4d72f80 100644

Re: [PATCH v4 6/7] Replace alloc+strcpy+strcat with asprintf() XNFasprintf() calls

2010-12-05 Thread walter harms
Am 05.12.2010 18:51, schrieb Alan Coopersmith: diff --git a/hw/xfree86/common/xf86ShowOpts.c b/hw/xfree86/common/xf86ShowOpts.c index ce86090..c0fa80a 100644 --- a/hw/xfree86/common/xf86ShowOpts.c +++ b/hw/xfree86/common/xf86ShowOpts.c @@ -97,11 +97,8 @@ void DoShowOptions (void) {

Re: [PATCH libXaw] fix potential infinte loop in XawBoxQueryGeometry() (bug 11569)

2010-12-04 Thread walter harms
there seems some more bugs described in the bugzilla, some a are and some seems fixed already but appear still open. Who can close these bugs ? re, wh Am 03.12.2010 23:28, schrieb Alan Coopersmith: Matt Turner wrote: From: Glenn Burkhardt gbburkha...@verizon.net Originally sent to xorg@

Re: [PATCH libXaw] fix potential infinte loop in XawBoxQueryGeometry() (bug 11569)

2010-12-04 Thread walter harms
Am 04.12.2010 14:10, schrieb Julien Cristau: On Sat, Dec 4, 2010 at 13:26:09 +0100, walter harms wrote: there seems some more bugs described in the bugzilla, some a are and some seems fixed already but appear still open. Who can close these bugs ? Anyone. You just need a bugzilla

Re: [PATCH 06/11] Add X*asprintf() routines to mirror common asprintf() routines

2010-12-01 Thread walter harms
Am 30.11.2010 23:37, schrieb Dan Nicholson: On Tue, Nov 30, 2010 at 10:16 AM, walter harms wha...@bfs.de wrote: Am 30.11.2010 05:57, schrieb Alan Coopersmith: Provides a portable implementation of this common allocating sprintf() API found in many, but not yet all, of the platforms we

Re: [PATCH 06/11] Add X*asprintf() routines to mirror common asprintf() routines

2010-11-30 Thread walter harms
Am 30.11.2010 05:57, schrieb Alan Coopersmith: Provides a portable implementation of this common allocating sprintf() API found in many, but not yet all, of the platforms we support. If the platform provides vasprintf() we simply wrap it, otherwise we implement it - either way callers can

[PATCH libXt] remove strcmp in src/ResConfig.c

2010-11-07 Thread walter harms
ake remainder check like in the rest of code and replace strcmp() Signed-off-by: walter harms wha...@bfs.de diff --git a/src/ResConfig.c b/src/ResConfig.c index 7514754..63afb18 100644 --- a/src/ResConfig.c +++ b/src/ResConfig.c @@ -746,7 +746,7 @@ _search_widget_tree

Re: [PATCH libXt] remove strcmp

2010-11-01 Thread walter harms
Mark Kettenis schrieb: Date: Tue, 26 Oct 2010 13:48:53 +0200 From: walter harms wha...@bfs.de make remainder check like in the rest of code and replace strcmp() Please try to keep the coding style similar to what's used for the surrounding code. give me a hint that is you problem

<    1   2   3   4   5   6   >