Fix possibl NULL access
Signed-off-by: walter harms wha...@bfs.de
diff --git a/src/Resources.c b/src/Resources.c
index 1cb37d4..3090d7e 100644
--- a/src/Resources.c
+++ b/src/Resources.c
@@ -967,8 +967,11 @@ static XtCacheRef *GetResources(
if (cache_ptr *cache_ptr
From dd37c578f348d9ba3e466bee6458629c5fde03a1 Mon Sep 17 00:00:00 2001
XtFree() can handle NULL , remove check
Signed-off-by: walter harms wha...@bfs.de
---
src/Varargs.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/src/Varargs.c b/src/Varargs.c
index b03c889
Matthieu Herrb schrieb:
On Tue, Oct 26, 2010 at 02:00:09PM +0200, walter harms wrote:
+ // value.addr can be NULL see: !already_copied
+ if (value.addr)
*((XtTranslations *)widget-core.tm.current_state) =
*((XtTranslations *)value.addr
make remainder check like in the rest of code and replace strcmp()
Signed-off-by: walter harms wha...@bfs.de
---
src/ResConfig.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/ResConfig.c b/src/ResConfig.c
index 7514754..eb2e7cc 100644
--- a/src/ResConfig.c
Fix possible NULL access
Signed-off-by: walter harms wha...@bfs.de
---
src/Resources.c |3 +++
src/TMparse.c | 18 ++
src/TMstate.c | 11 +++
3 files changed, 24 insertions(+), 8 deletions(-)
diff --git a/src/Resources.c b/src/Resources.c
index 1cb37d4
_XtGetPerWidgetInput may return NULL
avoid possible NULL references
Signed-off-by: walter harms wha...@bfs.de
---
src/Keyboard.c | 15 +--
1 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/src/Keyboard.c b/src/Keyboard.c
index 9c8065b..ef27399 100644
--- a/src
to make this work for the next patches.
re,
wh
walter harms wrote:
_XtGetPerWidgetInput() can return NULL, move check so that
pwi-queryEventDescendant and friends are covered
re,
wh
Signed-off-by: wha...@bfs.de
--- libXt-1.0.8/src/Keyboard.c.org 2010-10-20 20:26:05.0 +0200
value.addr could become NULL, add check
re,
wh
Signed-off-by: wha...@bfs.de
--- libXt-1.0.8/src/Resources.c.org 2010-09-22 22:37:23.0 +0200
+++ libXt-1.0.8/src/Resources.c 2010-10-20 21:37:01.0 +0200
@@ -971,8 +971,11 @@
if (cache_ptr *cache_ptr)
*Event could become NULL add check
re,
wh
Signed-off-by: wha...@bfs.de
--- libXt-1.0.8/src/TMparse.c.org 2010-10-20 22:04:30.0 +0200
+++ libXt-1.0.8/src/TMparse.c 2010-10-20 22:04:44.0 +0200
@@ -1291,10 +1291,15 @@
*event = timerEventRec;
}
-
+/*
+
context-matches could become NULL, add check
re,
wh
Signed-off-by: wha...@bfs.de
--- libXt-1.0.8/src/TMstate.c.org 2010-10-20 22:15:07.0 +0200
+++ libXt-1.0.8/src/TMstate.c 2010-10-20 22:35:35.0 +0200
@@ -720,10 +720,13 @@
XtRealloc((char
Jeremy Huddleston schrieb:
I have a bunch of reports of this on version 1.4.2-apple53 as well (which
cherry picked changes to support the new libXfont), so it probably reduces
down to something in those change which were cherry picked. That's not much
help, but it looks like it probably
Peter Hutterer schrieb:
On Sun, Oct 17, 2010 at 09:25:56PM -0400, Trevor Woerner wrote:
From: Trevor Woerner twoer...@gmail.com
Replace calls to deprecated functions (Xfree(), Xcalloc(), Xmalloc(), etc)
with calls to standard dynamic memory functions (free(), calloc(), malloc(),
etc) in
Mikhail Gusarov schrieb:
Twas brillig at 10:07:23 19.10.2010 UTC+02 when wha...@bfs.de did gyre and
gimble:
wh malloc will return (void *) so there is no need to cast.
wh i do not know xmalloc() but i see no check for OOM condition.
wh instead of removing xmalloc() it would be more
Takashi Iwai schrieb:
Signed-off-by: Takashi Iwai ti...@suse.de
---
include/synaptics-properties.h | 10 ++
src/keymap.c | 58 ++--
src/properties.c | 63
src/synaptics.c
Alan Coopersmith schrieb:
walter harms wrote:
You appear to have attached a different version of the patch than
in the body of your e-mail - neither git nor patch can apply either
one to the current git tree. After a bit of manual editing I
finally got one to work, so I fixed
Hi list,
i have problems accessing bugs.freedesktop.org, http://www.freedesktop.org
works fine
but at bugs.freedesktop.org it says invalid URL broken redirect ? (same with
https:)
re,
wh
___
xorg-devel@lists.x.org: X.Org development
Archives:
Alan Coopersmith schrieb:
walter harms wrote:
hi i got no feedback for my patch
could you please take a look ? subject:
patch:libXt-1.0.8 fix possible NULL access
Sorry, it's libXt, which is very near the bottom of most people's
priority lists, now that most modern desktop software
Hi List,
while testing a static checker, i got warnings about a possible NULL access.
looking into the code i found that GetClassActions() may return NULL
causing table-signature to ask for trouble.
re,
wh
Honor that GetClassActions() may return NULL.
Signed-off-by: Walter wha...@bfs.de
Alan Coopersmith schrieb:
walter harms wrote:
hi list;
the current codes checks for
eventWidget == NULL after accessing
eventWidget-core.tm.proc_table
now it checks for eventWidget before access eventWidget-core.tm.proc_table.
Thanks for the fix - it's been pushed to git master now
Barry Scott schrieb:
On Wednesday 22 September 2010 08:18:21 walter harms wrote:
hi List,
the code checks the upperlimit to 10 while the upperlimit is actualy 9.
You could use (sizeof( par )/sizeof( String ))-1 to make the code robust
aginst
a change to the size of par.
yep, i could
Pat Kane schrieb:
In the original code if 'i' is equal to 10 then the line
(void) memmove((char*)par, (char*)params, i * sizeof(String) );
moves ten things, which is okay.
The next line:
bzero( par[i], (10-i) * sizeof(String) );
moves zero things to a bad address, which is probably
should i resend it ?
re,
wh
Jeremy Huddleston schrieb:
Hi wh,
Send patches like this to xorg-devel rather than the users list.
Reviewed-by: Jeremy Huddleston jerem...@apple.com
On Sep 22, 2010, at 00:13, walter harms wrote:
Hi List,
i found something that looked like a bug in libXt
hi list;
the current codes checks for
eventWidget == NULL after accessing
eventWidget-core.tm.proc_table
now it checks for eventWidget before access eventWidget-core.tm.proc_table.
The org. patch is attacehd since i guess the tabs will be mangeld.
re,
wh
Signed-off-by: walter harms wha
hi List,
the code checks the upperlimit to 10 while the upperlimit is actualy 9.
The org. patch is attacehd since i guess the tabs will be mangeld.
re,
wh
Signed-off-by: walter harms wha...@bfs.de
--- libXt-1.0.8/src/Error.c.org 2010-09-21 23:23:00.0 +0200
+++ libXt-1.0.8/src/Error.c
501 - 524 of 524 matches
Mail list logo
