[PATCH:libXfont 2/2] Replace malloc(strlen)+strcpy/strcat calls with strdup

2013-10-29 Thread Alan Coopersmith
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- src/FreeType/ftfuncs.c |4 +--- src/FreeType/xttcap.c |3 +-- src/fontfile/fontdir.c | 10 +++--- 3 files changed, 5 insertions(+), 12 deletions(-) diff --git a/src/FreeType/ftfuncs.c b/src/FreeType/ftfuncs.c index

Re: [PATCH:libXfont 2/2] Replace malloc(strlen)+strcpy/strcat calls with strdup

2013-10-29 Thread Jasper St. Pierre
On Tue, Oct 29, 2013 at 9:55 PM, Alan Coopersmith alan.coopersm...@oracle.com wrote: Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- src/FreeType/ftfuncs.c |4 +--- src/FreeType/xttcap.c |3 +-- src/fontfile/fontdir.c | 10 +++--- 3 files changed, 5

Re: [PATCH:libXfont 2/2] Replace malloc(strlen)+strcpy/strcat calls with strdup

2013-10-29 Thread Alan Coopersmith
On 10/29/13 07:07 PM, Jasper St. Pierre wrote: +#define FontFileSaveString(s) strdup(s) Shouldn't this #define be in a header file to be useful? All the calls to that function in libXfont appear in that file after the point of the #define: % git grep FontFileSaveString