Re: [PATCH:libxkbfile 1/4] unifdef -UXKB_IN_SERVER

2013-10-28 Thread Alan Coopersmith
On 10/26/13 11:47 PM, Ran Benita wrote: Entire series looks good to me and server still compiles and goes through xkbcomp OK. Thanks for checking it out. You can go further with the first patch (see my comments when you unifdef'd this in libX11) but anything is good Yeah, as I said then, I

Re: [PATCH:libxkbfile 1/4] unifdef -UXKB_IN_SERVER

2013-10-27 Thread Ran Benita
On Sat, Oct 26, 2013 at 02:09:59PM -0700, Alan Coopersmith wrote: Xserver has its own copy of this code now, so we don't need to keep an unused copy in libxkbfile too. Entire series looks good to me and server still compiles and goes through xkbcomp OK. You can go further with the first patch

[PATCH:libxkbfile 1/4] unifdef -UXKB_IN_SERVER

2013-10-26 Thread Alan Coopersmith
Xserver has its own copy of this code now, so we don't need to keep an unused copy in libxkbfile too. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- include/X11/extensions/XKBfile.h |2 -- include/X11/extensions/XKBrules.h |2 -- src/XKBfileInt.h |2