Re: [PATCH:xsetroot] Only use results from GetWindowProperty if it returned success

2015-01-05 Thread Hans de Goede
Hi, On 03-01-15 23:30, Alan Coopersmith wrote: Since Xlib prior to 1.6 didn't always clear values on failure, don't assume they're safe to use unless we succeeded. Reported by Oracle Parfait 1.5.1: Error: Uninitialised memory (CWE 456) Possible access to uninitialised memory 'after'

[PATCH:xsetroot] Only use results from GetWindowProperty if it returned success

2015-01-03 Thread Alan Coopersmith
Since Xlib prior to 1.6 didn't always clear values on failure, don't assume they're safe to use unless we succeeded. Reported by Oracle Parfait 1.5.1: Error: Uninitialised memory (CWE 456) Possible access to uninitialised memory 'after' at line 328 of xsetroot.c in function