Re: [PATCH] Close non-keyboard devices on DPMS off

2013-10-06 Thread Keith Packard
Mark Kettenis mark.kette...@xs4all.nl writes: Is that really desirable? It has a couple of benefits -- the first is that touch screens and touch pads often get input while your laptop screen is closed; this prevents that from waking up the X server. The second is that turning off input devices

Re: [PATCH] Close non-keyboard devices on DPMS off

2013-10-06 Thread Alan Coopersmith
On 10/ 6/13 11:17 AM, Keith Packard wrote: Mark Kettenis mark.kette...@xs4all.nl writes: For me, moving the mouse has always been the most natural way to wake up the screen. Yeah, that's the usual way I wake my machine up as well. However, if you try this on an OS X machine, you'll find that

Re: [PATCH] Close non-keyboard devices on DPMS off

2013-10-06 Thread Michal Suchanek
On 6 October 2013 20:17, Keith Packard kei...@keithp.com wrote: Mark Kettenis mark.kette...@xs4all.nl writes: Is that really desirable? It has a couple of benefits -- the first is that touch screens and touch pads often get input while your laptop screen is closed; this prevents that from

Re: [PATCH] Close non-keyboard devices on DPMS off

2013-10-06 Thread Keith Packard
Michal Suchanek hramr...@gmail.com writes: this feature should be optional at the very least. I certainly didn't want to suggest that it shouldn't be configurable; the patch was to make it possible to do the power measurements *and* show just how easy it was to implement the basic operation.

Re: [PATCH] Close non-keyboard devices on DPMS off

2013-10-06 Thread Arjan van de Ven
On 10/5/2013 6:11 AM, Mark Kettenis wrote: From: Keith Packard kei...@keithp.com Date: Fri, 4 Oct 2013 12:19:15 -0700 This prevents X server wakeup by mouse, tablet or touchscreen devices. Is that really desirable? For me, moving the mouse has always been the most natural way to wake I

Re: [PATCH] Close non-keyboard devices on DPMS off

2013-10-05 Thread Mark Kettenis
From: Keith Packard kei...@keithp.com Date: Fri, 4 Oct 2013 12:19:15 -0700 This prevents X server wakeup by mouse, tablet or touchscreen devices. Is that really desirable? For me, moving the mouse has always been the most natural way to wake up the screen. And I can imagine that touching

[PATCH] Close non-keyboard devices on DPMS off

2013-10-04 Thread Keith Packard
This prevents X server wakeup by mouse, tablet or touchscreen devices. It also saves power by shutting those devices down when the screen is blank. Signed-off-by: Keith Packard kei...@keithp.com --- hw/xfree86/common/xf86DPMS.c | 24 include/inputstr.h | 1 +