Re: [PATCH] Fix NO_LOCAL_CLIENT_CRED build

On Wed, 2015-07-08 at 11:21 -0700, Keith Packard wrote: > Jon TURNEY writes: > > > Please consider picking a version you like and applying it, or let > > me > > know how I can make this patch acceptable. > > I'll just apply your original patch and mark it as

Re: [PATCH] Fix NO_LOCAL_CLIENT_CRED build

Jon TURNEY jon.tur...@dronecode.org.uk writes: Please consider picking a version you like and applying it, or let me know how I can make this patch acceptable. I'll just apply your original patch and mark it as reviewed-by me. -- -keith signature.asc Description: PGP signature

Re: [PATCH] Fix NO_LOCAL_CLIENT_CRED build

Hi, On Mon, Jul 6, 2015 at 6:08 PM, Keith Packard kei...@keithp.com wrote: I liked your first version a lot better; looks a lot simpler. An autoconf test might make sense if there was some reason to override it? To be clear, I primarily gave feedback because touched it last. I think it makes

Re: [PATCH] Fix NO_LOCAL_CLIENT_CRED build

On 06/07/2015 23:08, Keith Packard wrote: Jon TURNEY writes: On 04/07/2015 05:21, Ray Strode wrote: On Thu, Jul 2, 2015 at 12:40 PM, Jon TURNEY wrote: Makes sense. Revised patch attached. LGTM I'm going to choose to assume that is a Reviewed-by: Keith, Please consider applying to master.

Re: [PATCH] Fix NO_LOCAL_CLIENT_CRED build

Jon TURNEY jon.tur...@dronecode.org.uk writes: On 04/07/2015 05:21, Ray Strode wrote: On Thu, Jul 2, 2015 at 12:40 PM, Jon TURNEY wrote: Makes sense. Revised patch attached. LGTM I'm going to choose to assume that is a Reviewed-by: Keith, Please consider applying to master. I liked

Re: [PATCH] Fix NO_LOCAL_CLIENT_CRED build

Hi, On Thu, Jul 2, 2015 at 12:40 PM, Jon TURNEY jon.tur...@dronecode.org.uk wrote: Makes sense. Revised patch attached. LGTM --Ray ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info:

Re: [PATCH] Fix NO_LOCAL_CLIENT_CRED build

From: Jon TURNEY jon.tur...@dronecode.org.uk Date: Mon, 29 Jun 2015 19:46:51 +0100 Subject: [PATCH] Fix NO_LOCAL_CLIENT_CRED build (v3) This is a build fix for MinGW Commit 4b4b9086 os: support new implicit local user access mode [CVE-2015-3164 2/3] carefully places the relevant code it adds under

Re: [PATCH] Fix NO_LOCAL_CLIENT_CRED build

targets. From f44b1021f5f3a6227fd62fba29f11917ecd25013 Mon Sep 17 00:00:00 2001 From: Jon TURNEY jon.tur...@dronecode.org.uk Date: Mon, 29 Jun 2015 19:46:51 +0100 Subject: [PATCH] Fix NO_LOCAL_CLIENT_CRED build (v2) This is a build fix for MinGW Commit 4b4b9086 os: support new implicit local user

Re: [PATCH] Fix NO_LOCAL_CLIENT_CRED build

Hi, Yes, I think so. Revised patch attached. I've tested this a few ways and it seems to be working correctly, but it's hard for me to be sure that this is doing the correct thing on all targets. Thanks for working on this! Seems right to me. My only comment is I think have_so_peercred

Re: [PATCH] Fix NO_LOCAL_CLIENT_CRED build

Hi, This is a build fix for MinGW ... Move the check if NO_LOCAL_CLIENT_CRED should be defined to before it's first use. Well, Alan wondered if anyone is actually using NO_LOCAL_CLIENT_CRED, now we know! Patch doesn't look wrong to me, but I wonder if maybe it should get put in

[PATCH] Fix NO_LOCAL_CLIENT_CRED build

This is a build fix for MinGW Commit 4b4b9086 os: support new implicit local user access mode [CVE-2015-3164 2/3] carefully places the relevant code it adds under !NO_LOCAL_CLIENT_CRED, but unfortunately doesn't notice that NO_LOCAL_CLIENT_CRED is defined as a side-effect in the middle of