Re: [PATCH] Fix XNextRequest() after direct usage of XCB

2014-05-12 Thread Jamey Sharp
On Sat, May 10, 2014 at 02:55:11PM +0200, Uli Schlachter wrote: On 10.05.2014 00:21, otay...@redhat.com wrote: From: Owen W. Taylor otay...@fishsoup.net When XCB owns the X socket, dpy-request is not updated, so NextRequest() and XNextRequest() return the wrong value. There's nothing

Re: [PATCH] Fix XNextRequest() after direct usage of XCB

2014-05-10 Thread Uli Schlachter
On 10.05.2014 00:21, otay...@redhat.com wrote: From: Owen W. Taylor otay...@fishsoup.net When XCB owns the X socket, dpy-request is not updated, so NextRequest() and XNextRequest() return the wrong value. There's nothing we can do to fix NextRequest() while retaining ABI compat, but change

[PATCH] Fix XNextRequest() after direct usage of XCB

2014-05-09 Thread otaylor
From: Owen W. Taylor otay...@fishsoup.net When XCB owns the X socket, dpy-request is not updated, so NextRequest() and XNextRequest() return the wrong value. There's nothing we can do to fix NextRequest() while retaining ABI compat, but change XNextRequest() to grab the socket back from XCB,

Re: [PATCH] Fix XNextRequest() after direct usage of XCB

2014-05-09 Thread Uli Schlachter
On 09.05.2014 22:33, otay...@redhat.com wrote: From: Owen W. Taylor otay...@fishsoup.net When XCB owns the X socket, dpy-request is not updated, so NextRequest() and XNextRequest() return the wrong value. There's nothing we can do to fix NextRequest() while retaining ABI compat, but change

[PATCH] Fix XNextRequest() after direct usage of XCB

2014-05-09 Thread otaylor
From: Owen W. Taylor otay...@fishsoup.net When XCB owns the X socket, dpy-request is not updated, so NextRequest() and XNextRequest() return the wrong value. There's nothing we can do to fix NextRequest() while retaining ABI compat, but change XNextRequest() to grab the socket back from XCB,

Re: [PATCH] Fix XNextRequest() after direct usage of XCB

2014-05-09 Thread Owen Taylor
Uli Schlachter wrote: unsigned long XNextRequest(Display *dpy) { +unsigned long next_request; +LockDisplay(dpy); +next_request = _XNextRequest(dpy); +UnlockDisplay(dpy); + return (NextRequest(dpy)); Unused variable next_request. Did you really mean to