Re: [PATCH] Fix crash when all glyphs of a given depth are freed, but not all glyphsets

2010-03-24 Thread Keith Packard
On Tue, 23 Mar 2010 12:39:30 -0400, Peter Harris phar...@opentext.com wrote: On 2010-03-23 12:26, Dan Nicholson wrote: I think Keith usually looks for an explicit CC to imply that patches are ready to be applied. I did CC: Keith. I'm just travelling; anything Cc'd to me ends up in my

Re: [PATCH] Fix crash when all glyphs of a given depth are freed, but not all glyphsets

2010-03-24 Thread Michel Dänzer
On Wed, 2010-03-24 at 13:03 +0100, Keith Packard wrote: On Tue, 23 Mar 2010 12:39:30 -0400, Peter Harris phar...@opentext.com wrote: On 2010-03-23 12:26, Dan Nicholson wrote: I think Keith usually looks for an explicit CC to imply that patches are ready to be applied. I did CC:

Re: [PATCH] Fix crash when all glyphs of a given depth are freed, but not all glyphsets

2010-03-23 Thread Michel Dänzer
On Mon, 2010-03-22 at 15:20 -0400, Peter Harris wrote: This is how the crash can be triggered with only two clients on the system: Client A: (already running) Client B: Connect Client B: CreateGlyphSet(depthN) Client A: Disconnect Server: free globalGlyphs(depthN) Client B:

Re: [PATCH] Fix crash when all glyphs of a given depth are freed, but not all glyphsets

2010-03-23 Thread Adam Jackson
On Mon, 2010-03-22 at 15:20 -0400, Peter Harris wrote: This crash was introduced with the FindGlyphsByHash function in 516b96387b0e57b524a37a96da22dbeeeb041712. Before that revision, ResizeGlyphSet was always called before FindGlyphRef, which would re-create globalGlyphs(depthN) if necessary.

Re: [PATCH] Fix crash when all glyphs of a given depth are freed, but not all glyphsets

2010-03-23 Thread Dan Nicholson
I think Keith usually looks for an explicit CC to imply that patches are ready to be applied. On Tue, Mar 23, 2010 at 9:08 AM, Peter Harris phar...@opentext.com wrote: This is how the crash can be triggered with only two clients on the system: Client A: (already running) Client B: Connect

Re: [PATCH] Fix crash when all glyphs of a given depth are freed, but not all glyphsets

2010-03-23 Thread Peter Harris
On 2010-03-23 12:26, Dan Nicholson wrote: I think Keith usually looks for an explicit CC to imply that patches are ready to be applied. I did CC: Keith. I also added the note as per http://www.x.org/wiki/XServer If a patch should be merged to master directly instead of going through a personal

[PATCH] Fix crash when all glyphs of a given depth are freed, but not all glyphsets

2010-03-22 Thread Peter Harris
This is how the crash can be triggered with only two clients on the system: Client A: (already running) Client B: Connect Client B: CreateGlyphSet(depthN) Client A: Disconnect Server: free globalGlyphs(depthN) Client B: AddGlyphs(depthN) Server: SEGV This crash was introduced with the