Re: [PATCH] Move event filter initializer out of the structure itself

2011-05-02 Thread Peter Hutterer
On Sun, Apr 24, 2011 at 12:55:05PM -0700, Alan Coopersmith wrote: > On 04/22/11 11:10 PM, Jamey Sharp wrote: > > On Fri, Apr 22, 2011 at 10:19:39PM -0700, Alan Coopersmith wrote: > >> When kept in the structure, it causes the entire MAXDEVICES * 128 masks > >> to be stored in the data segment and l

Re: [PATCH] Move event filter initializer out of the structure itself

2011-04-28 Thread Daniel Stone
On Fri, Apr 22, 2011 at 10:19:39PM -0700, Alan Coopersmith wrote: > When kept in the structure, it causes the entire MAXDEVICES * 128 masks > to be stored in the data segment and loaded from the file, and also leads > to worries about later generations inheriting changes across server reset. > >

Re: [PATCH] Move event filter initializer out of the structure itself

2011-04-24 Thread Alan Coopersmith
On 04/22/11 11:10 PM, Jamey Sharp wrote: > On Fri, Apr 22, 2011 at 10:19:39PM -0700, Alan Coopersmith wrote: >> When kept in the structure, it causes the entire MAXDEVICES * 128 masks >> to be stored in the data segment and loaded from the file, and also leads >> to worries about later generations

Re: [PATCH] Move event filter initializer out of the structure itself

2011-04-23 Thread Jeremy Huddleston
Looks correct (and cleaner) to me. Reviewed-by: Jeremy Huddleston On Apr 22, 2011, at 10:19 PM, Alan Coopersmith wrote: > When kept in the structure, it causes the entire MAXDEVICES * 128 masks > to be stored in the data segment and loaded from the file, and also leads > to worries about later

Re: [PATCH] Move event filter initializer out of the structure itself

2011-04-22 Thread Jamey Sharp
On Fri, Apr 22, 2011 at 10:19:39PM -0700, Alan Coopersmith wrote: > When kept in the structure, it causes the entire MAXDEVICES * 128 masks > to be stored in the data segment and loaded from the file, and also leads > to worries about later generations inheriting changes across server reset. Seems

[PATCH] Move event filter initializer out of the structure itself

2011-04-22 Thread Alan Coopersmith
When kept in the structure, it causes the entire MAXDEVICES * 128 masks to be stored in the data segment and loaded from the file, and also leads to worries about later generations inheriting changes across server reset. textdata bss dec hex filename Before: 91837 20