Re: [PATCH] Remove mibank wrapper

2010-04-27 Thread Adam Jackson
On Mon, 2010-04-26 at 20:10 -0700, Keith Packard wrote: On Tue, 5 Jan 2010 13:32:28 -0500, Adam Jackson a...@redhat.com wrote: Banked framebuffers are so 1990. As of 7.4 the only drivers remaining that used this were chips, neomagic, trident, and vesa. vesa only used it when not using

Re: [PATCH] Remove mibank wrapper

2010-04-26 Thread Keith Packard
On Tue, 5 Jan 2010 13:32:28 -0500, Adam Jackson a...@redhat.com wrote: Banked framebuffers are so 1990. As of 7.4 the only drivers remaining that used this were chips, neomagic, trident, and vesa. vesa only used it when not using shadowfb, which is broadly undesirable anyway, and no longer

Re: [PATCH] Remove mibank wrapper

2010-04-22 Thread Adam Jackson
Resend, dead code deletion. On Tue, 2010-01-05 at 13:32 -0500, Adam Jackson wrote: Banked framebuffers are so 1990. As of 7.4 the only drivers remaining that used this were chips, neomagic, trident, and vesa. vesa only used it when not using shadowfb, which is broadly undesirable anyway, and

Re: [PATCH] Remove mibank wrapper

2010-01-04 Thread Keith Packard
On Mon, 4 Jan 2010 15:32:49 -0500, Adam Jackson a...@redhat.com wrote: +static int +miScanLineWidth( Is there any driver still using this function? I'd rather see it disappear than live on without having any users. Also, if it does need to survive, the copyright messages from mibank.c will

Re: [PATCH] Remove mibank wrapper

2010-01-04 Thread Adam Jackson
On Mon, 2010-01-04 at 13:18 -0800, Keith Packard wrote: On Mon, 4 Jan 2010 15:32:49 -0500, Adam Jackson a...@redhat.com wrote: +static int +miScanLineWidth( Is there any driver still using this function? I'd rather see it disappear than live on without having any users. No driver uses

Re: [PATCH] Remove mibank wrapper

2010-01-04 Thread Keith Packard
On Mon, 04 Jan 2010 17:21:49 -0500, Adam Jackson a...@nwnk.net wrote: No driver uses it. But xf86ValidateModes (alone, hence static) does, which is why I moved it to xf86Mode.c. And does so in more than one place, so the factorization still makes sense. Sigh. And we still have drivers using

Re: [PATCH] Remove mibank wrapper

2010-01-04 Thread Dave Airlie
On Mon, 2010-01-04 at 17:46 -0800, Keith Packard wrote: On Mon, 04 Jan 2010 17:21:49 -0500, Adam Jackson a...@nwnk.net wrote: No driver uses it. But xf86ValidateModes (alone, hence static) does, which is why I moved it to xf86Mode.c. And does so in more than one place, so the