Re: [PATCH] Xi: fix valuator alignment in DeepCopyDeviceClasses (#36119)

2011-04-14 Thread Daniel Stone
Hi, On Thu, Apr 14, 2011 at 12:31:00PM +1000, Peter Hutterer wrote: On Tue, Apr 12, 2011 at 09:58:57AM +0100, Daniel Stone wrote: On Tue, Apr 12, 2011 at 11:05:56AM +1000, Peter Hutterer wrote: +/* force alignment with double */ +union align_u { ValuatorClassRec valc; double d; }

Re: [PATCH] Xi: fix valuator alignment in DeepCopyDeviceClasses (#36119)

2011-04-13 Thread Peter Hutterer
On Tue, Apr 12, 2011 at 09:58:57AM +0100, Daniel Stone wrote: Hi, On Tue, Apr 12, 2011 at 11:05:56AM +1000, Peter Hutterer wrote: +/* force alignment with double */ +union align_u { ValuatorClassRec valc; double d; } *align; Errr ... why not just allocate valc-axes separately

[PATCH] Xi: fix valuator alignment in DeepCopyDeviceClasses (#36119)

2011-04-11 Thread Peter Hutterer
commit 678f5396c91b3d0c7572ed579b0a4fb62b2b4655 only fixed the initialization, not the copy. After a slave device change, the valuator were out of alignment again. X.Org Bug 36119 http://bugs.freedesktop.org/show_bug.cgi?id=36119 Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- tbh,

Re: [PATCH] Xi: fix valuator alignment in DeepCopyDeviceClasses (#36119)

2011-04-11 Thread Jeremy Huddleston
Reviewed-by: Jeremy Huddleston jerem...@apple.com On Apr 11, 2011, at 18:05, Peter Hutterer wrote: commit 678f5396c91b3d0c7572ed579b0a4fb62b2b4655 only fixed the initialization, not the copy. After a slave device change, the valuator were out of alignment again. X.Org Bug 36119