Re: [PATCH] crash after setting root background pixmap to None, then setting color

2011-06-01 Thread Dave Airlie
On Thu, Jun 2, 2011 at 10:40 AM, Alan Coopersmith alan.coopersm...@oracle.com wrote: For what it's worth, this patch solved a crash reported by a user of my 1.10.1 packages when he ran xsetroot, so I'm pulling it into my 1.10.x packages and would also like to see it in 1.10-branch as well once

Re: [PATCH] crash after setting root background pixmap to None, then setting color

2011-06-01 Thread Keith Packard
On Thu, 2 Jun 2011 10:51:36 +1000, Dave Airlie airl...@gmail.com wrote: On Thu, Jun 2, 2011 at 10:40 AM, Alan Coopersmith alan.coopersm...@oracle.com wrote: For what it's worth, this patch solved a crash reported by a user of my 1.10.1 packages when he ran xsetroot, so I'm pulling it into

Re: [PATCH] crash after setting root background pixmap to None, then setting color

2011-06-01 Thread Keith Packard
On Wed, 01 Jun 2011 18:39:43 -0700, Keith Packard kei...@keithp.com wrote: On Thu, 2 Jun 2011 10:51:36 +1000, Dave Airlie airl...@gmail.com wrote: On Thu, Jun 2, 2011 at 10:40 AM, Alan Coopersmith alan.coopersm...@oracle.com wrote: For what it's worth, this patch solved a crash reported by

Re: [PATCH] crash after setting root background pixmap to None, then setting color

2011-06-01 Thread Jeremy Huddleston
Pulled into server-1.10-branch as well (normally I like patches to stew in master for a while, but it's already been shipping in Solaris, Fedora, and XQuartz...) 4bfb22e..5752cc4 server-1.10-branch - server-1.10-branch On Jun 1, 2011, at 6:47 PM, Keith Packard wrote: On Wed, 01 Jun 2011

Re: [PATCH] crash after setting root background pixmap to None, then setting color

2011-06-01 Thread Jeremy Huddleston
Yeah, it's on my list for 1.10 ... it's already in my server-1.10-apple branch that I use for XQuartz, so I won't loose it. I'll cherry-pick whatever lands in master. --Jeremy On Jun 1, 2011, at 5:40 PM, Alan Coopersmith wrote: For what it's worth, this patch solved a crash reported by a

Re: [PATCH] crash after setting root background pixmap to None, then setting color

2011-06-01 Thread Keith Packard
On Wed, 01 Jun 2011 18:47:17 -0700, Keith Packard kei...@keithp.com wrote: On Wed, 01 Jun 2011 18:39:43 -0700, Keith Packard kei...@keithp.com wrote: On Thu, 2 Jun 2011 10:51:36 +1000, Dave Airlie airl...@gmail.com wrote: On Thu, Jun 2, 2011 at 10:40 AM, Alan Coopersmith

Re: [PATCH] crash after setting root background pixmap to None, then setting color

2011-05-30 Thread Daniel Stone
Hi, On Sat, May 28, 2011 at 06:01:29PM -0700, Jeremy Huddleston wrote: I don't see it in your master branch: http://cgit.freedesktop.org/~daniels/xserver/log/ Your git repo also doesn't seem to know about that commit reference:

Re: [PATCH] crash after setting root background pixmap to None, then setting color

2011-05-28 Thread Jeremy Huddleston
I don't see it in your master branch: http://cgit.freedesktop.org/~daniels/xserver/log/ Your git repo also doesn't seem to know about that commit reference: http://cgit.freedesktop.org/~daniels/xserver/commit/?id=0701a18b51213ae588cbe82069c0b6eefb8deae7 Also, any thoughts that this could be