Re: [PATCH] dix: only transform valuators when we need them.

2011-05-04 Thread Peter Hutterer
On Wed, May 04, 2011 at 10:15:22AM +0200, Chase Douglas wrote: > On 05/03/2011 03:28 AM, Peter Hutterer wrote: > > On Mon, Apr 25, 2011 at 12:58:17PM -0400, Chase Douglas wrote: > >> On 04/21/2011 03:35 AM, Peter Hutterer wrote: > >>> Unconditionally drop the valuators back into the mask when they

Re: [PATCH] dix: only transform valuators when we need them.

2011-05-04 Thread Chase Douglas
On 05/03/2011 03:28 AM, Peter Hutterer wrote: > On Mon, Apr 25, 2011 at 12:58:17PM -0400, Chase Douglas wrote: >> On 04/21/2011 03:35 AM, Peter Hutterer wrote: >>> Unconditionally drop the valuators back into the mask when they were there >>> in the first place. Otherwise, sending identical coordin

Re: [PATCH] dix: only transform valuators when we need them.

2011-05-02 Thread Peter Hutterer
On Mon, Apr 25, 2011 at 12:58:17PM -0400, Chase Douglas wrote: > On 04/21/2011 03:35 AM, Peter Hutterer wrote: > > Unconditionally drop the valuators back into the mask when they were there > > in the first place. Otherwise, sending identical coordinates from the driver > > on a translated device c

Re: [PATCH] dix: only transform valuators when we need them.

2011-04-28 Thread Daniel Stone
On Mon, Apr 25, 2011 at 12:58:17PM -0400, Chase Douglas wrote: > Why don't we change this to: > > if (lround(p.v[0]) != dev->last.valuators[0]) > valuator_mask_set(mask, 0, lround(p.v[0])); > else > valuator_mask_unset(mask, 0); > > The proposed fix will cause valuators to be sent with re

Re: [PATCH] dix: only transform valuators when we need them.

2011-04-25 Thread Chase Douglas
On 04/21/2011 03:35 AM, Peter Hutterer wrote: > Unconditionally drop the valuators back into the mask when they were there > in the first place. Otherwise, sending identical coordinates from the driver > on a translated device causes the valuator mask to be alternatively > overwritten with the tran

Re: [PATCH] dix: only transform valuators when we need them.

2011-04-21 Thread Daniel Stone
On Thu, Apr 21, 2011 at 05:35:55PM +1000, Peter Hutterer wrote: > Unconditionally drop the valuators back into the mask when they were there > in the first place. Otherwise, sending identical coordinates from the driver > on a translated device causes the valuator mask to be alternatively > overwri

[PATCH] dix: only transform valuators when we need them.

2011-04-21 Thread Peter Hutterer
Unconditionally drop the valuators back into the mask when they were there in the first place. Otherwise, sending identical coordinates from the driver on a translated device causes the valuator mask to be alternatively overwritten with the translated value or left as-is. This leads to the device j