Re: [PATCH] exa: don't need to check for NULL pointer if we already assumed it has a value

2010-04-19 Thread Daniel Stone
On Sat, Apr 17, 2010 at 08:45:38AM -0700, Dan Nicholson wrote: It seems it would be better to check ps unless you're pretty sure pScreen always has a PictureScreen. Looking at this code showed me another bug. #ifdef RENDER PictureScreenPtrps = GetPictureScreenIfSet(pScreen);

[PATCH] exa: don't need to check for NULL pointer if we already assumed it has a value

2010-04-19 Thread Tiago Vignatti
the alternative would be to check ps in the beginning of the function. --- exa/exa.c | 14 ++ 1 files changed, 6 insertions(+), 8 deletions(-) diff --git a/exa/exa.c b/exa/exa.c index 590d9a5..b2bd1c5 100644 --- a/exa/exa.c +++ b/exa/exa.c @@ -779,14 +779,12 @@ exaCloseScreen(int

Re: [PATCH] exa: don't need to check for NULL pointer if we already assumed it has a value

2010-04-17 Thread Dan Nicholson
On Fri, Apr 16, 2010 at 8:42 AM, Tiago Vignatti tiago.vigna...@nokia.com wrote: the alternative would be to check ps in the beginning of the function. Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com ---  exa/exa.c |    2 --  1 files changed, 0 insertions(+), 2 deletions(-) diff

Re: [PATCH] exa: don't need to check for NULL pointer if we already assumed it has a value

2010-04-16 Thread Michel Dänzer
On Fre, 2010-04-16 at 18:42 +0300, Tiago Vignatti wrote: the alternative would be to check ps in the beginning of the function. Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- exa/exa.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/exa/exa.c