Re: [PATCH] fb: Use an indirect reference to the Screen Pixmap

2011-04-15 Thread Chris Wilson
On Fri, 15 Apr 2011 08:26:05 +1000, Dave Airlie airl...@gmail.com wrote: Why does the driver change the ScreenPixmap ptr? surely it would be just ModifyPixmapHeader or swapping the backing bo, or did I miss something in the explaination? In the case of pageflipping, we are replacing the

Re: [PATCH] fb: Use an indirect reference to the Screen Pixmap

2011-04-14 Thread Daniel Stone
Hi, On Wed, Mar 23, 2011 at 11:40:40AM +, Chris Wilson wrote: diff --git a/fb/fbscreen.c b/fb/fbscreen.c index 2502efe..392de81 100644 --- a/fb/fbscreen.c +++ b/fb/fbscreen.c @@ -87,7 +87,8 @@ _fbGetWindowPixmap (WindowPtr pWindow) void _fbSetWindowPixmap (WindowPtr pWindow,

Re: [PATCH] fb: Use an indirect reference to the Screen Pixmap

2011-04-14 Thread Dave Airlie
On Wed, Mar 23, 2011 at 9:40 PM, Chris Wilson ch...@chris-wilson.co.uk wrote: In an uncomposited Display, every window renders directly onto a clipped region of the Screen Pixmap. Currently every Window therefore has a pointer to the Screen Pixmap as its WindowPrivate. However, this direct

[PATCH] fb: Use an indirect reference to the Screen Pixmap

2011-03-23 Thread Chris Wilson
In an uncomposited Display, every window renders directly onto a clipped region of the Screen Pixmap. Currently every Window therefore has a pointer to the Screen Pixmap as its WindowPrivate. However, this direct reference prevents the propagation of the driver changing the Screen Pixmap - every