Pushed, thanks!
➜ xserver git:(master) git push
Counting objects: 4, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (4/4), done.
Writing objects: 100% (4/4), 791 bytes | 791.00 KiB/s, done.
Total 4 (delta 3), reused 0 (delta 0)
remote: Updating patchwork state for
The patch looks good to me just one question, I see that flink name
is returned as fd, so handle is what vmwgfx expecting in that case ?
Reviewed-by: Deepak Rawat
>
> KMS drivers are not required to support GEM. In particular, vmwgfx
> doesn't support flink and handles and names are identical.
Added to the modesetting pull request:
https://gitlab.freedesktop.org/lyudess/xserver/commit/49a2dae2dc45b4a144ae69be47a90ce6f4ca27f8
Thanks!
On Wed, 2018-06-20 at 20:18 +0200, Thomas Hellstrom wrote:
> On 06/20/2018 07:58 PM, Deepak Singh Rawat wrote:
> > The patch looks good to me just one
On 06/20/2018 07:58 PM, Deepak Singh Rawat wrote:
The patch looks good to me just one question, I see that flink name
is returned as fd, so handle is what vmwgfx expecting in that case ?
Yes. vmwgfx doesn't differentiate between handles and names.
/Thomas
Reviewed-by: Deepak Rawat
KMS
KMS drivers are not required to support GEM. In particular, vmwgfx
doesn't support flink and handles and names are identical.
Getting a bo name should really be part of a lower level API, if needed,
but in the mean time work around this by setting the name identical to
the handle if GEM isn't
