Re: [PATCH] glamor: fix crash when drawing nothing

Rob Clark writes: > On Wed, Oct 14, 2015 at 8:10 PM, Eric Anholt wrote: >> Rob Clark writes: >> >>> For example, in the PolyFillRect() path w/ nrect==0, we end up in >>> glamor_get_vbo_space(size=0): >> >> I wonder instead if we

Re: [PATCH] glamor: fix crash when drawing nothing

On Fri, Oct 16, 2015 at 11:07 AM, Keith Packard wrote: > Rob Clark writes: > >> On Wed, Oct 14, 2015 at 8:10 PM, Eric Anholt wrote: >>> Rob Clark writes: >>> For example, in the PolyFillRect() path w/ nrect==0,

[PATCH] glamor: fix crash when drawing nothing

For example, in the PolyFillRect() path w/ nrect==0, we end up in glamor_get_vbo_space(size=0): (gdb) bt #0 0x007fb73df340 in raise () from /lib64/libc.so.6 #1 0x007fb73e0fb8 in abort () from /lib64/libc.so.6 #2 0x007fb73d84f4 in __assert_fail_base () from

[PATCH] glamor: fix crash when drawing nothing

For example, in the PolyFillRect() path w/ nrect==0, we end up in glamor_get_vbo_space(size=0): (gdb) bt #0 0x007fb73df340 in raise () from /lib64/libc.so.6 #1 0x007fb73e0fb8 in abort () from /lib64/libc.so.6 #2 0x007fb73d84f4 in __assert_fail_base () from

Re: [PATCH] glamor: fix crash when drawing nothing

Rob Clark writes: > For example, in the PolyFillRect() path w/ nrect==0, we end up in > glamor_get_vbo_space(size=0): I wonder instead if we shouldn't just have glamor_get_vbo_space() return NULL on size == 0? signature.asc Description: PGP signature

Re: [PATCH] glamor: fix crash when drawing nothing

On Wed, Oct 14, 2015 at 8:10 PM, Eric Anholt wrote: > Rob Clark writes: > >> For example, in the PolyFillRect() path w/ nrect==0, we end up in >> glamor_get_vbo_space(size=0): > > I wonder instead if we shouldn't just have glamor_get_vbo_space() return >