Re: [PATCH] xwayland: Close the shm fd as early as possible

2016-09-28 Thread Daniel Stone
On 5 February 2016 at 14:25, Pekka Paalanen wrote: > On Fri, 5 Feb 2016 14:44:29 +0100 > Rui Matos wrote: > >> Keeping the shm fd open beyond pixmap creation means we can easily >> reach the open file descriptor limit if an X client asks us to create >> that many pixmaps. Instead, let's get the

Re: [PATCH] xwayland: Close the shm fd as early as possible

2016-09-09 Thread Olivier Fourdan
> > > [...] > > > > > > the idea here looks fine to me. > > > > > > However, I've been wondering, surely there was a reason why it wasn't > > > coded like this in the first place? > > > > > > Could you check if this patch causes Xwayland to create lots of > > > wl_buffers it will never attach an

Re: [PATCH] xwayland: Close the shm fd as early as possible

2016-09-06 Thread Olivier Fourdan
- Original Message - > Hi all, > > - Original Message - > > On Fri, 5 Feb 2016 14:44:29 +0100 > > Rui Matos wrote: > > > > > Keeping the shm fd open beyond pixmap creation means we can easily > > > reach the open file descriptor limit if an X client asks us to create > > > that

Re: [PATCH] xwayland: Close the shm fd as early as possible

2016-09-06 Thread Olivier Fourdan
Hi all, - Original Message - > On Fri, 5 Feb 2016 14:44:29 +0100 > Rui Matos wrote: > > > Keeping the shm fd open beyond pixmap creation means we can easily > > reach the open file descriptor limit if an X client asks us to create > > that many pixmaps. Instead, let's get the wl_buffer

Re: [PATCH] xwayland: Close the shm fd as early as possible

2016-02-05 Thread Pekka Paalanen
On Fri, 5 Feb 2016 14:44:29 +0100 Rui Matos wrote: > Keeping the shm fd open beyond pixmap creation means we can easily > reach the open file descriptor limit if an X client asks us to create > that many pixmaps. Instead, let's get the wl_buffer immediatly so that > we can destroy the shm pool a

[PATCH] xwayland: Close the shm fd as early as possible

2016-02-05 Thread Rui Matos
Keeping the shm fd open beyond pixmap creation means we can easily reach the open file descriptor limit if an X client asks us to create that many pixmaps. Instead, let's get the wl_buffer immediatly so that we can destroy the shm pool and close the fd before being asked to create more. --- On Fri