Re: [PATCH 09/12] glamor: Replace glamor_get/put_context() with just glamor_make_current().

2014-04-23 Thread Eric Anholt
Keith Packard kei...@keithp.com writes: Adam Jackson a...@nwnk.net writes: On Fri, 2014-04-18 at 11:40 -0700, Eric Anholt wrote: @@ -545,9 +541,8 @@ _glamor_copy_n_to_n(DrawablePtr src, fail: -glamor_get_context(glamor_priv); +glamor_make_current(glamor_priv);

Re: [PATCH 09/12] glamor: Replace glamor_get/put_context() with just glamor_make_current().

2014-04-23 Thread Keith Packard
Eric Anholt e...@anholt.net writes: Either of these rules sounds fine to me. And I'm wondering if #1 could actually be done with coccinelle. For now, I'd like this series to just be the mechanical change, though. (Particularly since 2/3 of the cases people noticed of weird make_current

Re: [PATCH 09/12] glamor: Replace glamor_get/put_context() with just glamor_make_current().

2014-04-22 Thread Adam Jackson
On Fri, 2014-04-18 at 11:40 -0700, Eric Anholt wrote: @@ -545,9 +541,8 @@ _glamor_copy_n_to_n(DrawablePtr src, fail: -glamor_get_context(glamor_priv); +glamor_make_current(glamor_priv); glamor_set_alu(screen, GXcopy); -glamor_put_context(glamor_priv); if (ok)

Re: [PATCH 09/12] glamor: Replace glamor_get/put_context() with just glamor_make_current().

2014-04-22 Thread Keith Packard
. [PATCH 08/12] glamor: Stop unsetting the EGL context in put_context(). [PATCH 09/12] glamor: Replace glamor_get/put_context() with just glamor_make_current(). [PATCH 10/12] glamor: Explain the weird EGL_NO_CONTEXT code. [PATCH 11/12] glamor: Do the same MakeCurrent(None) for GLX as we do for EGL

[PATCH 09/12] glamor: Replace glamor_get/put_context() with just glamor_make_current().

2014-04-18 Thread Eric Anholt
Now that we have the DIX global state for the current context, we don't need to track nesting to try to reduce MakeCurrent overhead. Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor.c | 6 ++ glamor/glamor_context.h | 9 + glamor/glamor_copyarea.c | 13