Re: [PATCH 1/1] dix: Silence TSan warnings when checking for pending input

Jeremy Huddleston Sequoia writes: > Ok, sent update for a final r-b. Done. > This also requires an updated release of xproto for the macros. I > sent that series out a few days ago but haven't had a review yet. Done. > Are there any other changes to xproto that might be

Re: [PATCH 1/1] dix: Silence TSan warnings when checking for pending input

Jeremy Huddleston Sequoia writes: > V2: Moves InputCheckPending() into dix.h > > Bumps required version of xproto to 7.0.30 LGTM. Reviewed-by: Keith Packard -- -keith signature.asc Description: PGP signature

Re: [PATCH 1/1] dix: Silence TSan warnings when checking for pending input

> On Sep 22, 2016, at 11:26, Keith Packard wrote: > > Jeremy Huddleston Sequoia writes: > >> I would've but we're post API freeze at this point, yes? Would that be ok? > > Yeah, better than duplicating, and it doesn't affect the actual ABI/API > seen

[PATCH 1/1] dix: Silence TSan warnings when checking for pending input

V2: Moves InputCheckPending() into dix.h Bumps required version of xproto to 7.0.30 == WARNING: ThreadSanitizer: data race (pid=4943) Read of size 4 at 0x00010c4e3854 by thread T8: #0 WaitForSomething WaitFor.c:237 (X11.bin+0x00010049216c) #1 Dispatch dispatch.c:413

Re: [PATCH 1/1] dix: Silence TSan warnings when checking for pending input

Jeremy Huddleston Sequoia writes: > I would've but we're post API freeze at this point, yes? Would that be ok? Yeah, better than duplicating, and it doesn't affect the actual ABI/API seen to drivers. -- -keith signature.asc Description: PGP signature

Re: [PATCH 1/1] dix: Silence TSan warnings when checking for pending input

> On Sep 22, 2016, at 00:22, Keith Packard wrote: > > Jeremy Huddleston Sequoia writes: > >> +static inline _X_NOTSAN Bool >> +InputCheckPending(void) >> +{ >> +return (*checkForInput[0] != *checkForInput[1]); >> +} > >> +static inline _X_NOTSAN

Re: [PATCH 1/1] dix: Silence TSan warnings when checking for pending input

Jeremy Huddleston Sequoia writes: > +static inline _X_NOTSAN Bool > +InputCheckPending(void) > +{ > +return (*checkForInput[0] != *checkForInput[1]); > +} > +static inline _X_NOTSAN Bool > +InputCheckPending(void) > +{ > +return (*checkForInput[0] !=

[PATCH 1/1] dix: Silence TSan warnings when checking for pending input

Bumps required version of xproto to 7.0.30 == WARNING: ThreadSanitizer: data race (pid=4943) Read of size 4 at 0x00010c4e3854 by thread T8: #0 WaitForSomething WaitFor.c:237 (X11.bin+0x00010049216c) #1 Dispatch dispatch.c:413 (X11.bin+0x000100352ed9) #2 dix_main