Re: [PATCH 1/2] glamor_*gl_has_extension: Move strlen after check for NULL string

2014-03-13 Thread Alan Coopersmith
On 03/13/14 11:40 AM, Eric Anholt wrote: Keith Packard writes: Alan Coopersmith writes: Flagged by cppcheck 1.64: [glamor/glamor_core.c:536] -> [glamor/glamor_core.c:540]: (warning) Possible null pointer dereference: extension - otherwise it is redundant to check it agai

Re: [PATCH 1/2] glamor_*gl_has_extension: Move strlen after check for NULL string

2014-03-13 Thread Eric Anholt
Keith Packard writes: > Alan Coopersmith writes: > >> Flagged by cppcheck 1.64: >> [glamor/glamor_core.c:536] -> [glamor/glamor_core.c:540]: >> (warning) Possible null pointer dereference: extension - otherwise >> it is redundant to check it against null. >> [glamor/glamor_egl.

Re: [PATCH 1/2] glamor_*gl_has_extension: Move strlen after check for NULL string

2014-03-11 Thread Keith Packard
Alan Coopersmith writes: > Flagged by cppcheck 1.64: > [glamor/glamor_core.c:536] -> [glamor/glamor_core.c:540]: > (warning) Possible null pointer dereference: extension - otherwise > it is redundant to check it against null. > [glamor/glamor_egl.c:620] -> [glamor/glamor_egl.c:6

[PATCH 1/2] glamor_*gl_has_extension: Move strlen after check for NULL string

2014-03-11 Thread Alan Coopersmith
Flagged by cppcheck 1.64: [glamor/glamor_core.c:536] -> [glamor/glamor_core.c:540]: (warning) Possible null pointer dereference: extension - otherwise it is redundant to check it against null. [glamor/glamor_egl.c:620] -> [glamor/glamor_egl.c:622]: (warning) Possible null poin

Re: [PATCH 1/2] glamor_*gl_has_extension: Move strlen after check for NULL string

2014-03-08 Thread Eric Anholt
Alan Coopersmith writes: > Flagged by cppcheck 1.64: > [glamor/glamor_core.c:536] -> [glamor/glamor_core.c:540]: > (warning) Possible null pointer dereference: extension - otherwise > it is redundant to check it against null. > [glamor/glamor_egl.c:620] -> [glamor/glamor_egl.c:622

[PATCH 1/2] glamor_*gl_has_extension: Move strlen after check for NULL string

2014-03-08 Thread Alan Coopersmith
Flagged by cppcheck 1.64: [glamor/glamor_core.c:536] -> [glamor/glamor_core.c:540]: (warning) Possible null pointer dereference: extension - otherwise it is redundant to check it against null. [glamor/glamor_egl.c:620] -> [glamor/glamor_egl.c:622]: (warning) Possible null poin