Re: [PATCH 1/4] xserver: Use lists and constants for matching modes in Match entries

2011-06-08 Thread Dan Nicholson
On Sat, Jun 4, 2011 at 10:48 PM, Oleh Nykyforchyn oleh@gmail.com wrote: Use lists and constants for matching modes in Match entries You're leaving out some critical information here. Particularly that each Match entry would take multiple arguments. I'm going to ignore those details for now

Re: [PATCH 1/4] xserver: Use lists and constants for matching modes in Match entries

2011-06-08 Thread Oleh Nykyforchyn
On Wed, 8 Jun 2011 10:39:40 -0700 Dan Nicholson dbn.li...@gmail.com wrote: On Sat, Jun 4, 2011 at 10:48 PM, Oleh Nykyforchyn oleh@gmail.com wrote: Use lists and constants for matching modes in Match entries You're leaving out some critical information here. Particularly that each Match

Re: [PATCH 1/4] xserver: Use lists and constants for matching modes in Match entries

2011-06-08 Thread Oleh Nykyforchyn
On Wed, 8 Jun 2011 10:39:40 -0700 Dan Nicholson dbn.li...@gmail.com wrote: Why did you change all the breaks to continues? If there was code below the switch you'd be skipping it. Sorry, You are right, it does not matter here. Oleh ___

Re: [PATCH 1/4] xserver: Use lists and constants for matching modes in Match entries

2011-06-08 Thread Peter Hutterer
On Wed, Jun 08, 2011 at 11:58:20PM +0300, Oleh Nykyforchyn wrote: On Wed, 8 Jun 2011 10:39:40 -0700 Dan Nicholson dbn.li...@gmail.com wrote: On Sat, Jun 4, 2011 at 10:48 PM, Oleh Nykyforchyn oleh@gmail.com wrote: Use lists and constants for matching modes in Match entries

Re: [PATCH 1/4] xserver: Use lists and constants for matching modes in Match entries

2011-06-07 Thread Peter Hutterer
On Sun, Jun 05, 2011 at 08:48:34AM +0300, Oleh Nykyforchyn wrote: Use lists and constants for matching modes in Match entries this is code that few people if ever look at. Please extend the commit message to a point that it clearly describes what is done here. Also, see my argument in the other

[PATCH 1/4] xserver: Use lists and constants for matching modes in Match entries

2011-06-05 Thread Oleh Nykyforchyn
Use lists and constants for matching modes in Match entries Signed-off-by: Oleh Nykyforchyn oleh@gmail.com --- hw/xfree86/common/xf86Xinput.c | 117 +++--- hw/xfree86/parser/InputClass.c | 336 +--- hw/xfree86/parser/xf86Parser.h | 23 +++- 3