Re: [PATCH 10/20] Switch to use IsFloating()

2011-02-22 Thread Peter Hutterer
On Tue, Feb 22, 2011 at 08:17:32AM +0100, Benjamin Tissoires wrote: Hi Peter, Except two unnecessary parenthesis here, you can add my Reviewed-by for the series ;) On 02/18/2011 04:52 AM, Peter Hutterer wrote: [...] diff --git a/Xi/xipassivegrab.c b/Xi/xipassivegrab.c index

Re: [PATCH 10/20] Switch to use IsFloating()

2011-02-22 Thread Benjamin Tissoires
On 02/22/2011 11:31 PM, Peter Hutterer wrote: On Tue, Feb 22, 2011 at 08:17:32AM +0100, Benjamin Tissoires wrote: Hi Peter, Except two unnecessary parenthesis here, you can add my Reviewed-by for the series ;) On 02/18/2011 04:52 AM, Peter Hutterer wrote: [...] diff --git

Re: [PATCH 10/20] Switch to use IsFloating()

2011-02-21 Thread Benjamin Tissoires
Hi Peter, Except two unnecessary parenthesis here, you can add my Reviewed-by for the series ;) On 02/18/2011 04:52 AM, Peter Hutterer wrote: This is not a straightforward search/replacement due to a long-standing issue. dev-u.master is the same field as dev-u.lastSlave. Thus, if dev is a

[PATCH 10/20] Switch to use IsFloating()

2011-02-17 Thread Peter Hutterer
This is not a straightforward search/replacement due to a long-standing issue. dev-u.master is the same field as dev-u.lastSlave. Thus, if dev is a master device, a check for dev-u.master may give us false positives and false negatives. The switch to IsFloating() spells out these cases and