Re: [PATCH 16/16] xv: Remove the pScreen from the XV encodings.

2014-07-30 Thread Eric Anholt
Keith Packard writes: > Eric Anholt writes: > >> It was never used, and it meant a bunch of pointless frobbing of >> structure members between the DDX and DIX. > > This will generate warnings when initializing the (char *) name field > From a constant string. > > One option would be to just make

Re: [PATCH 16/16] xv: Remove the pScreen from the XV encodings.

2014-07-18 Thread Keith Packard
Eric Anholt writes: > It was never used, and it meant a bunch of pointless frobbing of > structure members between the DDX and DIX. This will generate warnings when initializing the (char *) name field From a constant string. One option would be to just make that 'const' and then stop strdup'in

[PATCH 16/16] xv: Remove the pScreen from the XV encodings.

2014-07-18 Thread Eric Anholt
It was never used, and it meant a bunch of pointless frobbing of structure members between the DDX and DIX. Signed-off-by: Eric Anholt --- Xext/xvdix.h | 1 - hw/kdrive/ephyr/ephyr_glamor_xv.c | 2 +- hw/kdrive/ephyr/ephyrvideo.c | 2 +- hw/kdrive/src/kxv.c