[PATCH 2/2] Remove duplicate assignment of repeat_type_uniform_location

2014-03-11 Thread Alan Coopersmith
Flagged by cppcheck 1.64: [glamor/glamor_gradient.c:987] -> [glamor/glamor_gradient.c:991]: (performance) Variable 'repeat_type_uniform_location' is reassigned a value before the old one has been used. Signed-off-by: Alan Coopersmith Reviewed-by: Eric Anholt --- glamor/glamor_g

Re: [PATCH 2/2] Remove duplicate assignment of repeat_type_uniform_location

2014-03-08 Thread Alan Coopersmith
cppcheck also flagged another instance in glamor for which I wasn't sure which value was right: [glamor/glamor_xv.c:301] -> [glamor/glamor_xv.c:316]: (performance) Variable 'gamma' is reassigned a value before the old one has been used. In glamor_display_textured_video() in this function, the c

[PATCH 2/2] Remove duplicate assignment of repeat_type_uniform_location

2014-03-08 Thread Alan Coopersmith
Flagged by cppcheck 1.64: [glamor/glamor_gradient.c:987] -> [glamor/glamor_gradient.c:991]: (performance) Variable 'repeat_type_uniform_location' is reassigned a value before the old one has been used. Signed-off-by: Alan Coopersmith --- glamor/glamor_gradient.c |2 -- 1 fil