Re: [PATCH 2/4] glx: Fix memory leak in context garbage collection (v2)

2013-10-08 Thread Ian Romanick
On 10/02/2013 02:51 PM, Adam Jackson wrote: I broke this, back in: commit a48dadc98a28c969741979b70b7a639f24f4cbbd Author: Adam Jackson a...@redhat.com Date: Mon Mar 21 11:59:29 2011 -0400 glx: Reimplement context tags In that, I changed the glx client state to not

Re: [PATCH 2/4] glx: Fix memory leak in context garbage collection (v2)

2013-10-08 Thread Mouse
--- a/glx/createcontext.c +++ b/glx/createcontext.c @@ -320,7 +320,7 @@ __glXDisp_CreateContextAttribsARB(__GLXclientState * cl, GLbyte * pc) ctx-id = req-context; ctx-share_id = req-shareList; ctx-idExists = True; -ctx-isCurrent = False; +ctx-currentClient =

Re: [PATCH 2/4] glx: Fix memory leak in context garbage collection (v2)

2013-10-08 Thread Ian Romanick
On 10/08/2013 10:19 AM, Mouse wrote: --- a/glx/createcontext.c +++ b/glx/createcontext.c @@ -320,7 +320,7 @@ __glXDisp_CreateContextAttribsARB(__GLXclientState * cl, GLbyte * pc) ctx-id = req-context; ctx-share_id = req-shareList; ctx-idExists = True; -ctx-isCurrent =

Re: [PATCH 2/4] glx: Fix memory leak in context garbage collection (v2)

2013-10-08 Thread Mouse
-ctx-isCurrent = False; +ctx-currentClient = False; Should this maybe be 0 instead of False? Good catch. It's just luck that False is #defined as 0. :) It should, of course, be NULL. Well, I'd actually disagree; I think NULL should never be used - see my blah post of 2009-10-09

Re: [PATCH 2/4] glx: Fix memory leak in context garbage collection (v2)

2013-10-08 Thread Daniel Stone
Hi, On 8 October 2013 19:22, Mouse mo...@rodents-montreal.org wrote: Good catch. It's just luck that False is #defined as 0. :) It should, of course, be NULL. Well, I'd actually disagree; I think NULL should never be used - see my blah post of 2009-10-09

[PATCH 2/4] glx: Fix memory leak in context garbage collection (v2)

2013-10-02 Thread Adam Jackson
I broke this, back in: commit a48dadc98a28c969741979b70b7a639f24f4cbbd Author: Adam Jackson a...@redhat.com Date: Mon Mar 21 11:59:29 2011 -0400 glx: Reimplement context tags In that, I changed the glx client state to not explicitly track the list of current contexts for