Re: [PATCH 21/27] glamor: Improve the performance of PushPixels by, well, pushing pixels.

2014-03-13 Thread Eric Anholt
Markus Wick mar...@selfnet.de writes: I didn't find any issues in this patch, but I don't see the point: Do we really want to convert a pixmap with 1 bit per pixel into a list of enabled pixels on cpu? Isn't it as easy to upload this pixmap as texture and do everything else in the pixel

Re: [PATCH 21/27] glamor: Improve the performance of PushPixels by, well, pushing pixels.

2014-03-12 Thread Markus Wick
I didn't find any issues in this patch, but I don't see the point: Do we really want to convert a pixmap with 1 bit per pixel into a list of enabled pixels on cpu? Isn't it as easy to upload this pixmap as texture and do everything else in the pixel shader? In this way, we won't have to care

[PATCH 21/27] glamor: Improve the performance of PushPixels by, well, pushing pixels.

2014-03-11 Thread Eric Anholt
Otherwise, mi will fall back to GetSpans()ing the bitmap, walking the bitmap, computing spans to be filled, and calling FillSpans(). Improves x11perf -f8text by 759.373% +/- 3.33096% (n=166) Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_glyphblt.c | 115