Re: [PATCH 3/4] xfree86: warning fix

2011-03-15 Thread Dan Nicholson
On Tue, Mar 15, 2011 at 8:37 AM, Keith Packard wrote: > On Tue, 15 Mar 2011 11:05:06 -0400, Adam Jackson wrote: > >> -                             if (asprintf(&s, "%ul %ul", val1, val.num) == >> -1) >> +                             if (asprintf(&s, "%lu %u", val1, val.num) == >> -1) > > Review

Re: [PATCH 3/4] xfree86: warning fix

2011-03-15 Thread Keith Packard
On Tue, 15 Mar 2011 11:05:06 -0400, Adam Jackson wrote: > - if (asprintf(&s, "%ul %ul", val1, val.num) == > -1) > + if (asprintf(&s, "%lu %u", val1, val.num) == -1) Reviewed-by: Keith Packard (as an aside, I was amused to find that 'val'

[PATCH 3/4] xfree86: warning fix

2011-03-15 Thread Adam Jackson
Pointer.c: In function 'xf86parsePointerSection': Pointer.c:192:5: warning: format '%u' expects type 'unsigned int', but argument 3 has type 'long unsigned int' Signed-off-by: Adam Jackson --- hw/xfree86/parser/Pointer.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/