Re: [PATCH 4/4] glamor: Drop a bunch of glamor_priv == NULL checks.

2015-07-08 Thread Eric Anholt
Keith Packard kei...@keithp.com writes: Eric Anholt e...@anholt.net writes: Now that it's always non-null when the pixmap is non-null, we don't need so much of this. glamor_get_pixmap_private() itself still accepts a NULL pixmap and returns NULL, because of glamor_render.c Might want to

Re: [PATCH 4/4] glamor: Drop a bunch of glamor_priv == NULL checks.

2015-07-08 Thread Keith Packard
Eric Anholt e...@anholt.net writes: Now that it's always non-null when the pixmap is non-null, we don't need so much of this. glamor_get_pixmap_private() itself still accepts a NULL pixmap and returns NULL, because of glamor_render.c Might want to change glamor_pixmap_type to explicitly make

Re: [PATCH 4/4] glamor: Drop a bunch of glamor_priv == NULL checks.

2015-07-08 Thread Eric Anholt
Michel Dänzer mic...@daenzer.net writes: On 08.07.2015 09:26, Eric Anholt wrote: diff --git a/glamor/glamor_utils.h b/glamor/glamor_utils.h index 0a7de82..a923b7a 100644 --- a/glamor/glamor_utils.h +++ b/glamor/glamor_utils.h @@ -756,8 +756,8 @@ glamor_translate_boxes(BoxPtr boxes, int

[PATCH 4/4] glamor: Drop a bunch of glamor_priv == NULL checks.

2015-07-07 Thread Eric Anholt
Now that it's always non-null when the pixmap is non-null, we don't need so much of this. glamor_get_pixmap_private() itself still accepts a NULL pixmap and returns NULL, because of glamor_render.c Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor.c | 17 ++---

Re: [PATCH 4/4] glamor: Drop a bunch of glamor_priv == NULL checks.

2015-07-07 Thread Michel Dänzer
On 08.07.2015 09:26, Eric Anholt wrote: diff --git a/glamor/glamor_utils.h b/glamor/glamor_utils.h index 0a7de82..a923b7a 100644 --- a/glamor/glamor_utils.h +++ b/glamor/glamor_utils.h @@ -756,8 +756,8 @@ glamor_translate_boxes(BoxPtr boxes, int nbox, int dx, int dy)