Re: [PATCH 4/4] xf86: reimplement XF86SCRNINFO macro using new functions.

2012-05-17 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: This patch drops all in-server uses, we should drop the macro later, once drivers have been converted to not use it. There aren't many drivers using it at least... Signed-off-by: Dave Airlie airl...@redhat.com Reviewed-by: Keith Packard

Re: [PATCH 4/4] xf86: reimplement XF86SCRNINFO macro using new functions.

2012-05-15 Thread Keith Packard
On Mon, 14 May 2012 13:00:23 +0100, Dave Airlie airl...@gmail.com wrote: - -/* This can get called before the ScrnInfoRec is installed so we - can't rely on getting it with XF86SCRNINFO() */ int scrnIndex = pmap-pScreen-myNum; ScrnInfoPtr scrninfp =

Re: [PATCH 4/4] xf86: reimplement XF86SCRNINFO macro using new functions.

2012-05-15 Thread Dave Airlie
- -    /* This can get called before the ScrnInfoRec is installed so we -       can't rely on getting it with XF86SCRNINFO() */      int scrnIndex = pmap-pScreen-myNum;      ScrnInfoPtr scrninfp = xf86ScreenToScrn(pmap-pScreen);      vgaHWPtr hwp = VGAHWPTR(scrninfp); Your new macro can

[PATCH 4/4] xf86: reimplement XF86SCRNINFO macro using new functions.

2012-05-14 Thread Dave Airlie
This macro did lookups via privates but we can just use the ScreenToScrn conversion instead. This patch drops all in-server uses, we should drop the macro later, once drivers have been converted to not use it. Signed-off-by: Dave Airlie airl...@redhat.com --- hw/xfree86/common/xf86.h |