Re: [PATCH 4/5] glx: Implement GLX_PRESERVED_CONTENTS drawable attribute

2013-03-07 Thread Tomasz Lis
I agree with Ian's proposition to add integer counter which replaces hard-coded index. This also allows to add: assert(i = sizeof(attribs)/sizeof(attribs[0])) While both GLX 1.4 spec and older GLX_SGIX_pbuffer do not mention what value to return if GLX_PRESERVED_CONTENTS is unset on creation,

Re: [PATCH 4/5] glx: Implement GLX_PRESERVED_CONTENTS drawable attribute

2013-02-28 Thread Ian Romanick
On 02/25/2013 02:04 PM, Adam Jackson wrote: We back pixmaps with pbuffers so they're never actually clobbered, so we're really just recording the value passed in at create time so that you get the same thing when you query. Is that actually right? There are some cases where they query returns

Re: [PATCH 4/5] glx: Implement GLX_PRESERVED_CONTENTS drawable attribute

2013-02-26 Thread Adam Jackson
On Mon, 2013-02-25 at 23:10 -0800, Eric Anholt wrote: Adam Jackson a...@redhat.com writes: We back pixmaps with pbuffers so they're never actually clobbered, so we're really just recording the value passed in at create time so that you get the same thing when you query. I guess I'm not

[PATCH 4/5] glx: Implement GLX_PRESERVED_CONTENTS drawable attribute

2013-02-25 Thread Adam Jackson
We back pixmaps with pbuffers so they're never actually clobbered, so we're really just recording the value passed in at create time so that you get the same thing when you query. Signed-off-by: Adam Jackson a...@redhat.com --- glx/glxcmds.c | 90

Re: [PATCH 4/5] glx: Implement GLX_PRESERVED_CONTENTS drawable attribute

2013-02-25 Thread Eric Anholt
Adam Jackson a...@redhat.com writes: We back pixmaps with pbuffers so they're never actually clobbered, so we're really just recording the value passed in at create time so that you get the same thing when you query. I guess I'm not clear on this one why we wouldn't just always say that we