[PATCH 4/6] fb: Avoid installing terminal functions over pre-existing call chains

2014-05-28 Thread Chris Wilson
The fbWindow family of functions (Map, Unmap, Position and Destroy) are all terminal functions, that is they do not chain up to earlier extensions. This breaks those chains which leads to not only resource leaks but also dereference of dangling pointers. One such issue arises with fbScreenInit()

Re: [PATCH 4/6] fb: Avoid installing terminal functions over pre-existing call chains

2014-05-28 Thread Keith Packard
Chris Wilson ch...@chris-wilson.co.uk writes: The fbWindow family of functions (Map, Unmap, Position and Destroy) are all terminal functions, that is they do not chain up to earlier extensions. This breaks those chains which leads to not only resource leaks but also dereference of dangling

Re: [PATCH 4/6] fb: Avoid installing terminal functions over pre-existing call chains

2014-05-28 Thread Chris Wilson
On Wed, May 28, 2014 at 01:31:50AM -0700, Keith Packard wrote: Chris Wilson ch...@chris-wilson.co.uk writes: The fbWindow family of functions (Map, Unmap, Position and Destroy) are all terminal functions, that is they do not chain up to earlier extensions. This breaks those chains which

Re: [PATCH 4/6] fb: Avoid installing terminal functions over pre-existing call chains

2014-05-28 Thread Keith Packard
Chris Wilson ch...@chris-wilson.co.uk writes: Hmm, the sequence I have in UXA is wrong then. Sounds like it. -- keith.pack...@intel.com pgpEBgGl9_Loj.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives:

Re: [PATCH 4/6] fb: Avoid installing terminal functions over pre-existing call chains

2014-05-28 Thread Chris Wilson
On Wed, May 28, 2014 at 02:15:58AM -0700, Keith Packard wrote: Chris Wilson ch...@chris-wilson.co.uk writes: Hmm, the sequence I have in UXA is wrong then. Sounds like it. Indeed, that was easy enough to resolve once I knew to look in the right place. Thanks, -Chris -- Chris Wilson,