Re: [PATCH 5/5] xwayland: Pixmap flips of child windows on sub-surfaces

2017-08-30 Thread Michel Dänzer
On 30/08/17 06:11 PM, Roman Gilg wrote: > Sorry, apparently I didn't understand your explanation the last time. > Can you explain why non-Present requests need to see the sub-surface > contents? Because the semantics of PresentPixmap are that the contents of the source pixmap become part of the

Fwd: [PATCH 5/5] xwayland: Pixmap flips of child windows on sub-surfaces

2017-08-30 Thread Roman Gilg
Sorry, apparently I didn't understand your explanation the last time. Can you explain why non-Present requests need to see the sub-surface contents? And how they see the contents of normal Wayland surfaces? I don't see much of a difference in here. Both objects are black boxes in terms of X and

Re: [PATCH 5/5] xwayland: Pixmap flips of child windows on sub-surfaces

2017-08-29 Thread Michel Dänzer
On 30/08/17 12:24 AM, Roman Gilg wrote: > This patch enables Pixmap flips for child windows via Wayland > sub-surfaces. That can't be done so easily for the reasons I've explained before (basically, non-Present requests would need to "see" the subsurface contents as well), so I'm afraid I have to

Re: [PATCH 5/5] xwayland: Pixmap flips of child windows on sub-surfaces

2017-08-29 Thread Roman Gilg
There is a mistake in the patch description since the mentioned small change to the Present extension code wasn't necessary in the end. So I reverted the change, but forgot about the description. On Tue, Aug 29, 2017 at 5:24 PM, Roman Gilg wrote: > This patch enables Pixmap

[PATCH 5/5] xwayland: Pixmap flips of child windows on sub-surfaces

2017-08-29 Thread Roman Gilg
This patch enables Pixmap flips for child windows via Wayland sub-surfaces. If the Wayland compositor doesn't support sub-surfaces we fall back to flips without sub-surfaces when possible as before. A small change to Present is necessary, to restore the window pixmap correctly after an unflip