Re: [PATCH 5/6] Add DRI3

2013-11-06 Thread Adam Jackson
On Tue, 2013-11-05 at 16:39 -0800, Keith Packard wrote: + request name=Open opcode=1 +field type=WINDOW name=window / +field type=CARD32 name=provider / +reply + field type=CARD8 name=nfd/ + fd name=device_fd / + pad bytes=24 / +/reply + /request There's

Re: [PATCH 5/6] Add DRI3

2013-11-06 Thread Peter Harris
On 2013-11-05 19:39, Keith Packard wrote: diff --git a/src/xproto.xml b/src/xproto.xml index bf4dcbf..c9f6979 100644 --- a/src/xproto.xml +++ b/src/xproto.xml @@ -1080,7 +1080,24 @@ The number of keycodes altered. /doc /event - + event name=ge number=35 +field type=CARD8

Re: [PATCH 5/6] Add DRI3

2013-11-06 Thread Keith Packard
Adam Jackson a...@nwnk.net writes: There's not much semantic difference, but the protocol text says Drawable not Window. Thanks, easily fixed. The protocol spec is ambiguous here? Section A.2 still seems to reference CARD32 driver_type and driver name and whatnot. Sorry, I didn't review

Re: [PATCH 5/6] Add DRI3

2013-11-06 Thread Keith Packard
Peter Harris phar...@opentext.com writes: I'm curious about this hunk. It isn't hurting anything, but I don't see where it would be needed or used. xcb.h already has xcb_ge_event_t. Is this hunk solely for the doc section? Or for the #define XCB_GE 35 ? My libxcb commits remove the

[PATCH 5/6] Add DRI3

2013-11-05 Thread Keith Packard
Signed-off-by: Keith Packard kei...@keithp.com --- src/Makefile.am | 1 + src/dri3.xml | 97 src/xproto.xml | 19 ++- xcbgen/xtypes.py | 24 ++ 4 files changed, 140 insertions(+), 1 deletion(-) create mode