I've gone ahead and put up a merge request for review with both patches in:
https://gitlab.freedesktop.org/xorg/lib/libx11/-/merge_requests/173
Thanks for these fixes,
-alan-
On 11/30/22 16:50, Alan Coopersmith wrote:
It looks like we updated the Workflow Overview section at the
It looks like we updated the Workflow Overview section at the beginning
to mention "Create a merge request in the freedesktop.org gitlab", but
someone still needs to update the later sections of the document to cover
that and remove the email instructions. Sorry about the confusion here.
Well, then the documentation is wrong, I tried to follow this:
https://www.x.org/wiki/Development/Documentation/SubmittingPatches/
which clearly talks about sending patches to the ML, but at the same time
mentioning gitlab without mentioning merge requests. Would have preferred a
gitlab MR
On 11/30/22 14:42, Ulrich Sibiller wrote:
Resent due to gmail mangling tabs.. Seems impossible nowadays to send a
plaintext mail unmodifed using gmail's web interface...
Just one of many reasons we prefer patches to be sent as merge requests on
https://gitlab.freedesktop.org/xorg/lib/libx11
] Indention fixes around recent dpy->in_ifevent
changes
Use the same indention as the surrounding code.
Signed-off-by: Ulrich Sibiller
---
src/ChkIfEv.c | 6 +++---
src/IfEvent.c | 6 +++---
src/OpenDis.c | 2 +-
src/PeekIfEv.c | 4 ++--
src/locking.c | 16
5 files changed,
>From 35072d172d0bfecb24fdd8437ecdcd0e391e1f14 Mon Sep 17 00:00:00 2001
From: Ulrich Sibiller
Date: Wed, 30 Nov 2022 22:18:42 +0100
Subject: [PATCH libX11 1/2] Indention fixes around recent
dpy->in_ifevent changes
Use the same indention as the surrounding code.
Signed-off-by: Ulrich Si
