Re: [PATCH libXi] Don't use raw serial numbers in XIEvents

2015-10-19 Thread Peter Hutterer
On Mon, Oct 19, 2015 at 04:28:12PM -0700, Jasper St. Pierre wrote: > On Sun, Oct 18, 2015 at 7:59 PM, Peter Hutterer > wrote: > > cookie->serial is an Xlib contoction, provided by _XSetLastRequestRead(). > > This > > I assume this is meant to read "in->sequenceNumber

Re: [PATCH libXi] Don't use raw serial numbers in XIEvents

2015-10-19 Thread Jasper St. Pierre
On Sun, Oct 18, 2015 at 7:59 PM, Peter Hutterer wrote: > cookie->serial is an Xlib contoction, provided by _XSetLastRequestRead(). This I assume this is meant to read "in->sequenceNumber is an Xlib concoction"? Otherwise, it doesn't make sense. > serial may be

[PATCH libXi] Don't use raw serial numbers in XIEvents

2015-10-18 Thread Peter Hutterer
cookie->serial is an Xlib contoction, provided by _XSetLastRequestRead(). This serial may be different to the raw serial number from the wire protocol. This causes issues when the raw serial is used to e.g. compare the event to other non-XI events. Use the cookie's serial number instead.