Re: [PATCH libXi 7/7] Refactor XGetExtensionVersion.

2014-11-02 Thread Peter Hutterer
On Sat, Nov 01, 2014 at 08:00:57PM +0200, Michal Srb wrote: _XiGetExtensionVersion was called from XGetExtensionVersion and from _XiCheckExtInit. When called from _XiCheckExtInit, nothing accounted for the fact that it can return ((XExtensionVersion *) NoSuchExtension) in case of error. Also

[PATCH libXi 7/7] Refactor XGetExtensionVersion.

2014-11-01 Thread Michal Srb
_XiGetExtensionVersion was called from XGetExtensionVersion and from _XiCheckExtInit. When called from _XiCheckExtInit, nothing accounted for the fact that it can return ((XExtensionVersion *) NoSuchExtension) in case of error. Also it recursively calls _XiCheckExtInit potentionally causing