Re: [PATCH libxxtrans 2/2] Fix alignment issues in FD passing code

2013-11-21 Thread Mark Kettenis
> Date: Wed, 20 Nov 2013 22:03:49 -0800 > From: Alan Coopersmith > > On 11/20/13 02:50 AM, Mark Kettenis wrote: > >> Date: Tue, 12 Nov 2013 07:21:19 +0100 > >> From: Matthieu Herrb > >> > >> On Mon, Nov 11, 2013 at 11:22:56PM +0100, Mark Kettenis wrote: > >>> From: Mark Kettenis > >>> > >>> A c

Re: [PATCH libxxtrans 2/2] Fix alignment issues in FD passing code

2013-11-20 Thread Alan Coopersmith
On 11/20/13 02:50 AM, Mark Kettenis wrote: Date: Tue, 12 Nov 2013 07:21:19 +0100 From: Matthieu Herrb On Mon, Nov 11, 2013 at 11:22:56PM +0100, Mark Kettenis wrote: From: Mark Kettenis A char array on the stack is not guaranteed to have more than byte alignment. This means that casting it t

Re: [PATCH libxxtrans 2/2] Fix alignment issues in FD passing code

2013-11-20 Thread Mark Kettenis
> Date: Tue, 12 Nov 2013 07:21:19 +0100 > From: Matthieu Herrb > > On Mon, Nov 11, 2013 at 11:22:56PM +0100, Mark Kettenis wrote: > > From: Mark Kettenis > > > > A char array on the stack is not guaranteed to have more than byte > > alignment. This means that casting it to a 'struct cmsghdr' a

Re: [PATCH libxxtrans 2/2] Fix alignment issues in FD passing code

2013-11-11 Thread Matthieu Herrb
On Mon, Nov 11, 2013 at 11:22:56PM +0100, Mark Kettenis wrote: > From: Mark Kettenis > > A char array on the stack is not guaranteed to have more than byte > alignment. This means that casting it to a 'struct cmsghdr' and > accessing its members may result in unaligned access. This will > gener

[PATCH libxxtrans 2/2] Fix alignment issues in FD passing code

2013-11-11 Thread Mark Kettenis
From: Mark Kettenis A char array on the stack is not guaranteed to have more than byte alignment. This means that casting it to a 'struct cmsghdr' and accessing its members may result in unaligned access. This will generate SIGBUS on strict alignment architectures like OpenBSD/sparc64. The solu