Re: [PATCH v2 10/14] systemd-logind: Add systemd-logind core

2014-02-11 Thread Hans de Goede
Hi, On 02/11/2014 04:16 AM, Jasper St. Pierre wrote: As said before, with systemd user sessions, this will not happen. Unless I'm misremembering, Lennart has said that the only thing that should be inside the PAM session environment proper should be the session leader like gnome-session.

Re: [PATCH v2 10/14] systemd-logind: Add systemd-logind core

2014-02-11 Thread David Herrmann
Hi On Tue, Feb 11, 2014 at 9:10 AM, Hans de Goede hdego...@redhat.com wrote: Hi, On 02/11/2014 04:16 AM, Jasper St. Pierre wrote: As said before, with systemd user sessions, this will not happen. Unless I'm misremembering, Lennart has said that the only thing that should be inside the PAM

Re: [PATCH v2 10/14] systemd-logind: Add systemd-logind core

2014-02-10 Thread David Herrmann
Hi On Mon, Feb 10, 2014 at 10:48 PM, Hans de Goede hdego...@redhat.com wrote: Hi, On 02/10/2014 09:58 PM, Jasper St. Pierre wrote: Something I noticed here is that you use GetSessionByPID(). This works right now, but with systemd user sessions, the display server will run outside of a

Re: [PATCH v2 10/14] systemd-logind: Add systemd-logind core

2014-02-10 Thread Hans de Goede
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, On 02/10/2014 10:49 PM, David Herrmann wrote: Hi On Mon, Feb 10, 2014 at 10:48 PM, Hans de Goede hdego...@redhat.com wrote: Hi, On 02/10/2014 09:58 PM, Jasper St. Pierre wrote: Something I noticed here is that you use GetSessionByPID().

Re: [PATCH v2 10/14] systemd-logind: Add systemd-logind core

2014-02-10 Thread Jasper St. Pierre
As said before, with systemd user sessions, this will not happen. Unless I'm misremembering, Lennart has said that the only thing that should be inside the PAM session environment proper should be the session leader like gnome-session. (Disregarding the session worker process like

Re: [PATCH v2 10/14] systemd-logind: Add systemd-logind core

2014-02-10 Thread Peter Hutterer
On Tue, Feb 04, 2014 at 12:49:16PM +0100, Hans de Goede wrote: This commits add the bulk of the systemd-logind integration code, but does not hook it up yet other then calling its init and fini functions, which don't do that much. Note the configure bits check for udev since systemd-logind